From patchwork Tue Jun 22 19:13:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Rodriguez X-Patchwork-Id: 107482 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o5MJDv27023189 for ; Tue, 22 Jun 2010 19:13:57 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754568Ab0FVTNa (ORCPT ); Tue, 22 Jun 2010 15:13:30 -0400 Received: from mail.atheros.com ([12.36.123.2]:17222 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752615Ab0FVTN3 (ORCPT ); Tue, 22 Jun 2010 15:13:29 -0400 Received: from mail.atheros.com ([10.10.20.105]) by sidewinder.atheros.com for ; Tue, 22 Jun 2010 12:13:29 -0700 Received: from tux (10.10.11.197) by SC1EXHC-01.global.atheros.com (10.10.20.111) with Microsoft SMTP Server (TLS) id 8.2.213.0; Tue, 22 Jun 2010 12:13:27 -0700 Received: by tux (sSMTP sendmail emulation); Tue, 22 Jun 2010 12:13:25 -0700 Date: Tue, 22 Jun 2010 12:13:25 -0700 From: "Luis R. Rodriguez" To: Matthew Garrett CC: "Luis R. Rodriguez" , "linux-wireless@vger.kernel.org" , David Quan , "Luis R. Rodriguez" , linux-kernel , "ath5k-devel@venema.h4ckr.net" , Jonathan May , Jussi Kivilinna , Tim Gardner Subject: Re: [ath5k-devel] [PATCH v2] ath5k: disable ASPM Message-ID: <20100622191325.GF12659@tux> References: <20100622163138.GD20668@srcf.ucam.org> <20100622165213.GA21842@srcf.ucam.org> <20100622172545.GA22680@srcf.ucam.org> <20100622175058.GA23499@srcf.ucam.org> <20100622184426.GA24546@srcf.ucam.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100622184426.GA24546@srcf.ucam.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 22 Jun 2010 19:13:58 +0000 (UTC) diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig index b8b494b..9c76b70 100644 --- a/drivers/pci/pcie/Kconfig +++ b/drivers/pci/pcie/Kconfig @@ -31,14 +31,29 @@ source "drivers/pci/pcie/aer/Kconfig" # PCI Express ASPM # config PCIEASPM - bool "PCI Express ASPM support(Experimental)" - depends on PCI && EXPERIMENTAL && PCIEPORTBUS - default n + bool "PCI Express ASPM sanity check support" if EMBEDDED + depends on PCI && PCIEPORTBUS + default y help - This enables PCI Express ASPM (Active State Power Management) and - Clock Power Management. ASPM supports state L0/L0s/L1. + This enables some sanity checks for PCI Express ASPM. + ASPM supports the states L0/L0s/L1. The sanity checks are to + disable ASPM if: + + a) the device is pre-1.1 + b) the firmware has the FADT flag set to tell you not to + c) the firmware doesn't grant control via _OSC + + Without this option your BIOS's defaults will be respected + and while although this should always be correct it typically + is not. If your ASPM settings are incorrect you may experience + odd hangs which are hard to debug. These sanity checks should + help avoid these odd hangs by only enabling ASPM if we are + sure we can enable it. + + For more information you can refer to this documentation: + + http://wireless.kernel.org/en/users/Documentation/ASPM - When in doubt, say N. config PCIEASPM_DEBUG bool "Debug PCI Express ASPM" depends on PCIEASPM