From patchwork Fri Aug 6 18:48:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivo van Doorn X-Patchwork-Id: 117936 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o76IoB9m018256 for ; Fri, 6 Aug 2010 18:50:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761894Ab0HFSuI (ORCPT ); Fri, 6 Aug 2010 14:50:08 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:50196 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761842Ab0HFSuC (ORCPT ); Fri, 6 Aug 2010 14:50:02 -0400 Received: by mail-ey0-f174.google.com with SMTP id 25so2902634eya.19 for ; Fri, 06 Aug 2010 11:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=1IYeNKCuRrmSbqHY334FclNieFHkEq+WlCoAUAVEaaM=; b=DgyH8G04kBF/V80WBidHuf6bJd6p3APbd757eW+6Q+QOGLiEmDy6jSQ6/1QLHrGNbS MiktX/9cVtwOZuZq2vLKIGATc+SVD71kowtjavwFz5whOQ/1IUMCg79AA1ru2VDbeJ+F ZMRx6hfzKJ96VK1wyixO8JTMOv5kxnjldqyQs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=twGJ6H43+Bx/YMRuzWQBFd/YNcTdcRPMzccvRsGsJCHxg6tV7hxNkHP3LaRqIQYTbi oqNjCBzhnVihtpP1tJJdczwv+a2/wq9jt4co2fZmsm+wnQawXOYCPUgcGst8qByCYVEg 0apGC+iyj768Pg+mQzOiLwlEjNsRWA2uZkZnI= Received: by 10.213.31.129 with SMTP id y1mr9190730ebc.21.1281120601575; Fri, 06 Aug 2010 11:50:01 -0700 (PDT) Received: from localhost.localdomain (a0236.upc-a.chello.nl [62.163.0.236]) by mx.google.com with ESMTPS id v8sm2792911eeh.8.2010.08.06.11.50.00 (version=SSLv3 cipher=RC4-MD5); Fri, 06 Aug 2010 11:50:00 -0700 (PDT) From: Ivo van Doorn To: "John W. Linville" Subject: [PATCH 6/7] rt2x00: Update comments regarding TXWI and TX_STA_FIFO Date: Fri, 6 Aug 2010 20:48:27 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.32.16-150.fc12.x86_64; KDE/4.4.5; x86_64; ; ) Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org References: <201008062045.05288.IvDoorn@gmail.com> <201008062047.21710.IvDoorn@gmail.com> <201008062047.58607.IvDoorn@gmail.com> In-Reply-To: <201008062047.58607.IvDoorn@gmail.com> MIME-Version: 1.0 Message-Id: <201008062048.28764.IvDoorn@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Fri, 06 Aug 2010 18:50:12 +0000 (UTC) diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h index ed4ebcd..cf1f16b 100644 --- a/drivers/net/wireless/rt2x00/rt2800.h +++ b/drivers/net/wireless/rt2x00/rt2800.h @@ -1318,7 +1318,25 @@ #define TX_STA_CNT2_TX_UNDER_FLOW_COUNT FIELD32(0xffff0000) /* - * TX_STA_FIFO: TX Result for specific PID status fifo register + * TX_STA_FIFO: TX Result for specific PID status fifo register. + * + * This register is implemented as FIFO with 16 entries in the HW. Each + * register read fetches the next tx result. If the FIFO is full because + * it wasn't read fast enough after the according interrupt (TX_FIFO_STATUS) + * triggered, the hw seems to simply drop further tx results. + * + * VALID: 1: this tx result is valid + * 0: no valid tx result -> driver should stop reading + * PID_TYPE: The PID latched from the PID field in the TXWI, can be used + * to match a frame with its tx result (even though the PID is + * only 4 bits wide). + * TX_SUCCESS: Indicates tx success (1) or failure (0) + * TX_AGGRE: Indicates if the frame was part of an aggregate (1) or not (0) + * TX_ACK_REQUIRED: Indicates if the frame needed to get ack'ed (1) or not (0) + * WCID: The wireless client ID. + * MCS: The tx rate used during the last transmission of this frame, be it + * successful or not. + * PHYMODE: The phymode used for the transmission. */ #define TX_STA_FIFO 0x1718 #define TX_STA_FIFO_VALID FIELD32(0x00000001) @@ -1945,6 +1963,13 @@ struct mac_iveiv_entry { /* * Word1 + * ACK: 0: No Ack needed, 1: Ack needed + * NSEQ: 0: Don't assign hw sequence number, 1: Assign hw sequence number + * BW_WIN_SIZE: BA windows size of the recipient + * WIRELESS_CLI_ID: Client ID for WCID table access + * MPDU_TOTAL_BYTE_COUNT: Length of 802.11 frame + * PACKETID: Will be latched into the TX_STA_FIFO register once the according + * frame was processed. 0: Don't report tx status for this frame. */ #define TXWI_W1_ACK FIELD32(0x00000001) #define TXWI_W1_NSEQ FIELD32(0x00000002)