From patchwork Wed May 4 13:26:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Cavallari X-Patchwork-Id: 753762 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p44Da3HG019808 for ; Wed, 4 May 2011 13:36:03 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753753Ab1EDNgB (ORCPT ); Wed, 4 May 2011 09:36:01 -0400 Received: from lri.lri.fr ([129.175.15.1]:58041 "EHLO lri.lri.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753711Ab1EDNgA (ORCPT ); Wed, 4 May 2011 09:36:00 -0400 X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 04 May 2011 13:36:03 +0000 (UTC) X-Greylist: delayed 599 seconds by postgrey-1.27 at vger.kernel.org; Wed, 04 May 2011 09:36:00 EDT Received: from localhost (localhost [127.0.0.1]) by lri.lri.fr (Postfix) with ESMTP id 23410203C8; Wed, 4 May 2011 15:25:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at lri.fr Received: from lri.lri.fr ([127.0.0.1]) by localhost (lri.lri.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H4Qzzsj1u0C8; Wed, 4 May 2011 15:25:58 +0200 (CEST) Received: from pc11-132.lri.fr (pc11-132 [129.175.11.132]) by lri.lri.fr (Postfix) with ESMTP id B4DD7203E4; Wed, 4 May 2011 15:25:57 +0200 (CEST) Received: by pc11-132.lri.fr (Postfix, from userid 1000) id DB29C40055; Wed, 4 May 2011 15:26:52 +0200 (CEST) From: Nicolas Cavallari To: "John W. Linville" Cc: linux-wireless , Christian Lamparter Subject: [PATCH] carl9170: fix allmulticast mode Message-Id: <20110504132652.DB29C40055@pc11-132.lri.fr> Date: Wed, 4 May 2011 15:26:52 +0200 (CEST) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Currently, the driver only disable multicast filtering when the FIF_ALLMULTI driver flag has been just set (ie, if changed_flags& FIF_ALLMULTI and *new_flags& FIF_ALLMULTI) or else it will reenable multicast filtering. But next time, this condition will be false and multicast filtering will be reenabled, even through FIF_ALLMULTI is still set. This mean that allmulticast only works for less than two minutes in ad-hoc mode. This patch fixes that to disable multicast filtering as long as FIF_ALLMULTI is set. Signed-off-by: Nicolas Cavallari --- -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c index 0b370fe..7697445 100644 --- a/drivers/net/wireless/ath/carl9170/main.c +++ b/drivers/net/wireless/ath/carl9170/main.c @@ -901,7 +901,7 @@ static void carl9170_op_configure_filter(struct ieee80211_hw *hw, * then checking the error flags, later. */ - if (changed_flags & FIF_ALLMULTI && *new_flags & FIF_ALLMULTI) + if (*new_flags & FIF_ALLMULTI) multicast = ~0ULL; if (multicast != ar->cur_mc_hash)