From patchwork Fri Jul 8 09:03:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 956472 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6893nIi019880 for ; Fri, 8 Jul 2011 09:03:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031Ab1GHJDr (ORCPT ); Fri, 8 Jul 2011 05:03:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53743 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752492Ab1GHJDq (ORCPT ); Fri, 8 Jul 2011 05:03:46 -0400 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id E799B8A95F; Fri, 8 Jul 2011 11:03:45 +0200 (CEST) From: Jean Delvare Organization: Suse Linux To: linux-wireless@vger.kernel.org, Henry Ptasinski Subject: [PATCH] staging: brcm80211: Fix module parameter permissions Date: Fri, 8 Jul 2011 11:03:44 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.32.36-0.5-pae; KDE/4.3.5; i686; ; ) Cc: Brett Rudley , Roland Vossen , Arend van Spriel , "Greg Kroah-Hartman" MIME-Version: 1.0 Message-Id: <201107081103.44726.jdelvare@suse.de> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 08 Jul 2011 09:03:49 +0000 (UTC) The third parameter of module_param is supposed to represent sysfs file permissions. A value of "1" makes no sense. I am changing it to "0" to align with the other module parameters in this driver. Signed-off-by: Jean Delvare Cc: Henry Ptasinski Cc: Brett Rudley Cc: Roland Vossen Cc: Arend van Spriel Cc: Greg Kroah-Hartman --- drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-3.0-rc6.orig/drivers/staging/brcm80211/brcmfmac/dhd_linux.c 2011-05-30 20:45:16.000000000 +0200 +++ linux-3.0-rc6/drivers/staging/brcm80211/brcmfmac/dhd_linux.c 2011-07-08 10:14:52.000000000 +0200 @@ -300,7 +300,7 @@ module_param(dhd_pkt_filter_init, uint, /* Pkt filter mode control */ uint dhd_master_mode = true; -module_param(dhd_master_mode, uint, 1); +module_param(dhd_master_mode, uint, 0); /* Watchdog thread priority, -1 to use kernel timer */ int dhd_watchdog_prio = 97;