From patchwork Wed Aug 31 06:38:30 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 1115092 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7V6esUI031795 for ; Wed, 31 Aug 2011 06:40:54 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060Ab1HaGkv (ORCPT ); Wed, 31 Aug 2011 02:40:51 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:63560 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754046Ab1HaGkv (ORCPT ); Wed, 31 Aug 2011 02:40:51 -0400 Received: by pzk37 with SMTP id 37so819799pzk.1 for ; Tue, 30 Aug 2011 23:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=8TeLUY/EkMrF7zXfK008fzNdMycWmJZmBtJ0tTKfdL0=; b=qsPupvORvON5O+Z3lB9Zfx1NuECAa+4oaaCQsPIFEAlahVBoqnTnuYHycrptRs0XXR KqP2D1fLb+MgZbQmarnKUz5OFPPwgX8xCUuQAQSaJjroGDMmjeNdLle3nAeqVomtoMnl OUGY6EeTF3qsD59jyqOvxPCkq3uC+XUfNrecg= Received: by 10.68.199.67 with SMTP id ji3mr74646pbc.38.1314772850619; Tue, 30 Aug 2011 23:40:50 -0700 (PDT) Received: from shale.localdomain ([41.139.221.94]) by mx.google.com with ESMTPS id u2sm27947692pbq.9.2011.08.30.23.40.46 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 30 Aug 2011 23:40:50 -0700 (PDT) Date: Wed, 31 Aug 2011 09:38:30 +0300 From: Dan Carpenter To: emmanuel.grumbach@intel.com Cc: Wey-Yi Guy , Intel Linux Wireless , "John W. Linville" , "open list:INTEL WIRELESS WI..." , kernel-janitors@vger.kernel.org Subject: [patch -next 2/2] iwlwifi: signedness bug in iwl_trans_pcie_tx_agg_alloc() Message-ID: <20110831063830.GD3705@shale.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 31 Aug 2011 06:40:54 +0000 (UTC) unsigned shorts and unsigned chars are never == -1. Signed-off-by: Dan Carpenter Signed-off-by: Wey-Yi Guy --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c index 5dd6a6d..ea6a0bc 100644 --- a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c +++ b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c @@ -535,7 +535,7 @@ int iwl_trans_pcie_tx_agg_alloc(struct iwl_trans *trans, struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); struct iwl_tid_data *tid_data; unsigned long flags; - u16 txq_id; + int txq_id; struct iwl_priv *priv = priv(trans); txq_id = iwlagn_txq_ctx_activate_free(trans);