From patchwork Fri Mar 8 21:42:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Pecio X-Patchwork-Id: 2240391 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id D838BDF215 for ; Fri, 8 Mar 2013 21:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756762Ab3CHVmJ (ORCPT ); Fri, 8 Mar 2013 16:42:09 -0500 Received: from mail-wg0-f45.google.com ([74.125.82.45]:55221 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752940Ab3CHVmI (ORCPT ); Fri, 8 Mar 2013 16:42:08 -0500 Received: by mail-wg0-f45.google.com with SMTP id dq12so3079238wgb.12 for ; Fri, 08 Mar 2013 13:42:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:in-reply-to :references:x-mailer:mime-version:content-type :content-transfer-encoding; bh=EC05laua1kOSmPvuLa8rZ/7RXvK1V7nB6W7oy183Uhk=; b=Eqw2Vl87mYgEr7SfjLYQdEOTCUyqV9spj69mDjKui9RPEN9lrA60NMlB305eVSzn5q PwY4drnnXFEyulep2Wm7mR9jY2UPc08YvWnfbm4YnFSTx9s7iEzmqE8NyNv34IaRjHXs JcjMtWE63iBesfBIYIuKhTK6+9r6ViZGDhCMpmngLzXA6O7bQj4W6516XMYO5VbW2EfU kjbwzG7zo/0tYmmXrxjjaxYe7RHaHr4gayUH99zCNZHVVLzvnsXeKk0acp2QsRHhmE8N jyk/r/kGrPeBFA6n8pyntr/KhsF1GUV7NSWmDcK5vTUYc1VLgkymLOYOS26fvdXI+74/ bGtg== X-Received: by 10.180.90.2 with SMTP id bs2mr6136784wib.0.1362778927691; Fri, 08 Mar 2013 13:42:07 -0800 (PST) Received: from localhost.localdomain (212-87-13-66.sds.uw.edu.pl. [212.87.13.66]) by mx.google.com with ESMTPS id j4sm939945wiz.10.2013.03.08.13.42.06 (version=SSLv3 cipher=RC4-SHA bits=128/128); Fri, 08 Mar 2013 13:42:07 -0800 (PST) Date: Fri, 8 Mar 2013 22:42:03 +0100 From: =?UTF-8?B?TWljaGHFgg==?= Pecio To: "John W. Linville" Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] orinoco_usb: don't release nonexistent firmware Message-ID: <20130308224203.5fd4ff92@gmail.com> In-Reply-To: <20130308210220.GD402@tuxdriver.com> References: <20130307233341.6738c6e6@gmail.com> <20130308210220.GD402@tuxdriver.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Michal Pecio Initialize fw_entry to NULL to prevent cleanup code from passing bogus pointer to release_firmware() when priv allocation fails. Signed-off-by: Michal Pecio --- drivers/net/wireless/orinoco/orinoco_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/orinoco/orinoco_usb.c b/drivers/net/wireless/orinoco/orinoco_usb.c index 01624dc..2e998ac 100644 --- a/drivers/net/wireless/orinoco/orinoco_usb.c +++ b/drivers/net/wireless/orinoco/orinoco_usb.c @@ -1578,7 +1578,7 @@ static int ezusb_probe(struct usb_interface *interface, struct ezusb_priv *upriv = NULL; struct usb_interface_descriptor *iface_desc; struct usb_endpoint_descriptor *ep; - const struct firmware *fw_entry; + const struct firmware *fw_entry = NULL; int retval = 0; int i;