From patchwork Sun Nov 17 13:37:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 3194091 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AA3E0C045B for ; Sun, 17 Nov 2013 13:38:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9BE4320857 for ; Sun, 17 Nov 2013 13:38:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81A0820850 for ; Sun, 17 Nov 2013 13:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706Ab3KQNhs (ORCPT ); Sun, 17 Nov 2013 08:37:48 -0500 Received: from mail.skyhub.de ([78.46.96.112]:53812 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751981Ab3KQNho (ORCPT ); Sun, 17 Nov 2013 08:37:44 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1384695458; bh=4pp2Wf7uTg4yXePLTg/LIt/g1D30XOvaXWLBZyqn2rE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding; b=mI9upSYCPzeZ3W9EZZ+OfepoE8iyoeBUeQ2QJ SpR9Gwr70jSxJtQd4RwMb1R9ljqQOnTk7upHhOwIDeeJDRvTAMLa3Qpen48qyXOAu2X 9SkaKNmxquMdijcFSWTXstVgH2gp79tBUsf4QNxbJD2F6dx2v6lJZl6e5wrKU7FGJiM = Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id P+lx2TYVU9ok; Sun, 17 Nov 2013 14:37:36 +0100 (CET) Received: from liondog.tnic (p54B7F055.dip0.t-ipconnect.de [84.183.240.85]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3E7111DA258; Sun, 17 Nov 2013 14:37:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1384695456; bh=4pp2Wf7uTg4yXePLTg/LIt/g1D30XOvaXWLBZyqn2rE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding; b=hWIwkHvB9nbV/w7MZ9osgdvKgk79/fVwRyNFS 3Ji618boGurRkpwpvpL9TlzEZ1BNyW9mDAy3wAM/Krv/No+LdhhJ9O821l0PHw+So5K xAc1GeTeQcp5iFAQLnZ109BzVRw76A4Ndjaz4FazH1p37jhd3TtQfTuQIJHS32yvG/o = Received: by liondog.tnic (Postfix, from userid 1000) id C08D01028DB; Sun, 17 Nov 2013 14:37:02 +0100 (CET) Date: Sun, 17 Nov 2013 14:37:02 +0100 From: Borislav Petkov To: lkml Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-wireless@vger.kernel.org Subject: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS Message-ID: <20131117133702.GA30840@pd.tnic> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,T_TVD_MIME_EPI, UNPARSEABLE_RELAY,UPPERCASE_50_75 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Borislav Petkov When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get drivers/built-in.o: In function `brcms_led_unregister': (.text+0x351aca): undefined reference to `led_classdev_unregister' drivers/built-in.o: In function `brcms_led_register': (.text+0x351c65): undefined reference to `led_classdev_register' during the final linking stage because brcmsmac/led.c needs LEDS_CLASS for reg/dereg. Fix that. Cc: "Rafa? Mi?ecki" Cc: linux-wireless@vger.kernel.org Signed-off-by: Borislav Petkov --- I'm attaching the .config in question. drivers/bcma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig index 7c081b38ef3e..74dba9ca1413 100644 --- a/drivers/bcma/Kconfig +++ b/drivers/bcma/Kconfig @@ -74,7 +74,7 @@ config BCMA_DRIVER_GMAC_CMN config BCMA_DRIVER_GPIO bool "BCMA GPIO driver" - depends on BCMA && GPIOLIB + depends on BCMA && GPIOLIB && LEDS_CLASS help Driver to provide access to the GPIO pins of the bcma bus.