From patchwork Mon Nov 18 23:32:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 3199361 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B421E9F3A0 for ; Mon, 18 Nov 2013 23:33:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EA1CA20278 for ; Mon, 18 Nov 2013 23:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9923720340 for ; Mon, 18 Nov 2013 23:33:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751585Ab3KRXcv (ORCPT ); Mon, 18 Nov 2013 18:32:51 -0500 Received: from mail.skyhub.de ([78.46.96.112]:37957 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307Ab3KRXcu (ORCPT ); Mon, 18 Nov 2013 18:32:50 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1384817569; bh=JJ3mLIhvhFMYqI4smJwkuDx6BwSToPdvTihNNMgwZK8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=V0t5Nsp2s6btFWiqy1JpdC66ocCsN+FyGu0cQk fNEok7dL0DXXqvKxL6rWblcb+v69u9pEO8AmBh3h16V4qPSosZHSZBWGIVhH1KZabYn dsXNY9+Ibu69Mmxt5PMVvivIRLOYQ3uVP63l7WyhRKJAMLBnP1cuP5lrFBfO2UDLss= Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id htXnQtsG4JZr; Tue, 19 Nov 2013 00:32:49 +0100 (CET) Received: from liondog.tnic (p54B7E49A.dip0.t-ipconnect.de [84.183.228.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 39795244943; Tue, 19 Nov 2013 00:32:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1384817569; bh=JJ3mLIhvhFMYqI4smJwkuDx6BwSToPdvTihNNMgwZK8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=V0t5Nsp2s6btFWiqy1JpdC66ocCsN+FyGu0cQk fNEok7dL0DXXqvKxL6rWblcb+v69u9pEO8AmBh3h16V4qPSosZHSZBWGIVhH1KZabYn dsXNY9+Ibu69Mmxt5PMVvivIRLOYQ3uVP63l7WyhRKJAMLBnP1cuP5lrFBfO2UDLss= Received: by liondog.tnic (Postfix, from userid 1000) id 55091107160; Tue, 19 Nov 2013 00:32:47 +0100 (CET) Date: Tue, 19 Nov 2013 00:32:47 +0100 From: Borislav Petkov To: Arend van Spriel Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , lkml , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS Message-ID: <20131118233247.GM24851@pd.tnic> References: <20131117133702.GA30840@pd.tnic> <5289359B.8090506@broadcom.com> <20131118133250.GH24851@pd.tnic> <20131118204003.GK24851@pd.tnic> <528A925C.20602@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <528A925C.20602@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Nov 18, 2013 at 11:19:08PM +0100, Arend van Spriel wrote: > what about: > > config BRCMSMAC > tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver" > depends on MAC80211 > depends on BCMA_POSSIBLE > + select LEDS_CLASS if BCMA_DRIVER_GPIO > select BCMA I know, nice and short but too good to be true. LEDS_CLASS needs to pull in NEW_LEDS unfortunately: drivers/built-in.o: In function `set_brightness_delayed': led-class.c:(.text+0x4596e5): undefined reference to `led_stop_software_blink' drivers/built-in.o: In function `led_classdev_register': (.text+0x4598db): undefined reference to `leds_list_lock' drivers/built-in.o: In function `led_classdev_register': (.text+0x4598e7): undefined reference to `leds_list' drivers/built-in.o: In function `led_classdev_register': (.text+0x4598f3): undefined reference to `leds_list' drivers/built-in.o: In function `led_classdev_register': (.text+0x4598fa): undefined reference to `leds_list_lock' drivers/built-in.o: In function `led_classdev_register': (.text+0x459901): undefined reference to `leds_list' drivers/built-in.o: In function `led_classdev_unregister': (.text+0x4599a8): undefined reference to `led_stop_software_blink' drivers/built-in.o: In function `led_classdev_unregister': (.text+0x4599b2): undefined reference to `led_set_brightness' drivers/built-in.o: In function `led_classdev_unregister': (.text+0x4599c2): undefined reference to `leds_list_lock' drivers/built-in.o: In function `led_classdev_unregister': (.text+0x4599d6): undefined reference to `leds_list_lock' make: *** [vmlinux] Error 1 What works, instead, is below. I think my "depends" solution from earlier takes care of this without you having to select other stuff explicitly but in the end of the day, I don't really care all that much which one you guys take. diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig index b00a7e92225f..54e36fcb3954 100644 --- a/drivers/net/wireless/brcm80211/Kconfig +++ b/drivers/net/wireless/brcm80211/Kconfig @@ -5,6 +5,8 @@ config BRCMSMAC tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver" depends on MAC80211 depends on BCMA + select NEW_LEDS if BCMA_DRIVER_GPIO + select LEDS_CLASS if BCMA_DRIVER_GPIO select BRCMUTIL select FW_LOADER select CRC_CCITT