From patchwork Mon Nov 25 19:54:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 3234151 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 471D6C045B for ; Mon, 25 Nov 2013 19:55:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AFEA7202EA for ; Mon, 25 Nov 2013 19:55:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98958202DD for ; Mon, 25 Nov 2013 19:55:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757481Ab3KYTyq (ORCPT ); Mon, 25 Nov 2013 14:54:46 -0500 Received: from mail-bk0-f41.google.com ([209.85.214.41]:51228 "EHLO mail-bk0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755065Ab3KYTyo (ORCPT ); Mon, 25 Nov 2013 14:54:44 -0500 Received: by mail-bk0-f41.google.com with SMTP id v15so2227921bkz.28 for ; Mon, 25 Nov 2013 11:54:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=wl1Zcoj9jthBD2DKDkCwlEdYDab+AuDRfYRrlgTv3E0=; b=Nb39wn1iTzNGrnuEZ1JFpSlv7Ke+Xc2aTshfRgvQFMcY0aWt4gE3DmA2f1k7e0ZDBY FVQIDpZFY+wEMqcnj4eUdwsMT8OtvYf1tWg6/rFp40AYHaPdb0gTMfBshzWbbSNaQTNI 2OA8Fka6fVzZ/0ZpaiiZhCyfK3abTkApLg0MLtB08+QdZUoy7UY8BHlrzOFKqGbHrqI5 mMx//nTgZarnVA5ZMI/PWz5Pl6HtElGeaPytelTiMNuY0gUlKVamXxD/uY3whm+7iumZ sO0OxexQ045K23heOUFX7pE1HKdhHj/KBiOILz9bBvpx7b7+IzRhxditlViPxWZt+Gi9 zsVg== X-Received: by 10.205.65.132 with SMTP id xm4mr24858993bkb.1.1385409283455; Mon, 25 Nov 2013 11:54:43 -0800 (PST) Received: from pali-elitebook.localnet ([2001:718:1e03:a01::1ca]) by mx.google.com with ESMTPSA id pu8sm47870512bkb.9.2013.11.25.11.54.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Nov 2013 11:54:42 -0800 (PST) From: Pali =?utf-8?q?Roh=C3=A1r?= To: Felipe Contreras Subject: Re: [PATCH 00/16] wl1251 patches from linux-n900 tree Date: Mon, 25 Nov 2013 20:54:41 +0100 User-Agent: KMail/1.13.7 (Linux/3.11.0-14-generic; KDE/4.11.3; x86_64; ; ) Cc: Luciano Coelho , "John W. Linville" , Johannes Berg , "David S. Miller" , "linux-wireless Mailing List" , netdev@vger.kernel.org, Linux Kernel Mailing List , freemangordon@abv.bg, aaro.koskinen@iki.fi, Pavel Machek , sre@ring0.de, joni.lapilainen@gmail.com References: <1382819655-30430-1-git-send-email-pali.rohar@gmail.com> In-Reply-To: MIME-Version: 1.0 Message-Id: <201311252054.41177@pali> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday 08 November 2013 15:20:07 Felipe Contreras wrote: > On Sat, Oct 26, 2013 at 3:33 PM, Pali Rohár wrote: > > Hello, I'm sending wl1251 patches from linux-n900 tree [1] > > for comments. More patches come from David's monitor & > > packet injection work. Patches are tested with 3.12 rc5 > > kernel on Nokia N900. > > > > [1] - https://gitorious.org/linux-n900/linux-n900 > > How did you test these patches? I get a panic loop immediately > after I bring the interface loop in monitor mode (v3.12). Hi! now I can reproduce this crash with 3.12-rc5 kernel. Problem looks like irrelevant to this patch series and is present in 3.12 kernel. There is possible NULL pointer dereference. With this patch I'm not able to reproduce this bug: diff --git a/drivers/net/wireless/ti/wl1251/event.c b/drivers/net/wireless/ti/wl1251/event.c index 192cebd..db01053 100644 --- a/drivers/net/wireless/ti/wl1251/event.c +++ b/drivers/net/wireless/ti/wl1251/event.c @@ -124,7 +124,7 @@ static int wl1251_event_process(struct wl1251 *wl, struct event_mailbox *mbox) return ret; } - if (vector & SYNCHRONIZATION_TIMEOUT_EVENT_ID) { + if (wl->vif && vector & SYNCHRONIZATION_TIMEOUT_EVENT_ID) { wl1251_debug(DEBUG_EVENT, "SYNCHRONIZATION_TIMEOUT_EVENT"); /* indicate to the stack, that beacons have been lost */