From patchwork Tue May 5 05:19:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Okash Khawaja X-Patchwork-Id: 6333961 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E369D9F374 for ; Tue, 5 May 2015 05:19:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 136E720256 for ; Tue, 5 May 2015 05:19:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 100AC202BE for ; Tue, 5 May 2015 05:19:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755499AbbEEFTq (ORCPT ); Tue, 5 May 2015 01:19:46 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:35457 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755495AbbEEFTn (ORCPT ); Tue, 5 May 2015 01:19:43 -0400 Received: by wgyo15 with SMTP id o15so170011821wgy.2; Mon, 04 May 2015 22:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=l3+Or8WzZ0M1iNOrWzXZtuj4jO+osw38ISPKvjrYLCA=; b=xbwyEeCJbCJlEmZe5tI5cXiU0qdSeVu0dM+4AuRUw5BQEmlaja/1xQksowd/2k/s5A pfW6eQ9RAskF/WEPxH9pmA7Re3W11xLLc4Xko9iw4AdJaAD8RH/ILtCUz4GjkOHOVG3p j6VKl4p6rzH+MDWDu6EYvFtfOb00Uuy2mDdcVFeoR8qJWcjuDsSfLg0tlPNCRvqHSNT/ uzlrJtoVb/ac14fiXLhnXsjU40q88N73Sbw2pI+5zU+cyBfield+U6P5rFpfYObvWobN jRd0pAjQZvnVKCjkntn471QDmPj8x1vI6eDeUUoKG3rPYSzmR6LO3m7n4mMGPm7zLUjl 9yRA== X-Received: by 10.180.83.6 with SMTP id m6mr514643wiy.72.1430803181531; Mon, 04 May 2015 22:19:41 -0700 (PDT) Received: from bytefire-computer ([90.199.116.241]) by mx.google.com with ESMTPSA id o5sm14104412wia.0.2015.05.04.22.19.39 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 May 2015 22:19:40 -0700 (PDT) Date: Tue, 5 May 2015 06:19:38 +0100 From: Okash Khawaja To: Kalle Valo Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] adm8211: fix checkpatch error for trailing statements on next line Message-ID: <20150505051827.GA2463@bytefire-computer> References: <20150503104231.GA3607@bytefire-computer> <87lhh4wm3n.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87lhh4wm3n.fsf@kamboji.qca.qualcomm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, May 04, 2015 at 03:42:04PM +0300, Kalle Valo wrote: > Okash Khawaja writes: > > > This patch fixes the checkpatch.pl error: > > > > ERROR: trailing statements should be on next line > > > > More specifically, the fix has been applied to the four occurances of the error listed below. > > > > ERROR: trailing statements should be on next line > > #1101: FILE: drivers/net/wireless/adm8211.c:1101: > > + case 0x8: reg |= (0x1 << 14); > > > > ERROR: trailing statements should be on next line > > #1103: FILE: drivers/net/wireless/adm8211.c:1103: > > + case 0x16: reg |= (0x2 << 14); > > > > ERROR: trailing statements should be on next line > > #1105: FILE: drivers/net/wireless/adm8211.c:1105: > > + case 0x32: reg |= (0x3 << 14); > > > > ERROR: trailing statements should be on next line > > #1107: FILE: drivers/net/wireless/adm8211.c:1107: > > + default: reg |= (0x0 << 14); > > > > Signed-off-by: Okash Khawaja > > --- > > drivers/net/wireless/adm8211.c | 20 ++++++++++++-------- > > 1 file changed, 12 insertions(+), 8 deletions(-) > > The patch has incorrectly "staging:" prefix in the title, please fix > that. "adm8211:" is enough, you don't need anything for drivers in > drivers/net/wireless. > > -- > Kalle Valo Thanks Kalle for clarifying. I have removed "staging:" prefix and pasted the patch below. Signed-off-by: Okash Khawaja --- drivers/net/wireless/adm8211.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c index f07a618..79e4e5f 100644 --- a/drivers/net/wireless/adm8211.c +++ b/drivers/net/wireless/adm8211.c @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev) pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline); switch (cline) { - case 0x8: reg |= (0x1 << 14); - break; - case 0x16: reg |= (0x2 << 14); - break; - case 0x32: reg |= (0x3 << 14); - break; - default: reg |= (0x0 << 14); - break; + case 0x8: + reg |= (0x1 << 14); + break; + case 0x16: + reg |= (0x2 << 14); + break; + case 0x32: + reg |= (0x3 << 14); + break; + default: + reg |= (0x0 << 14); + break; } }