From patchwork Mon May 11 11:58:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Okash Khawaja X-Patchwork-Id: 6376291 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F30499F1C2 for ; Mon, 11 May 2015 11:58:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 245BB2027D for ; Mon, 11 May 2015 11:58:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 474E22026F for ; Mon, 11 May 2015 11:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753118AbbEKL6h (ORCPT ); Mon, 11 May 2015 07:58:37 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:33211 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbbEKL6g (ORCPT ); Mon, 11 May 2015 07:58:36 -0400 Received: by wief7 with SMTP id f7so84385393wie.0; Mon, 11 May 2015 04:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=MV+3uGD6+gCURFXB6Bfix0QRVqc0fPmHiePNkcmhdHs=; b=o95Z5jFBS+kMTspEJVr3qJGnff7jxlYDrd0Gt1g5SlEKyyiFZqAxpzZoKVacV/vqMi 4OWF47rPBr+PZyCYsrqKzZSrKMQTAZ+mnDpFyewku2xRqdjh9tqPTp+l4S1J2+ctlvEl V4O9tvimDDCdixe9t+Sr/UWE55/0/M18xxcM4jYBolozdmVat4IZuH62HVhQQ4Dxvyd/ AZcpXkNkxq4L279wKhMU6aprS5v/9+NUnyTHT3c47gAB2D3ECIWKpoRCXuEChVGc8vdF ubRJiluPotiICqMGjuhSd09Y9EbUNQ4XzuwUgDRTXlpo+9qRVfuITutOXooF+LTmZzWe 2A9A== X-Received: by 10.194.186.145 with SMTP id fk17mr19801634wjc.156.1431345514809; Mon, 11 May 2015 04:58:34 -0700 (PDT) Received: from bytefire-computer (188.29.164.101.threembb.co.uk. [188.29.164.101]) by mx.google.com with ESMTPSA id l3sm12951106wik.16.2015.05.11.04.58.33 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 11 May 2015 04:58:33 -0700 (PDT) Date: Mon, 11 May 2015 12:58:31 +0100 From: Okash Khawaja To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] adm8211: fixed the possible pci cache line sizes inside switch-case Message-ID: <20150511115831.GA5153@bytefire-computer> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150511114104.GA4985@bytefire-computer> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The PCI cache line size value was being compared against decimal values prefixed with 0x. Fixed the literals to use the correct hex values. This has not been tested due to lack of hardware. However, the value in `cline` is PCI cache line size, which is the CPU's cache line size. It is less likely for cache line sizes to be 22 or 50, and more likely for them to be 16 or 32. Also, as far as I understand, cache line size is used for things like aligning DMA requests with CPU cache line, which improve performance but wouldn't break anything if the value doesn't match. In this case, we will fall through to the default case which leaves `reg` unchanged. Signed-off-by: Okash Khawaja --- drivers/net/wireless/adm8211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c index 058fb4b..76c908f 100644 --- a/drivers/net/wireless/adm8211.c +++ b/drivers/net/wireless/adm8211.c @@ -1101,10 +1101,10 @@ static void adm8211_hw_init(struct ieee80211_hw *dev) case 0x8: reg |= (0x1 << 14); break; - case 0x16: + case 0x10: reg |= (0x2 << 14); break; - case 0x32: + case 0x20: reg |= (0x3 << 14); break; default: