From patchwork Sat Jan 30 05:57:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhaktipriya Shridhar X-Patchwork-Id: 8169631 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5EBCABEEE5 for ; Sat, 30 Jan 2016 05:58:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4AD5320396 for ; Sat, 30 Jan 2016 05:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48F1D20397 for ; Sat, 30 Jan 2016 05:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751703AbcA3F5m (ORCPT ); Sat, 30 Jan 2016 00:57:42 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36813 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbcA3F5l (ORCPT ); Sat, 30 Jan 2016 00:57:41 -0500 Received: by mail-pa0-f66.google.com with SMTP id y7so614265paa.3; Fri, 29 Jan 2016 21:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=eqLdfJoAzZpSR+liBrYKFitLczGWACzus2RLLouEDss=; b=b6XvgXX8y6Oxbm+zwMmpA37OLzOWIRQ9+0Gy3pPzt5I9Zvg4LEsyct74nAkrQNi37a AX9/UB/SoBhrr6aZEERbZIvSPEBuoch9TWxUi8/l8Gu934uFvNQRpEbsbeiP5MRK8lMx ADJEg556D3MITBmX7rZwHLcUwmBoNqg/pV5BrMadWyDQ6hekk8JSXQJfnH+Pu8McEkHT lyyN6KSiDIyG0Me4JWg+aH0MbgQZ8OihHx+rcyeWNDez2lTqkbDRTXbpX58yp/EdcyQA CgJB7QHJg+ehYpSyb9PXeFQSJ2VmX39qnvhRnM5V7Xd9zSLxMiBo8+OLDFI3U0pXjGeZ fB7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=eqLdfJoAzZpSR+liBrYKFitLczGWACzus2RLLouEDss=; b=D7LDILtg08oN8pkIWHEKcF19jzIU0gbc+8LXANlFdrGTlB6Vp1L5qF2arBUeESd8ZZ 30nSQeOkQIVmTrw2ICgp60YnQ7TWfKOliz2xl5omV1UhHwqJOwZPilt07z1n5C0O62q5 a0RvbGkhqVj9unEWzhgdhKaHPURO7gZmdUkONL1ESoLHs4OSLZtqesDFZZJHkcTiyvJ5 rPd6kwwH5sSZ3oWTxFb7qtjhCNb2zdSYMENkQc4yY9dBfHniUb3SyImYh/SMEXbGlXji GGP7GZQ81OOqheqyeGT8a1wjEMNGdg45GYE0o+VPVfJX7zf8ARwoA2fpVcilE3HiRbd9 NE8A== X-Gm-Message-State: AG10YORqgjOztSBjkVSSfNlU1qMwcbOVBnMivdkdUOj4vKKmWgyrPDcWtUXugIPwU+4LEw== X-Received: by 10.67.6.67 with SMTP id cs3mr19673694pad.143.1454133460585; Fri, 29 Jan 2016 21:57:40 -0800 (PST) Received: from Karyakshetra ([14.139.82.6]) by smtp.gmail.com with ESMTPSA id 26sm27391980pfo.55.2016.01.29.21.57.39 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jan 2016 21:57:40 -0800 (PST) Date: Sat, 30 Jan 2016 11:27:47 +0530 From: Bhaktipriya Shridhar To: Larry Finger , Jes Sorensen , Greg Kroah-Hartman , Joe Perches , Bhaktipriya Shridhar , Alexander Kuleshov , Haneen Mohammed , Andreas Ruprecht Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: rtl8723au: Fixes unnecessary return warning Message-ID: <20160130055747.GA16656@Karyakshetra> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. WARNING: void function return statements are not generally useful Signed-off-by: Bhaktipriya Shridhar Reviewed-by: Julian Calaby --- Changes in v2: - Removed the unnecessary blank lines. drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 20 -------------------- 1 file changed, 20 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index d28f29a..7cd0052 100644 --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c @@ -2656,8 +2656,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da) pattrib->last_txcmdsz = pattrib->pktlen; dump_mgntframe23a(padapter, pmgntframe); - - return; } static int _issue_probereq(struct rtw_adapter *padapter, @@ -2957,8 +2955,6 @@ static void issue_auth(struct rtw_adapter *padapter, struct sta_info *psta, rtw_wep_encrypt23a(padapter, pmgntframe); DBG_8723A("%s\n", __func__); dump_mgntframe23a(padapter, pmgntframe); - - return; } #ifdef CONFIG_8723AU_AP_MODE @@ -3338,8 +3334,6 @@ exit: } } else kfree(pmlmepriv->assoc_req); - - return; } /* when wait_ack is true, this function should be called at process context */ @@ -4102,8 +4096,6 @@ static void rtw_site_survey(struct rtw_adapter *padapter) pmlmeext->chan_scan_time = SURVEY_TO; pmlmeext->sitesurvey_res.state = SCAN_DISABLE; } - - return; } /* collect bss info from Beacon and Probe request/response frames. */ @@ -4759,8 +4751,6 @@ void report_survey_event23a(struct rtw_adapter *padapter, rtw_enqueue_cmd23a(pcmdpriv, pcmd_obj); pmlmeext->sitesurvey_res.bss_cnt++; - - return; } void report_surveydone_event23a(struct rtw_adapter *padapter) @@ -4802,8 +4792,6 @@ void report_surveydone_event23a(struct rtw_adapter *padapter) DBG_8723A("survey done event(%x)\n", psurveydone_evt->bss_cnt); rtw_enqueue_cmd23a(pcmdpriv, pcmd_obj); - - return; } void report_join_res23a(struct rtw_adapter *padapter, int res) @@ -4850,8 +4838,6 @@ void report_join_res23a(struct rtw_adapter *padapter, int res) rtw_joinbss_event_prehandle23a(padapter, (u8 *)&pjoinbss_evt->network); rtw_enqueue_cmd23a(pcmdpriv, pcmd_obj); - - return; } void report_del_sta_event23a(struct rtw_adapter *padapter, @@ -4906,8 +4892,6 @@ void report_del_sta_event23a(struct rtw_adapter *padapter, DBG_8723A("report_del_sta_event23a: delete STA, mac_id =%d\n", mac_id); rtw_enqueue_cmd23a(pcmdpriv, pcmd_obj); - - return; } void report_add_sta_event23a(struct rtw_adapter *padapter, @@ -4951,8 +4935,6 @@ void report_add_sta_event23a(struct rtw_adapter *padapter, DBG_8723A("report_add_sta_event23a: add STA\n"); rtw_enqueue_cmd23a(pcmdpriv, pcmd_obj); - - return; } /**************************************************************************** @@ -5394,8 +5376,6 @@ static void link_timer_hdl(unsigned long data) issue_assocreq(padapter); set_link_timer(pmlmeext, REASSOC_TO); } - - return; } static void addba_timer_hdl(unsigned long data)