From patchwork Thu Jun 9 05:06:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mohammed Shafi Shajakhan X-Patchwork-Id: 9166217 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4E07560467 for ; Thu, 9 Jun 2016 05:07:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40DF626490 for ; Thu, 9 Jun 2016 05:07:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 35B8328294; Thu, 9 Jun 2016 05:07:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CC0B426490 for ; Thu, 9 Jun 2016 05:07:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945938AbcFIFHO (ORCPT ); Thu, 9 Jun 2016 01:07:14 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59336 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426641AbcFIFHJ (ORCPT ); Thu, 9 Jun 2016 01:07:09 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D4124613D2; Thu, 9 Jun 2016 05:07:08 +0000 (UTC) Received: from atheros-ThinkPad-T61 (unknown [202.46.23.62]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mohammed@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 84D45613B9; Thu, 9 Jun 2016 05:07:06 +0000 (UTC) Date: Thu, 9 Jun 2016 10:36:58 +0530 From: Mohammed Shafi Shajakhan To: Sven Eckelmann Cc: "Valo, Kalle" , "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" , marek.lindner@open-mesh.com Subject: Re: [PATCH 0/2] ath10k: Add support for QCA9887 Message-ID: <20160609050657.GA31330@atheros-ThinkPad-T61> References: <1568876.Six5hABE57@bentobox> <2262792.6VVL0Htyzj@bentobox> <20160607145002.GB11250@atheros-ThinkPad-T61> <2104766.hdzL6bzVNd@bentobox> <20160607171110.GA13293@atheros-ThinkPad-T61> <20160608124308.GB29340@atheros-ThinkPad-T61> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160608124308.GB29340@atheros-ThinkPad-T61> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Sven, i have something like this as of now(generically disabling TX-STBC for streams <= 1 just like ath9k does --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -4194,6 +4194,9 @@ static struct ieee80211_sta_vht_cap ath10k_create_vht_cap(struct ath10k *ar) mcs_map |= IEEE80211_VHT_MCS_NOT_SUPPORTED << (i * 2); } + if (ar->cfg_tx_chainmask <= 1) + vht_cap.cap &= ~IEEE80211_VHT_CAP_TXSTBC; + vht_cap.vht_mcs.rx_mcs_map = cpu_to_le16(mcs_map); vht_cap.vht_mcs.tx_mcs_map = cpu_to_le16(mcs_map); @@ -4231,7 +4234,7 @@ static struct ieee80211_sta_ht_cap ath10k_get_ht_cap(struct ath10k *ar) ht_cap.cap |= smps; } - if (ar->ht_cap_info & WMI_HT_CAP_TX_STBC) + if (ar->ht_cap_info & WMI_HT_CAP_TX_STBC && (ar->cfg_tx_chainmask > 1)) ht_cap.cap |= IEEE80211_HT_CAP_TX_STBC; if (ar->ht_cap_info & WMI_HT_CAP_RX_STBC) {