From patchwork Tue Aug 30 19:05:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhaktipriya Shridhar X-Patchwork-Id: 9305933 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8262B601C0 for ; Tue, 30 Aug 2016 19:06:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 751C228D16 for ; Tue, 30 Aug 2016 19:06:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A2AD28D1A; Tue, 30 Aug 2016 19:06:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 18F0428D16 for ; Tue, 30 Aug 2016 19:06:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755835AbcH3TFO (ORCPT ); Tue, 30 Aug 2016 15:05:14 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33244 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702AbcH3TFL (ORCPT ); Tue, 30 Aug 2016 15:05:11 -0400 Received: by mail-pa0-f66.google.com with SMTP id vy10so1485814pac.0; Tue, 30 Aug 2016 12:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=avDhrdMiIVkuifvHqyCO3BnVF6NihnPe9BiG/x+baxk=; b=QbL9UACN+IU1ehyhwHo/52u6db6zXekHPj6h26X6LIlEtrY7BLLmGPBz/ng+i2yrhR acc7vX+vFPsitl0NvOevPgvgKpxu2p8kY3+t6eHjIIZ7F26m3RWg7C3G3H/vNJXZtaeD QyR2IPpyCzvqiJjLPiu8No0YPXJeyM47FgaPxI2EI+IdNlazvar1s3nJU5Q8xDmcdxfZ lAy4P6wkkn+59i/ytXThxTOVI93u9ArqvJ24cr+ZGbtcFom0IBmbmkbyUmENC4OoYZ5o TqcZZT31uBLWejIn+9WaTvq6C8CJG6CtO2MdQ270teIcfXR27wD3xFeAmO0pYYD+TdpF cvyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=avDhrdMiIVkuifvHqyCO3BnVF6NihnPe9BiG/x+baxk=; b=e0SJHl+9qMfVx83wDpkKEk7yZO8w/EfC9RqZ7/Qo9nTjnZz975jKWZNJ+YM9snOPPL STfysJT9nNdn92oiKy7/0RaynjwayJ6pIVENpr2j1PsT2dxAeNwehRNbPP9BWKm6Yp5v cDg1vducHMzPjsOBYtPHAk4HwCQtszhN9wROjcw/EnT7N+Yj66EbqnfXKssT+sNA2Z3s ynuGwwOW4ma8/mg5ITleTpc1N6VBUtM8sYn3tge4i5obe946qHFgBCyJqi/4hRHbNivj OfJ8h7WdXAUYfVZ37WvM5Z3l/TyBEYBjaCWt8m5FGBgtW8XBeJoY9u9amSDMin22Vvbz yMOg== X-Gm-Message-State: AE9vXwNkgUNFy0velMeoJUP7aKg52OKizdXW3rV0QjFtLnTaWrG0uu2Xh3xk8ZAg5y94LA== X-Received: by 10.66.171.197 with SMTP id aw5mr8932285pac.36.1472583910440; Tue, 30 Aug 2016 12:05:10 -0700 (PDT) Received: from Karyakshetra ([14.139.82.6]) by smtp.gmail.com with ESMTPSA id o2sm59032484pfg.10.2016.08.30.12.05.09 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Aug 2016 12:05:09 -0700 (PDT) Date: Wed, 31 Aug 2016 00:35:07 +0530 From: Bhaktipriya Shridhar To: Johannes Berg , "David S. Miller" Cc: Tejun Heo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] cfg80211: Remove deprecated create_singlethread_workqueue Message-ID: <20160830190507.GA11493@Karyakshetra> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The workqueue "cfg80211_wq" is involved in cleanup, scan and event related works. It queues multiple work items &rdev->event_work, &rdev->dfs_update_channels_wk, &wiphy_to_rdev(request->wiphy)->scan_done_wk, &wiphy_to_rdev(wiphy)->sched_scan_results_wk, which require strict execution ordering. Hence, an ordered dedicated workqueue has been used. Since it's a wireless driver, WQ_MEM_RECLAIM has been set to ensure forward progress under memory pressure. Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo --- net/wireless/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4 diff --git a/net/wireless/core.c b/net/wireless/core.c index d25c82b..2cd4563 100644 --- a/net/wireless/core.c +++ b/net/wireless/core.c @@ -1218,7 +1218,7 @@ static int __init cfg80211_init(void) if (err) goto out_fail_reg; - cfg80211_wq = create_singlethread_workqueue("cfg80211"); + cfg80211_wq = alloc_ordered_workqueue("cfg80211", WQ_MEM_RECLAIM); if (!cfg80211_wq) { err = -ENOMEM; goto out_fail_wq;