From patchwork Sun Sep 18 06:30:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 9337611 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8C9BA6022E for ; Sun, 18 Sep 2016 06:32:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 683F228C6E for ; Sun, 18 Sep 2016 06:32:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 47F8828D02; Sun, 18 Sep 2016 06:32:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB5AF28C6E for ; Sun, 18 Sep 2016 06:32:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754739AbcIRGai (ORCPT ); Sun, 18 Sep 2016 02:30:38 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36179 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754009AbcIRGah (ORCPT ); Sun, 18 Sep 2016 02:30:37 -0400 Received: by mail-pf0-f194.google.com with SMTP id n24so5589551pfb.3; Sat, 17 Sep 2016 23:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z0cZO2PT4epDFsPDX1on1eykCQ1u8XNbOsCSBK4J1NY=; b=SOnqVpugrl3wOdz7L51klJuwrQqpjX4hErp22rRZMrS+F/aNZq/fmyNnUM/JOKAtrl 4+9HUMtpoOWV2pJvP8Izd14FM0l1O1E3xDXpywWdtBqAX4yDDBVRBi8c8stxHKQos5Ig bd7Ki243jyQNhPrpY9Q2SQlsDg/V4BmbP3zzbSfMoh01pBwseirCRGDI9esmlFqxRSyo TnLfe8LVXoGNWbfocyG5p2wYeEwzWwbNt4BR0hfTm9RI5LnMjhrxgANmyRuAASLGZWs0 U9wCXjuD5bs9a/TsIMeEJ2W3nqR5zM7rZDAg7MK8cXA65SYaGMz1m9AzzqKUIW74ZVPq kx6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z0cZO2PT4epDFsPDX1on1eykCQ1u8XNbOsCSBK4J1NY=; b=ATzwt1xvqK6ID1iDBMUC6FT+KamUai//8zEUOSm2ouMwviYOEyDu7HIYkSMRftQGhE jIqzKNLYDl+ZnfQ9bRo63KgUMaNQJ59jn8gHwAImjoUbEvBI+bfrKQbuHDwKpVIGCzBg 4QcOcUHZQKbiifUvaw+Z0PaWyxLFIHJLJw7ESFyW5btwxJlW2ss5ker1mvDKFynVkrn8 t/Uj07lgnp9mk129T60Ef/BR816y+NWswTK5uadENk8w/+qAyhigeZbhU4AlO0/9PM+K rwuttrK10mb+jn5P9sWp1/U30PVk8vwRG2esqW7PZU+za3jhAlXWGPBnT+WBjWEvmT4J U8+w== X-Gm-Message-State: AE9vXwPUyBq5mVs91EkAu9DQCGCEQ1N7aOCp4I84fB1UCk9My49U9rnSM1rrzAp5Ki6F/g== X-Received: by 10.98.61.27 with SMTP id k27mr36195642pfa.27.1474180237028; Sat, 17 Sep 2016 23:30:37 -0700 (PDT) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id x126sm62572225pfx.61.2016.09.17.23.30.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 17 Sep 2016 23:30:36 -0700 (PDT) From: Chaehyun Lim To: kvalo@qca.qualcomm.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Chaehyun Lim Subject: [PATCH] ath6kl: fix return value in ath6kl_wmi_set_pvb_cmd Date: Sun, 18 Sep 2016 15:30:24 +0900 Message-Id: <20160918063024.2535-1-chaehyun.lim@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When building with W=1, we got one warning as belows: drivers/net/wireless/ath/ath6kl/wmi.c:3509:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] At the end of ath6kl_wmi_set_pvb_cmd, it is returned by 0 regardless of return value of ath6kl_wmi_cmd_send. This patch fixes return value from 0 to ret that has result of ath6kl_wmi_cmd_send execution. Signed-off-by: Chaehyun Lim --- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index b8cf04d..3fd1cc9 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -3520,7 +3520,7 @@ int ath6kl_wmi_set_pvb_cmd(struct wmi *wmi, u8 if_idx, u16 aid, ret = ath6kl_wmi_cmd_send(wmi, if_idx, skb, WMI_AP_SET_PVB_CMDID, NO_SYNC_WMIFLAG); - return 0; + return ret; } int ath6kl_wmi_set_rx_frame_format_cmd(struct wmi *wmi, u8 if_idx,