From patchwork Tue Sep 27 10:12:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 9351657 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 23B94600CB for ; Tue, 27 Sep 2016 10:13:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 14E44291A5 for ; Tue, 27 Sep 2016 10:13:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 09A04291B1; Tue, 27 Sep 2016 10:13:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 91B2F291A5 for ; Tue, 27 Sep 2016 10:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753873AbcI0KMp (ORCPT ); Tue, 27 Sep 2016 06:12:45 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33641 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbcI0KMk (ORCPT ); Tue, 27 Sep 2016 06:12:40 -0400 Received: by mail-lf0-f65.google.com with SMTP id l131so1550087lfl.0; Tue, 27 Sep 2016 03:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FSrK/8mowsWiFcgfThOW/B9XfrCiiOiHvGpmG/r2eyc=; b=za3hNePoavXeFMgudaPrLeLRF1E4BsU0rr4xLSI3Dll0Y8kz0RKq4YOs7W8Lhn4U/R d5i1EONvmHylpnC4iTCkIxazjVw63SLuEmpUUZw6vwfpWDLAvn9vjtb+3g/rkS2Iid1c 7P1AFNqF8sAOz/Qw7H2WTLaVIxQdosk5nMdzed5fWoc0RanFJhoKVXF/YPnhW/Xv7Bil BYDtOPRhR0Jkz6JkFk0yp7NRMn0cOArwwCM2X2EFrrbK+pG2BgL9JGhP+LosTDi0mDUf ZYQBYwVIsJcbiM+BY3Ow//U0wGWR1aCGYHDVSzU82Rfr0OPAXJMb1TZxj/EZl6dTcuwu HWng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FSrK/8mowsWiFcgfThOW/B9XfrCiiOiHvGpmG/r2eyc=; b=PyLnuXJy3d832pveug15ZXRoQCeAEFDyUjWFizN9H6KPY02glYDebA30byA6s+x4N1 6cmKpRvU7WXeq/5geSNeZP0RRfOYx5ne1OyfY4K+I0Jq7+l/Bjm4wtwk7gzlUFgoyi13 OtRqYgKEHJsq3ZTIB2yafrzoRtb3btM3uP/vOOeSIEmadKwDqLxjp+bA5LdqiR2fYEHi HPmRP0QhMtKvmtLnck0qC/7iayWizqY3PjwtDivznoPlufmrtPe7Z6vs0YtPJE/mcr6I nRB6N4vQZwhBwQf9dd/i7Z5r60NeL3FLPyssqKnC4E8c8Mc/Q1jYxOw7M5YjcDXic13P DU4w== X-Gm-Message-State: AE9vXwM3TxlhZVORQOMiNf+OzwfikGfXXUA8Uy9VSFfuyGHlXw+0SlRg94ITQkUMXci4kQ== X-Received: by 10.25.29.85 with SMTP id d82mr10001012lfd.60.1474971158290; Tue, 27 Sep 2016 03:12:38 -0700 (PDT) Received: from linux-samsung.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id k129sm286168lfg.37.2016.09.27.03.12.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Sep 2016 03:12:37 -0700 (PDT) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Kalle Valo Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , Franky Lin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH] brcmfmac: replace WARNING on timeout with a simple error message Date: Tue, 27 Sep 2016 12:12:24 +0200 Message-Id: <20160927101224.3534-1-zajec5@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rafał Miłecki Even with timeout increased to 950 ms we get WARNINGs from time to time. It mostly happens on A-MPDU stalls (e.g. when station goes out of range). It may take up to 5-10 secods for the firmware to recover and for that time it doesn't process packets. It's still useful to have a message on time out as it may indicate some firmware problem and incorrect key update. Raising a WARNING however wasn't really that necessary, it doesn't point to any driver bug anymore and backtrace wasn't much useful. Signed-off-by: Rafał Miłecki Acked-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index 6d046ba..9e6f60a 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -1161,7 +1161,8 @@ int brcmf_netdev_wait_pend8021x(struct brcmf_if *ifp) !brcmf_get_pend_8021x_cnt(ifp), MAX_WAIT_FOR_8021X_TX); - WARN_ON(!err); + if (!err) + brcmf_err("Timed out waiting for no pending 802.1x packets\n"); return !err; }