From patchwork Mon Oct 10 07:19:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Rorvick X-Patchwork-Id: 9369075 X-Patchwork-Delegate: luca@coelho.fi Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BF863607FD for ; Mon, 10 Oct 2016 07:20:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAD2128ECC for ; Mon, 10 Oct 2016 07:20:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9D80828ED0; Mon, 10 Oct 2016 07:20:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF1AA28ECC for ; Mon, 10 Oct 2016 07:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbcJJHTg (ORCPT ); Mon, 10 Oct 2016 03:19:36 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:32813 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830AbcJJHTf (ORCPT ); Mon, 10 Oct 2016 03:19:35 -0400 Received: by mail-it0-f65.google.com with SMTP id m138so527124itm.0; Mon, 10 Oct 2016 00:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=C0QbT5/YYMSkRcMVqcJ1QXYbozz/UswTy7U/PFiNLQM=; b=IF259nB6D/ubtzEu3ZoQ5lc4aaWsiPe15jUNT/2Mmhyqy+3fubOeqMHBUt+3hDmniY oCTZKiH2V856/3CCCLTREuyY6uIHvOn4p5PgfRa+qAarhlzfbLRglWkGBImQrkrp0xnQ geUWD7iB1Au9aIF7V2W4/LXAQQajzflakt+cdp6C92v9gpJmmjD1jtMTB/tXRERLACMI f6s/EC5kZB/WX8u8cIxx5c7ufQ+2/oiGuDLrQqw7hhuCZ+2dRJKCKXyOzRhp/LcUpuJC 0cUB9Kg9dsEWiMOijGy6aMNhoZp2iY/pHsSmqbikNgODjGDSmRA+fBwadWmVOpZCXrBX WRZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=C0QbT5/YYMSkRcMVqcJ1QXYbozz/UswTy7U/PFiNLQM=; b=ET9HoL8dXCJqnTPFYBnWafwFqt8Tja4VV/WyS7DZlHtRg2XPNWnE4C0yAp1HwEZuko x4fIpNpfI2kaGcPD3+Diwq7yWqQK2kkIOVHbzXuDe6DvEMK+ExwE97ocycqvaYnuGzxi II6yeCHxO7IFdhUMvs9iNbGA/dsm8K7D5O+gAGSvPa8+7cOerPWlcWaya2iTtfRLG9r0 yY3FXPDonCVJNxqS8pUDRd8ZNpQRDH4oU55lbbGe+hEf89ZEn1vsEKb+Rt6fVBSEpoG+ ugAMU+I+c1t1sAwg5URdnbGuBntGg2gwghWbwh+QDwtUKESeaStzgRJo9Lxd+wYdPOMw 4suw== X-Gm-Message-State: AA6/9RkCYj/1/oMQl6kycJgFS5VLOkkKjQwtr4lfLRfJ62U1zIpFb15XmQ/ImX8i7YdDog== X-Received: by 10.36.90.202 with SMTP id v193mr8991558ita.120.1476083974406; Mon, 10 Oct 2016 00:19:34 -0700 (PDT) Received: from marlin (c-67-163-43-251.hsd1.il.comcast.net. [67.163.43.251]) by smtp.gmail.com with ESMTPSA id y132sm6227561itc.20.2016.10.10.00.19.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Oct 2016 00:19:33 -0700 (PDT) Received: from marlin (localhost [127.0.0.1]) by marlin (8.14.9/8.14.9) with ESMTP id u9A7JlMg004760; Mon, 10 Oct 2016 02:19:47 -0500 Received: (from chris@localhost) by marlin (8.14.9/8.14.9/Submit) id u9A7Jkpl004759; Mon, 10 Oct 2016 02:19:46 -0500 From: Chris Rorvick To: Intel Linux Wireless , Luca Coelho , Emmanuel Grumbach , Johannes Berg , Kalle Valo , Oren Givon Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Rorvick Subject: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Date: Mon, 10 Oct 2016 02:19:43 -0500 Message-Id: <20161010071943.4717-1-chris@rorvick.com> X-Mailer: git-send-email 2.10.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit bcb079a14d75 ("iwlwifi: pcie: retrieve and parse ACPI power limitations") looks for a specific structure in the ACPI tables for setting the default power limit. The data returned for at least some dual band chipsets is not recognized, though. For example, the AC 8260 reports the following: Name (SPLX, Package (0x04) { Zero, Package (0x03) { 0, 1200, 1000 }, Package (0x03) { 0, 1200, 1000 }, Package (0x03) { 0, 1200, 1000 } }) The current logic expects exactly two elements in the outer package, causing the above to be ignored and the power limit unset. Despite the interface being fully functional after initialization, the above condition is reported as an error. Knock the message down to a warning and provide better context for understanding its consequence. Signed-off-by: Chris Rorvick --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c index 78cf9a7..19b531f 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c @@ -540,7 +540,7 @@ static u64 splx_get_pwr_limit(struct iwl_trans *trans, union acpi_object *splx) splx->package.count != 2 || splx->package.elements[0].type != ACPI_TYPE_INTEGER || splx->package.elements[0].integer.value != 0) { - IWL_ERR(trans, "Unsupported splx structure\n"); + IWL_WARN(trans, "Unsupported splx structure, not limiting WiFi power\n"); return 0; }