From patchwork Wed Nov 9 05:50:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kirtika Ruchandani X-Patchwork-Id: 9418505 X-Patchwork-Delegate: luca@coelho.fi Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 29F26601C0 for ; Wed, 9 Nov 2016 05:51:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 173F028A0B for ; Wed, 9 Nov 2016 05:51:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 090E328A1F; Wed, 9 Nov 2016 05:51:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93E9628A0B for ; Wed, 9 Nov 2016 05:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbcKIFu4 (ORCPT ); Wed, 9 Nov 2016 00:50:56 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36360 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbcKIFuy (ORCPT ); Wed, 9 Nov 2016 00:50:54 -0500 Received: by mail-pf0-f194.google.com with SMTP id n85so22252461pfi.3 for ; Tue, 08 Nov 2016 21:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=a6NzhMZhn7akgvlCtdkMuhFNfdOzz2OM3g9GlvvGD+o=; b=wFpQOCws4eIp9k3C0OXUAg+Y3etebXgnYY+Lg3YCGv2uSqyDvfigmWfujClbrBK9u3 SyMBYQZ3/6vN5u+w9uUuO4zsmzOmX/CFnvPmggXM0NCcio9uH/35b8Uf2cUzTnwAFLlx o2ttMDH5K3X8b17HvqcLqW+ak2RJsqpUUBFJXrJooPunEMQnBSI9i+im4hBct65ByNz+ PM6tXVxTGvg/tJC6zBzbSKD+C7HF7OyAOyaDMII0r066wp3NeSIr61NjMbLm1DB1vXg/ SEkv8fCT7+s1OPpqRvKA6OSe3iflXXXoH+RH7D0Yi9CohTbYUeGms4qC/iEAkzWORoWn J9tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=a6NzhMZhn7akgvlCtdkMuhFNfdOzz2OM3g9GlvvGD+o=; b=hs43pGzj1KkwaFJOrNY36nJyg5iYsTtL7NuDCyQMkrCtkic+RJhu9JfKPh3vncWh2r 2m9xBq7QA19LK3ugXptOFqtAXOxepTS9lV5menSeV+HrQ+NwtOLKW/zADiEIyMbc1hZi 5iNXlRaXe7Eyf7DwNC0Zm+mQV1i0EzelrY/wVWsLQmIa+iMyHrvFAWNhpBLzpQTmHX3y X7LyUUdoJWHbnahHjz+UgQyJY1gC76At/EuKw1gy6BVhZVwQ7nMQD8yAJE27tM3uJEMa dYlrQdYZfyA9mph3n9OVKvMd/bbj/HTXIWjiBpaWeQ6OaVl/ydczJXCU8ZQsvmQDvWgn p1fA== X-Gm-Message-State: ABUngveCNYC8+T6MYZdlngelLGYWTduoowmd9l2z0ayE/1dym4vrzMbErHNlIPbTEpHeOA== X-Received: by 10.98.100.66 with SMTP id y63mr30394114pfb.49.1478670654230; Tue, 08 Nov 2016 21:50:54 -0800 (PST) Received: from google.com ([2620:0:1000:1301:1586:5d00:9edf:6894]) by smtp.gmail.com with ESMTPSA id uh10sm52256158pab.5.2016.11.08.21.50.53 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 08 Nov 2016 21:50:53 -0800 (PST) From: Kirtika Ruchandani X-Google-Original-From: Kirtika Ruchandani Date: Tue, 8 Nov 2016 21:50:48 -0800 To: Luca Coelho Cc: linux-wireless@vger.kernel.org, Arnd Bergmann , Kalle Valo , Emmanuel Grumbach , Johannes Berg , Sara Sharon , Eran Harary , Liad Kaufman , Eyal Shapira , Alexander Bondar Subject: [PATCH v2 3/3] iwlwifi: pcie: trans: Remove unused 'shift_param' Message-ID: <20161109055048.GA27520@google.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP shift_param is defined and set in iwl_pcie_load_cpu_sections but not used. Fix this to avoid -Wunused-but-set-variable warning. The code using it turned into dead code with commit dcab8ecd5617 which added a separate function iwl_pcie_load_given_ucode_8000 (then 8000b) for IWL_DEVICE_FAMILY_8000. Commit 76f8c0e17edc removed the dead code but left shift_param as is. iwlwifi/pcie/trans.c: In function ‘iwl_pcie_load_cpu_sections’: iwlwifi/pcie/trans.c:871:6: warning: variable ‘shift_param’ set but not used [-Wunused-but-set-variable] Fixes: dcab8ecd5617 (iwlwifi: mvm: support ucode load for family_8000 B0 only) Fixes: 76f8c0e17edc (iwlwifi: pcie: remove dead code) Signed-off-by: Kirtika Ruchandani Cc: Sara Sharon Cc: Luca Coelho Cc: Eran Harary Cc: Liad Kaufman Cc: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c index ae95533..1b27a39 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c @@ -868,15 +868,12 @@ static int iwl_pcie_load_cpu_sections(struct iwl_trans *trans, int cpu, int *first_ucode_section) { - int shift_param; int i, ret = 0; u32 last_read_idx = 0; if (cpu == 1) { - shift_param = 0; *first_ucode_section = 0; } else { - shift_param = 16; (*first_ucode_section)++; }