From patchwork Tue Nov 22 06:04:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kirtika Ruchandani X-Patchwork-Id: 9440515 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DA8C9600BA for ; Tue, 22 Nov 2016 06:04:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C35DA283C1 for ; Tue, 22 Nov 2016 06:04:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4DD728469; Tue, 22 Nov 2016 06:04:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 797CD283C1 for ; Tue, 22 Nov 2016 06:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbcKVGEz (ORCPT ); Tue, 22 Nov 2016 01:04:55 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35051 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbcKVGEx (ORCPT ); Tue, 22 Nov 2016 01:04:53 -0500 Received: by mail-pg0-f65.google.com with SMTP id p66so1058095pga.2; Mon, 21 Nov 2016 22:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=jhnhcPLzWX7hk3EEWFrPrl9HT1AL8cSEugYK7xYkS50=; b=lMT41fgslk8artsXOBzqTTpCBm/JuzBnykVY0TRZoCQL82IUwO+xrz10/bxbn3ToK2 FB6ZipNp6pU+gKGrhOhG0qf7QdBG0HJOySZsslFTh3ByZtgjnT45B/OzPoHjGGqK8eNY jeyhU69xv5KJSf3WOm72b8ZlIrkJ73XFfNwt/c6W7jaGtCgT/xpMGYuLEjgWuBXDdh7l o5GXoajAuMj8lfc3Tv+hNxJHE9+mw3N5HZ/YqrB2o86bJ2mXO3LgoK2iBLQCrxNX9oRH IvVYxZooXimGHXOqzwF9KZ+foRxlsGnhU+Qlc4SOhKepsGRB+feU+smV4Qztti2ED5/F eF3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=jhnhcPLzWX7hk3EEWFrPrl9HT1AL8cSEugYK7xYkS50=; b=E9bFk/oP9gzWjc//3fDkh1B0igGXeedmKfzC6aDVMNtNXwkHzbCJTTMyLfw0O4UOaE MNAO2K/iH7VWa0nhiagqf8Zw/OZ5o7siEIQ3+gnwfm1lQLnQ5pbbfYJ97n/p0crCuHf3 VSJtPzJtgMrwJB/Y+gtdZoaEombVMCozoLaA1fp2bkl9Z9/yLA0/5wqe+2/a4vgbMi/4 TfFhROl0WWIBOBbIZixChE/8u6ZPJaK+ReKQORwDkRudDDldkx4oCsyjzhGDy6QwwlC+ VI9VaKWm3hgdj8R0KgiemD2YviwLrZFfj6/OpUBi96TvtAUGxm/cCn5aLb3HXUeClLGy zV1Q== X-Gm-Message-State: AKaTC035BBhCAHSls4lUbQwbl7D10BSZS2Ev3AZcufgH05Xb+gnjknT3f/sApbh1stTVoA== X-Received: by 10.98.105.68 with SMTP id e65mr23516590pfc.10.1479794692511; Mon, 21 Nov 2016 22:04:52 -0800 (PST) Received: from google.com ([2620:0:1000:1301:6c91:e255:ba2e:d0aa]) by smtp.gmail.com with ESMTPSA id y189sm41681793pfy.32.2016.11.21.22.04.50 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 21 Nov 2016 22:04:51 -0800 (PST) From: Kirtika Ruchandani X-Google-Original-From: Kirtika Ruchandani Date: Mon, 21 Nov 2016 22:04:46 -0800 To: Johannes Berg Cc: Arnd Bergmann , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Felix Fietkau , Johannes Berg Subject: [PATCH] mac80211: Remove unused 'rates_idx' variable Message-ID: <20161122060446.GA26548@google.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit f027c2aca0cf introduced 'rates_idx' in ieee80211_tx_status_noskb but did not use it. Compiling with W=1 gives the following warning, fix it. mac80211/status.c: In function ‘ieee80211_tx_status_noskb’: mac80211/status.c:636:6: warning: variable ‘rates_idx’ set but not used [-Wunused-but-set-variable] This is a harmless warning, and is only being fixed to reduce the noise generated with W=1. Fixes: f027c2aca0cf ("mac80211: add ieee80211_tx_status_noskb") Cc: Johannes Berg Cc: Felix Fietkau Signed-off-by: Kirtika Ruchandani --- net/mac80211/status.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.8.0.rc3.226.g39d4020 diff --git a/net/mac80211/status.c b/net/mac80211/status.c index ddf71c6..f7c5ae5 100644 --- a/net/mac80211/status.c +++ b/net/mac80211/status.c @@ -633,10 +633,9 @@ void ieee80211_tx_status_noskb(struct ieee80211_hw *hw, struct ieee80211_local *local = hw_to_local(hw); struct ieee80211_supported_band *sband; int retry_count; - int rates_idx; bool acked, noack_success; - rates_idx = ieee80211_tx_get_rates(hw, info, &retry_count); + ieee80211_tx_get_rates(hw, info, &retry_count); sband = hw->wiphy->bands[info->band];