From patchwork Thu Nov 24 06:40:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kirtika Ruchandani X-Patchwork-Id: 9444901 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3D7C360778 for ; Thu, 24 Nov 2016 06:41:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 338E426E16 for ; Thu, 24 Nov 2016 06:41:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 27D8526E82; Thu, 24 Nov 2016 06:41:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2006B26E16 for ; Thu, 24 Nov 2016 06:41:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754649AbcKXGkw (ORCPT ); Thu, 24 Nov 2016 01:40:52 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35337 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbcKXGkv (ORCPT ); Thu, 24 Nov 2016 01:40:51 -0500 Received: by mail-pf0-f195.google.com with SMTP id i88so1507685pfk.2; Wed, 23 Nov 2016 22:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=AZXQCNyEMoyU4ON0qsPs1fK5EuZedcRgd/VJ4eLXa2Y=; b=vfODgzZCl9Ba3hoNxRXJKTIRQTUQMwKGqbj1zBamXfl1+drLGokWp3jx94u1Sr4SBk huOhztbQqpYRwEzFfPMhZweSGBxIjlh5VIeRq+eXO0tynLXg44W4jgMErPNMgVRbudZ8 T//UiCzuarBl13PPaeykA5Kg1hmf4aORBnx6tDpleopFpMN0UGu1Etaq+OsJPbncCSR3 Na+jvOrt+xAjl0udI+ZYIkQDcFPhf9mk3zEqlCWGRENjT8EM3bz/VwjC/9De0e36LSYm CaXITh2K+kQcY8QgdE58SsdLSofvzNXzbfB2czYTr2O9CSRpuvpFZMMITkHfmAWVN0aj ojDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=AZXQCNyEMoyU4ON0qsPs1fK5EuZedcRgd/VJ4eLXa2Y=; b=i/Cu/FkDajW9VOjEw2UgsmR43wuk03ATH/IfjlUhElPL2x7duyT63RHrS7IFbIqAWN PgKEpOGigAO963QRwCj4gbk55Y9ZiWiWbd5zK+gFBsirrVDLglnlSzXbcpMxylfVoARW 6HgKGRti9+eQMu6pE+CxCuZyj0f2TQHYEtRAqyBOERQ3/PdNiZWTOFmtjZ3J6VDfyQ// aX6qbQapz5VPMSASZoecJe89HKgRt4aYb3oiTFY7+2UmCyEEHNnIo/9olzfyiLZheKio uHRAoGsjzLbm/Ly75p1CRAWnElx8mxxYyaSfk2vdfp0yXbiqW7QpsC/IrXb9etVHVjcp rAGQ== X-Gm-Message-State: AKaTC031xCJC1k0OaA4+EzajdRh7fB/zFsUDRYrBnvQlA2f1POXREdiSEn/c7kbeB8m54Q== X-Received: by 10.84.218.14 with SMTP id q14mr1924638pli.53.1479969650757; Wed, 23 Nov 2016 22:40:50 -0800 (PST) Received: from google.com ([2620:0:1000:1301:e80d:edf6:fd55:23d6]) by smtp.gmail.com with ESMTPSA id y20sm57228465pfj.26.2016.11.23.22.40.49 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 23 Nov 2016 22:40:49 -0800 (PST) From: Kirtika Ruchandani X-Google-Original-From: Kirtika Ruchandani Date: Wed, 23 Nov 2016 22:40:45 -0800 To: Kalle Valo Cc: Arnd Bergmann , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] adm80211: Removed unused 'io_addr' 'mem_addr' variables Message-ID: <20161124064045.GA8836@google.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initial commit cc0b88cf5ecf ([PATCH] Add adm8211 802.11b wireless driver) introduced variables mem_addr and io_addr in adm80211_probe() that are set but not used. Compiling with W=1 gives the following warnings, fix them. drivers/net/wireless/admtek/adm8211.c: In function ‘adm8211_probe’: drivers/net/wireless/admtek/adm8211.c:1769:15: warning: variable ‘io_addr’ set but not used [-Wunused-but-set-variable] unsigned int io_addr, io_len; ^ drivers/net/wireless/admtek/adm8211.c:1768:16: warning: variable ‘mem_addr’ set but not used [-Wunused-but-set-variable] unsigned long mem_addr, mem_len; ^ These are harmless warnings and are only being fixed to reduce the noise with W=1 in the kernel. The calls to pci_resource_start do not have any side-effects and are safe to remove. Fixes: cc0b88cf5ecf ("[PATCH] Add adm8211 802.11b wireless driver") Cc: Michael Wu Cc: John W. Linville Signed-off-by: Kirtika Ruchandani --- drivers/net/wireless/admtek/adm8211.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.8.0.rc3.226.g39d4020 diff --git a/drivers/net/wireless/admtek/adm8211.c b/drivers/net/wireless/admtek/adm8211.c index 70ecd82..70b4da0 100644 --- a/drivers/net/wireless/admtek/adm8211.c +++ b/drivers/net/wireless/admtek/adm8211.c @@ -1765,8 +1765,8 @@ static int adm8211_probe(struct pci_dev *pdev, { struct ieee80211_hw *dev; struct adm8211_priv *priv; - unsigned long mem_addr, mem_len; - unsigned int io_addr, io_len; + unsigned long mem_len; + unsigned int io_len; int err; u32 reg; u8 perm_addr[ETH_ALEN]; @@ -1778,9 +1778,7 @@ static int adm8211_probe(struct pci_dev *pdev, return err; } - io_addr = pci_resource_start(pdev, 0); io_len = pci_resource_len(pdev, 0); - mem_addr = pci_resource_start(pdev, 1); mem_len = pci_resource_len(pdev, 1); if (io_len < 256 || mem_len < 1024) { printk(KERN_ERR "%s (adm8211): Too short PCI resources\n",