From patchwork Wed Dec 21 17:18:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 9483579 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E32A8600C6 for ; Wed, 21 Dec 2016 17:20:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4D742811C for ; Wed, 21 Dec 2016 17:20:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C9B412841B; Wed, 21 Dec 2016 17:20:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID,URIBL_BLACK autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 823992811C for ; Wed, 21 Dec 2016 17:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759379AbcLURT5 (ORCPT ); Wed, 21 Dec 2016 12:19:57 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36627 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755928AbcLURTx (ORCPT ); Wed, 21 Dec 2016 12:19:53 -0500 Received: by mail-oi0-f67.google.com with SMTP id u15so29117625oie.3; Wed, 21 Dec 2016 09:18:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=fDUlrl0mmowGbxRKCWatrdN1zB+1ULlZR2lY1ebGSZQ=; b=HP/sOp9oWEgFaK5MM6P6VEx2m/Z7umdYbvcVi22qJMh/nOiYGobQBqm8yRrRnSi7px PVwCtclje6Ta3dhjr7OrqkZ62D2AkRIIddoEFPsyWkjjBkAV2zvio0Mm5Wx2bvBq6fqn R9U9QvMDpria2zYfXcw0VtpzZqeaIE4vtWn3VZ6diJUtQeSgkynEQ6KlHjoJiT3Urvr7 HK+ThgwPjnyFITkFcLR+Pwwqli+SBBtm3TCd0GtHa5ggEoeXsoZq43GbLQ8OHR6SJ23W XHjePGK+trk+m0LnrR80+kBRR+FNAy3oihJnOlx94/+qyZPPTWgOfF3WGeuNCDZRXa6k TcHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=fDUlrl0mmowGbxRKCWatrdN1zB+1ULlZR2lY1ebGSZQ=; b=XxAeQ9hPyU8hl37X26N+RH99X/K/mpkFhSdOpfADscCw4hWVuwJqu7NggN3zeXCSuQ cmZCnL2BUo7uqg25s7z+1eJ5KnT8n5JLezTEj2WKHrfzA9eGeZkDd/dA/echEPdPXv2w frWV4qtLUSbJSSG4UdksJYBCGpa9LAfF4c38YBXiEB0OA/A7Qowl/kSjxX9sB131qpfX GPFGpWbEuehdKItz7/sGoTeinlZ+m6JmwhDXoT4VN4cS5BhJX/NMgyntiv79Ajj0pUfH PGJJ+m15lzxGCZmRL5ikX3T99+giLrIzTbT3CW8VFysuNSS62WfzC4Mc8ai6S6StZtGi rxNw== X-Gm-Message-State: AIkVDXKAcEw4L8KgDcqGJE9QpSjSF/IicVSpNCJpN2y2SQDVEuY/vyC7dIbv+IIdNeWYbQ== X-Received: by 10.157.26.24 with SMTP id a24mr3295086ote.107.1482340739426; Wed, 21 Dec 2016 09:18:59 -0800 (PST) Received: from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id 66sm12214982oid.29.2016.12.21.09.18.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Dec 2016 09:18:58 -0800 (PST) From: Larry Finger To: kvalo@codeaurora.org, Linus Torvalds Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Larry Finger , linux-kernel@vger.kernel.org, driver-devel@vger.kernel.org Subject: [PATCH] rtlwifi: rtl_usb: Fix missing entry in USB driver's private data Date: Wed, 21 Dec 2016 11:18:55 -0600 Message-Id: <20161221171855.5056-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.10.2 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These drivers need to be able to reference "struct ieee80211_hw" from the driver's private data, and vice versa. The USB driver failed to store the address of ieee80211_hw in the private data. Although this bug has been present for a long time, it was not exposed until commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save"). Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save") Signed-off-by: Larry Finger --- Kalle, This patch needs to be included in 4.10. Larry --- drivers/net/wireless/realtek/rtlwifi/usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c index 40160c7..bf00399 100644 --- a/drivers/net/wireless/realtek/rtlwifi/usb.c +++ b/drivers/net/wireless/realtek/rtlwifi/usb.c @@ -1047,6 +1047,7 @@ int rtl_usb_probe(struct usb_interface *intf, return -ENOMEM; } rtlpriv = hw->priv; + rtlpriv->hw = hw; rtlpriv->usb_data = kzalloc(RTL_USB_MAX_RX_COUNT * sizeof(u32), GFP_KERNEL); if (!rtlpriv->usb_data)