From patchwork Tue Jan 10 09:55:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Vincent_Stehl=C3=A9?= X-Patchwork-Id: 9506837 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2F586601E9 for ; Tue, 10 Jan 2017 09:55:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 242CB27FB1 for ; Tue, 10 Jan 2017 09:55:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 174AB2844A; Tue, 10 Jan 2017 09:55:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 197F527FB1 for ; Tue, 10 Jan 2017 09:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765334AbdAJJzf (ORCPT ); Tue, 10 Jan 2017 04:55:35 -0500 Received: from smtpoutz26.laposte.net ([194.117.213.101]:47807 "EHLO smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1765331AbdAJJze (ORCPT ); Tue, 10 Jan 2017 04:55:34 -0500 Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout014 (Postfix) with ESMTP id D1760121273 for ; Tue, 10 Jan 2017 10:55:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=mail0; t=1484042131; bh=sXXC+uNCq7JQsYBqTiVo7T924XkmlhPjTLcmZ2nvzP0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=O/VS57WknvgBsa5Gq6ycJH8bWfDXE3DvhPv+rmGBjnZRHuU2zCETk2FIzww2oFUp+ bz41eNNitt5uLun9/dGJVGyxjx8OS9xu4BRtLCSs4xMwqJ1M2H2HMYmEcnZD+2BvPU eenuQTRMAbTLVItAKHRMoeJf5Uc1iKAttDWJ+E/7Eg3jeWIfYnrLm054jAvPbSjFua 1UfgcH8oQLPFXv5iyF8r6XQauYFiBPqASsrT/iNAFMu3sALvii8FRnRzRNNlXitdWY 2hyvEueU55qI5A+pcgrlL9++753P1n8DWRBdCd6w1CkPwGBlDVqAp2y4oGPKS5oKdD g5YfruiTBpSpg== Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout014 (Postfix) with ESMTP id C3B13121373 for ; Tue, 10 Jan 2017 10:55:31 +0100 (CET) Received: from lpn-prd-vrin002 (lpn-prd-vrin002.prosodie [10.128.63.3]) by lpn-prd-vrout014 (Postfix) with ESMTP id BF1C8121273 for ; Tue, 10 Jan 2017 10:55:31 +0100 (CET) Received: from lpn-prd-vrin002 (localhost [127.0.0.1]) by lpn-prd-vrin002 (Postfix) with ESMTP id AADF35BF602 for ; Tue, 10 Jan 2017 10:55:31 +0100 (CET) Received: from romuald.bergerie (rqp06-1-88-178-86-202.fbx.proxad.net [88.178.86.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lpn-prd-vrin002 (Postfix) with ESMTPSA id 8D2E95BF5F8; Tue, 10 Jan 2017 10:55:30 +0100 (CET) Received: from radicelle.bergerie (radicelle.bergerie [192.168.124.12]) by romuald.bergerie (Postfix) with ESMTPS id F0E0E19876AD; Tue, 10 Jan 2017 10:55:29 +0100 (CET) Received: from vincent by radicelle.bergerie with local (Exim 4.88) (envelope-from ) id 1cQt9N-00019t-RQ; Tue, 10 Jan 2017 10:55:29 +0100 From: =?UTF-8?q?Vincent=20Stehl=C3=A9?= To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: =?UTF-8?q?Vincent=20Stehl=C3=A9?= , Larry Finger , Kalle Valo , Joe Perches , Ping-Ke Shih Subject: [PATCH next] rtlwifi: rtl8192de: fix missing curly braces Date: Tue, 10 Jan 2017 10:55:21 +0100 Message-Id: <20170110095521.4410-1-vincent.stehle@laposte.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20161215182310.13713-15-Larry.Finger@lwfinger.net> References: <20161215182310.13713-15-Larry.Finger@lwfinger.net> MIME-Version: 1.0 X-VR-SrcIP: 88.178.86.202 X-VR-FullState: 0 X-VR-Score: -100 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeelgedrvdeigddutdcutefuodetggdotefrodftvfcurfhrohhf X-VR-Cause-2: ihhlvgemucfntefrqffuvffgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhs X-VR-Cause-3: ucdlqddutddtmdenucfjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpegg X-VR-Cause-4: ihhntggvnhhtucfuthgvhhhlrocuoehvihhntggvnhhtrdhsthgvhhhlvgeslhgrphhoshhtvgdrnhgv X-VR-Cause-5: theqnecukfhppeekkedrudejkedrkeeirddvtddvnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhht X-VR-Cause-6: pdhhvghloheprhhomhhurghlugdrsggvrhhgvghrihgvpdhinhgvthepkeekrddujeekrdekiedrvddt X-VR-Cause-7: vddpmhgrihhlfhhrohhmpehvihhntggvnhhtrdhsthgvhhhlvgeslhgrphhoshhtvgdrnhgvthdprhgt X-VR-Cause-8: phhtthhopehlihhnuhigqdifihhrvghlvghsshesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-VR-AvState: No X-VR-State: 0 X-VR-State: 0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Restore some curly braces that have been removed in commit c93ac39da006457f ("rtlwifi: Remove some redundant code") while removing redundant messages and extraneous braces. This fixes the following smatch warning: drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c:326 rtl92d_download_fw() warn: curly braces intended? ...and the following coccinelle warning: drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c:325:2-38: code aligned with following code on line 326 Fixes: c93ac39da006457f ("rtlwifi: Remove some redundant code") Signed-off-by: Vincent Stehlé Cc: Larry Finger Cc: Kalle Valo Cc: Joe Perches Cc: Ping-Ke Shih --- Hi, I saw that in Linux next-20170110. Best regards, Vincent. drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c index aa1e51c871df..bcde4da4e593 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c @@ -321,9 +321,10 @@ int rtl92d_download_fw(struct ieee80211_hw *hw) value &= (~BIT(5)); rtl_write_byte(rtlpriv, 0x1f, value); spin_unlock_irqrestore(&globalmutex_for_fwdownload, flags); - if (err) + if (err) { pr_err("fw is not ready to run!\n"); goto exit; + } exit: err = _rtl92d_fw_init(hw); return err;