From patchwork Sat Jan 14 02:16:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 9516687 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A672A607D4 for ; Sat, 14 Jan 2017 02:17:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8937C286F0 for ; Sat, 14 Jan 2017 02:17:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B54728749; Sat, 14 Jan 2017 02:17:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D45F8286F0 for ; Sat, 14 Jan 2017 02:17:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751180AbdANCRL (ORCPT ); Fri, 13 Jan 2017 21:17:11 -0500 Received: from mail-io0-f174.google.com ([209.85.223.174]:35607 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbdANCRK (ORCPT ); Fri, 13 Jan 2017 21:17:10 -0500 Received: by mail-io0-f174.google.com with SMTP id j18so57305788ioe.2 for ; Fri, 13 Jan 2017 18:17:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=Q03pfiJOwjSxTvYy4FCwUnKfOTWaTbYE8HThqoeKQkk=; b=OsZXCSjBaV2SJJm5xuCAFAOxvhyzg2gG7xY7gXfi/hPKupuETrWpl9AmJyI1Q5QH+A vXwOKobA/OWyVPBqgeL6BR8EFLs3CCnELVFuBafxqq3XUnzoyFR87/VEvKaXbjmzkOpx CZeGtxGS1y8tt3bcBlMGo6GCE3kRCIFsFfrwM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Q03pfiJOwjSxTvYy4FCwUnKfOTWaTbYE8HThqoeKQkk=; b=bF8R6fwLCjZ5TXW8kVbB0krsTdBhOsQKm9bMIwpni8Bt3G6L2WQNJEP2vk0G/iaqvp UKimYdIX3VMGhHTBtRmlt9bZQ86wAmrJUKfk/BSw0H31Uv7YW9Um2a+0h6MncXt/cWpJ 6q/WyUctBaakVImYAj5n/mhyuUKlPacarIFp+Q3zj2YLdTtNWgLwESVA4haYZOpGevsP 5fqaME96dYe0Ng9ICqMJmHAazjehpoaMN5TUvl/c4H4TPHMtbzU/hO6DT+x4z+vLKKg3 /G0JJnbsfVTNhES7NRSF5kCVe2nUgVBkNS16ooIbWTcxjChJ56u9UDw55ru51Z8EtjHd 7HJw== X-Gm-Message-State: AIkVDXJU53/7Bs9D1tgx2+OCzQdUrsAmRLgTAkb/3K/m6zMPY1bjx3ZVXC2yKh1s3UpDGxNB X-Received: by 10.107.198.195 with SMTP id w186mr21961137iof.19.1484360229621; Fri, 13 Jan 2017 18:17:09 -0800 (PST) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id l3sm7679602iof.33.2017.01.13.18.17.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Jan 2017 18:17:09 -0800 (PST) From: Brian Norris To: Amitkumar Karwar , Nishant Sarmukadam Cc: , Kalle Valo , linux-wireless@vger.kernel.org, Cathy Luo , Brian Norris Subject: [PATCH] mwifiex: don't complain about 'unknown event id: 0x63' Date: Fri, 13 Jan 2017 18:16:57 -0800 Message-Id: <20170114021657.147016-1-briannorris@chromium.org> X-Mailer: git-send-email 2.11.0.483.g087da7b7c-goog Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Marvell folks tell me this is a debugging event that the driver doesn't need to handle, but on 8997 w/ firmware 16.68.1.p97, I see several of these sorts of messages at (for instance) boot time: [ 13.825848] mwifiex_pcie 0000:01:00.0: event: unknown event id: 0x63 [ 14.838561] mwifiex_pcie 0000:01:00.0: event: unknown event id: 0x63 [ 14.850397] mwifiex_pcie 0000:01:00.0: event: unknown event id: 0x63 [ 32.529923] mwifiex_pcie 0000:01:00.0: event: unknown event id: 0x63 Let's handle this "event" with a much lower verbosity. Signed-off-by: Brian Norris --- drivers/net/wireless/marvell/mwifiex/fw.h | 1 + drivers/net/wireless/marvell/mwifiex/sta_event.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wireless/marvell/mwifiex/fw.h index 55db158fd156..cb6a1a81d44e 100644 --- a/drivers/net/wireless/marvell/mwifiex/fw.h +++ b/drivers/net/wireless/marvell/mwifiex/fw.h @@ -550,6 +550,7 @@ enum mwifiex_channel_flags { #define EVENT_TX_DATA_PAUSE 0x00000055 #define EVENT_EXT_SCAN_REPORT 0x00000058 #define EVENT_RXBA_SYNC 0x00000059 +#define EVENT_UNKNOWN_DEBUG 0x00000063 #define EVENT_BG_SCAN_STOPPED 0x00000065 #define EVENT_REMAIN_ON_CHAN_EXPIRED 0x0000005f #define EVENT_MULTI_CHAN_INFO 0x0000006a diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c b/drivers/net/wireless/marvell/mwifiex/sta_event.c index 9df0c4dc06ed..96503d3d053f 100644 --- a/drivers/net/wireless/marvell/mwifiex/sta_event.c +++ b/drivers/net/wireless/marvell/mwifiex/sta_event.c @@ -1009,6 +1009,10 @@ int mwifiex_process_sta_event(struct mwifiex_private *priv) adapter->event_skb->len - sizeof(eventcause)); break; + /* Debugging event; not used, but let's not print an ERROR for it. */ + case EVENT_UNKNOWN_DEBUG: + mwifiex_dbg(adapter, EVENT, "event: debug\n"); + break; default: mwifiex_dbg(adapter, ERROR, "event: unknown event id: %#x\n", eventcause);