From patchwork Thu Jan 19 20:28:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 9526745 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 82EDD60459 for ; Thu, 19 Jan 2017 20:35:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7482228534 for ; Thu, 19 Jan 2017 20:35:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 679B928629; Thu, 19 Jan 2017 20:35:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D733128534 for ; Thu, 19 Jan 2017 20:35:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754357AbdASUfL (ORCPT ); Thu, 19 Jan 2017 15:35:11 -0500 Received: from mail-ot0-f193.google.com ([74.125.82.193]:34184 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753542AbdASUfK (ORCPT ); Thu, 19 Jan 2017 15:35:10 -0500 Received: by mail-ot0-f193.google.com with SMTP id 73so5493289otj.1 for ; Thu, 19 Jan 2017 12:34:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=eYzeUUdHEkA12BzHnavAv3WfI2CIa10cyS5/Wup8c3M=; b=k6yptBZN9MlmBgoYFQGMPfU33eJa5efJh18CB3RB3YCW9HzBKLHtu/mwCVdpEa6jtI aPc8BGZpDJ/wEbbO0Om4Wgu59IrvODmO2dMo3QNUvsIxXYv+XyIRl+RCrgR27OsJguiB MnZwhkbCdQfsHTZN3s8H7ittG/bMUbkJMzXSf27OMJCAiAdKJ7kAhIDpQLkg7QiR8vSR eehvihE8dZHyhhGE61zDF/6VEL/drA987sO/19WtVZt0vEnDkaLz8oHqrbTOH8LHgubL WM/YTYeia0TtkXQzVKn6/d0fk3z32sgqD+9DYJcm5elKcKbqtmbxZSXaBAAs39QXt0oK /y/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=eYzeUUdHEkA12BzHnavAv3WfI2CIa10cyS5/Wup8c3M=; b=TAbgLzWTCiCC18WXMgJHNhVtBfTt/6J7SAJyxyGGMMJ0NPWalVXuJ32nsz0bx3JIwS VYsiFcqZSVyzt+MesjeRBrYeXujeQ6WytsNNKh9fna0oV5P0GczmxZOjbp+bdutLt8zv ZyfNLbQlr9neeLlemC1Qe5YxjldfkLnSATg11Wbmr2/i2v0xby0ZNNLeNbPCy2+Kq/Yw vaEYN1kdqolFzrrkw56SraRyDRvh4gUFegjX9VNe/1SjNGOWWMZUUivgNV9oX1yve/QF ulrWjMpr0PMaYm4/J1azHjBsVNE/1yUPINhbUX0EGxDMqzKr0n8ag0er9c4M5GYuSIsS ChBA== X-Gm-Message-State: AIkVDXIcDYbcEboe9J0rFfwakUx31cesa0L4BPRX5qB/Y64JlO9HViusHVrhS8fk4/hULg== X-Received: by 10.157.24.40 with SMTP id b37mr5981577ote.245.1484857696469; Thu, 19 Jan 2017 12:28:16 -0800 (PST) Received: from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id z19sm2498156otc.29.2017.01.19.12.28.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Jan 2017 12:28:16 -0800 (PST) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH v2 2/3] rtlwifi: rtl8192cu: Calculate descriptor checksum correctly for BE Date: Thu, 19 Jan 2017 14:28:07 -0600 Message-Id: <20170119202808.27752-3-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20170119202808.27752-1-Larry.Finger@lwfinger.net> References: <20170119202808.27752-1-Larry.Finger@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This driver requires a checksum for the descriptors so that the wifi chip is assured that the USB transmission was correct. These entries are little-endian, but the driver was always using cpu order in the calculation. As a result, the driver failed on BE hardware. Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- V2 - No functional changes. Merge conflict resolved. --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c index 6da6e2a..1611e42 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c @@ -477,14 +477,14 @@ static void _rtl_fill_usb_tx_desc(u8 *txdesc) */ static void _rtl_tx_desc_checksum(u8 *txdesc) { - u16 *ptr = (u16 *)txdesc; + __le16 *ptr = (__le16 *)txdesc; u16 checksum = 0; u32 index; /* Clear first */ SET_TX_DESC_TX_DESC_CHECKSUM(txdesc, 0); for (index = 0; index < 16; index++) - checksum = checksum ^ (*(ptr + index)); + checksum = checksum ^ le16_to_cpu(*(ptr + index)); SET_TX_DESC_TX_DESC_CHECKSUM(txdesc, checksum); }