From patchwork Mon Jan 30 15:09:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 9545581 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 39AEA604A8 for ; Mon, 30 Jan 2017 15:10:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C37920243 for ; Mon, 30 Jan 2017 15:10:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2116128159; Mon, 30 Jan 2017 15:10:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1999820243 for ; Mon, 30 Jan 2017 15:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932165AbdA3PKQ (ORCPT ); Mon, 30 Jan 2017 10:10:16 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:35222 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932113AbdA3PKN (ORCPT ); Mon, 30 Jan 2017 10:10:13 -0500 Received: by mail-lf0-f68.google.com with SMTP id v186so31623252lfa.2 for ; Mon, 30 Jan 2017 07:10:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9EBEUmDXbMWx00vZK9hRy1iPlZoIiMh+fkb315j5aL8=; b=aQLwyPbrap56d6OQ5UgznQcRlwA+WNbBXnsXb8Auca+g/GIQHIrvnVmvAgUYgY3mw9 H9Azn3MzS2mOSy3/eQvF++4FEXw7LmIBqACFmObDxYCRecX7L5AIWyY2/vClAkM10Uxv d88BKyxUkdwlqd3mXv+/2kxA3Gd63ovYV+fGBe73o9KDbeKGZC/ZsKJmiUw5wHyJhoA1 SOBdNmmTLJHpAVwAcGFRq2VP0v+J04gpLt34XUYSiZOuNQ6I/grgpWuAVx377OnDbA3t J6jg+zyiMPtdzyxJq3lrOu2S5g+iBFZdQh3m7ANrjxQI4rcADxH4j1uzyjvqHTaTywK/ uhRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9EBEUmDXbMWx00vZK9hRy1iPlZoIiMh+fkb315j5aL8=; b=sUuKHX0wIE8wKkMdTcYudH7c61mRcJEx5doUMzbdqJCsYek+L4NceSHMETgmLIjafy tQXJqmEgjNKIWg7XxT+I9AsTzlneP1NRFReSEa9xQMC3hhn1uNHTKUz1F48kRBAlhcUI dBA5TNt9eIcGoMv9QFTubJ+ajXR4jk+h0lTQgbp0gKYiGUiYnNAqmLb9yi9KFkmN/07T r1utECHJfhOerm/1jyGUFtyOY2yPH12l7ZFzj4Soda/dHKEqrAaGDC+tqeq/b5zMyxAC ipW4p+PplRyQ0/bYM+27PRzj7ajHrmvescY84ktORV4zdA+jzQLAr1QwCobF/mF7zpA5 Pgdw== X-Gm-Message-State: AIkVDXLeTOjop6mbOwHdSlvXmpgb6/DYyITQOo3KLYenH2anvG21mdqhte3qJwAHQJYdKQ== X-Received: by 10.46.15.1 with SMTP id 1mr3677180ljp.52.1485789004474; Mon, 30 Jan 2017 07:10:04 -0800 (PST) Received: from linux-samsung.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id t126sm3786011lff.31.2017.01.30.07.10.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 07:10:03 -0800 (PST) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Kalle Valo Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , Franky Lin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH 2/2] brcmfmac: be more verbose when PSM's watchdog fires Date: Mon, 30 Jan 2017 16:09:52 +0100 Message-Id: <20170130150952.7133-2-zajec5@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170130150952.7133-1-zajec5@gmail.com> References: <20170130150952.7133-1-zajec5@gmail.com> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rafał Miłecki It's important to inform user so he knows things went wrong. He may also want to get memory dump for further debugging purposes. Signed-off-by: Rafał Miłecki Acked-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c index 6f8a4b074c31..f4644cf371c7 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c @@ -58,10 +58,18 @@ static int brcmf_debug_psm_watchdog_notify(struct brcmf_if *ifp, const struct brcmf_event_msg *evtmsg, void *data) { + int err; + brcmf_dbg(TRACE, "enter: bsscfgidx=%d\n", ifp->bsscfgidx); - return brcmf_debug_create_memdump(ifp->drvr->bus_if, data, - evtmsg->datalen); + brcmf_err("PSM's watchdog has fired!\n"); + + err = brcmf_debug_create_memdump(ifp->drvr->bus_if, data, + evtmsg->datalen); + if (err) + brcmf_err("Failed to get memory dump, %d\n", err); + + return err; } void brcmf_debugfs_init(void)