From patchwork Tue Mar 21 14:24:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 9636661 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1D2B260327 for ; Tue, 21 Mar 2017 14:25:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 120B42830A for ; Tue, 21 Mar 2017 14:25:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06E082833B; Tue, 21 Mar 2017 14:25:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4572C28329 for ; Tue, 21 Mar 2017 14:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932773AbdCUOZS (ORCPT ); Tue, 21 Mar 2017 10:25:18 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:34523 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932685AbdCUOZQ (ORCPT ); Tue, 21 Mar 2017 10:25:16 -0400 Received: by mail-oi0-f65.google.com with SMTP id w81so6344704oig.1 for ; Tue, 21 Mar 2017 07:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=89kV8xBD1SoMyq+4HFW9rmND8E4beMN1jXPWYk2BqrE=; b=i6vhgctj966+Fe8vYLlk3ruP4zlxnKZ3P+wd+0t/NkL3t7VMMKqL85JSRE/UNdDILh B5QFfcw08pT53dOkEZAM9H6pzNGbxOKb673DGbHXu+mRZUYUgIhUOEIyVG+CN/GEe+KR tBhMUULTIanasr1EPyNrVJQM2lGuVwswhj4EAFmFYwt6EqVVdmoBLmWqF+o9wLwfo1Qj YcRJlDkG8jW6vDzaFXuaR5JmKKEP8PU0J4pk40+Di/6RGs+/B6uX2mREBr5phQQZuNUQ 3HX5z9Wk4TxAJd82DVgV1u5EvgQSq+6vET1bKslELR/3adV5Rs0/MyR278r8y7Twe5rM uZ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=89kV8xBD1SoMyq+4HFW9rmND8E4beMN1jXPWYk2BqrE=; b=SzUKCG32qT6UWsZblSNHSMy5oSuR5hKp9FfY+RD6PI+ckdWQrM+Xgy0pO92X8fz7F1 I8XZQ+YpuOkP+yVHA8dRjxQFqoNdVIowRV6W6geAGpYKkgo2+ec4RemT7qI+1yBPcQ9S ePQBja/ZMh0uU6GY7YVFsP3mHcYRpvzB8iOu6SDMzC5Md2bbG/kXHPN7SLHfycCZeJbI 732NU7lp1qBlxoHa30DPB6zkQd+blMzXZuOYSdiuJe73CyD/nxRzl1kD7pcTrgtuMMSm 9t8Qe2NkMBpGrgc2yB9mBaZKyysG6/tRTl7iBHDP/VyCJWuXWlATJdCUkT3BC2NRYAqM uIIA== X-Gm-Message-State: AFeK/H3gFHnVKE4nt0CveEhgZ0DRtfcq8JOKn8TbrTN7j6gKakybiDyS14DZkjbtTvW7Ng== X-Received: by 10.202.194.197 with SMTP id s188mr5387298oif.108.1490106258467; Tue, 21 Mar 2017 07:24:18 -0700 (PDT) Received: from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id j66sm3961182oih.38.2017.03.21.07.24.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 21 Mar 2017 07:24:17 -0700 (PDT) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH] rtlwifi: Fix scheduling while atomic splat Date: Tue, 21 Mar 2017 09:24:11 -0500 Message-Id: <20170321142411.24044-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.10.2 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Following commit cceb0a597320 ("rtlwifi: Add work queue for c2h cmd."), the following BUG is reported when rtl8723be is used: BUG: sleeping function called from invalid context at mm/slab.h:432 in_atomic(): 1, irqs_disabled(): 1, pid: 0, name: swapper/0 CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W O 4.11.0-rc3-wl+ #276 Hardware name: TOSHIBA TECRA A50-A/TECRA A50-A, BIOS Version 4.50 09/29/2014 Call Trace: dump_stack+0x63/0x89 ___might_sleep+0xe9/0x130 __might_sleep+0x4a/0x90 kmem_cache_alloc_trace+0x19f/0x200 ? rtl_c2hcmd_enqueue+0x3e/0x110 [rtlwifi] rtl_c2hcmd_enqueue+0x3e/0x110 [rtlwifi] rtl8723be_c2h_packet_handler+0xac/0xc0 [rtl8723be] rtl8723be_rx_command_packet+0x37/0x5c [rtl8723be] _rtl_pci_rx_interrupt+0x200/0x6b0 [rtl_pci] _rtl_pci_interrupt+0x20c/0x5d0 [rtl_pci] __handle_irq_event_percpu+0x3f/0x1d0 handle_irq_event_percpu+0x23/0x60 handle_irq_event+0x3c/0x60 handle_fasteoi_irq+0xa2/0x170 handle_irq+0x20/0x30 do_IRQ+0x48/0xd0 common_interrupt+0x89/0x89 ... Although commit cceb0a597320 converted most c2h commands to use a work queue, the Bluetooth coexistence routines can be in atomic mode when they execute such a call. Fixes: cceb0a597320 ("rtlwifi: Add work queue for c2h cmd.") Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- Kalle, This patch should be applied to kernel 4.11. Thanks, Larry --- drivers/net/wireless/realtek/rtlwifi/base.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c index 07b4091..c55be12 100644 --- a/drivers/net/wireless/realtek/rtlwifi/base.c +++ b/drivers/net/wireless/realtek/rtlwifi/base.c @@ -1755,12 +1755,14 @@ void rtl_c2hcmd_enqueue(struct ieee80211_hw *hw, u8 tag, u8 len, u8 *val) unsigned long flags; struct rtl_c2hcmd *c2hcmd; - c2hcmd = kmalloc(sizeof(*c2hcmd), GFP_KERNEL); + c2hcmd = kmalloc(sizeof(*c2hcmd), + in_interrupt() ? GFP_ATOMIC : GFP_KERNEL); if (!c2hcmd) goto label_err; - c2hcmd->val = kmalloc(len, GFP_KERNEL); + c2hcmd->val = kmalloc(len, + in_interrupt() ? GFP_ATOMIC : GFP_KERNEL); if (!c2hcmd->val) goto label_err2;