From patchwork Wed May 3 07:35:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xie Qirong X-Patchwork-Id: 9708971 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CA4DB60385 for ; Wed, 3 May 2017 07:36:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B896B2858E for ; Wed, 3 May 2017 07:36:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AB144285EA; Wed, 3 May 2017 07:36:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B4C928475 for ; Wed, 3 May 2017 07:36:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbdECHg0 (ORCPT ); Wed, 3 May 2017 03:36:26 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:35304 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbdECHgY (ORCPT ); Wed, 3 May 2017 03:36:24 -0400 Received: by mail-pg0-f68.google.com with SMTP id i63so7480482pgd.2; Wed, 03 May 2017 00:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=5ZOM/htB07uNyZTzHLNOn4tny/KedKdVIeOwNNCTR4Q=; b=OvWaCpaJliVb/b2ME62h9ieeGDiiklsKph8TdiKHJuhTkiOXh5YAjCWX3UcRaqyGc6 aG+zfbWQ2Ax8v/zng/oWSOP2boDukFAkkYM2sj87LIwHYKa5dwCbXS4Xp77WiQQvvONe 6YvKIQaO9nkCtMRYHavj2x8Uuko6WIGor3p3rSTn5WLqswaOpbrfYfNPhK/l88+MKfq4 AW/ixuuLnSiS0/MOjGqclh33PWf8388W4bzvMmm/tOAffajwgVP5gEl9eg2354g0NmUW mKAuBY3VwBUpTRCVG2Mkf50kg4l436lHUgI3+6Gd/x2E9oumxnJ2bz0kL5dTwxJEd/71 j8ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5ZOM/htB07uNyZTzHLNOn4tny/KedKdVIeOwNNCTR4Q=; b=GoU78Vd9Ec40TtSFkFU+lkT7QwqzSiwCvhzQ2xVH9XwIFZjge2XJJKq+8idcm8VW5a 4lcZKvURbalMHSVpBH6vQUrdK+YgtUoKIPxhFqHMOoxUW7vbNP+NexFAyQwdppI/7jBk 5lT9jXoH6ksziE9Fpct7twEIB2HdsQnAKpZHFhdiYujYBNYAHV8Qg4KoJM7ehywjAhdR oDGrZJCA2XLZ7JVZXPDtffcm/iJ5LRNRCkXJb56FT/W1HrPhbNL3+KVYQv3WhkVCyHkB B8lUAgUsgRvnU+d6kcn/urXBEeKW8uN8B5hG+pEj3CbvxZMIEDtFankSGUcLJWW7CGfK jF1g== X-Gm-Message-State: AN3rC/5Q+EYb+llli9HHaaNVN0ui3qJQ9SF16dvg5nEjvdJtYwEpaKPk twPGhkwZx2LxBw== X-Received: by 10.98.63.220 with SMTP id z89mr3139659pfj.129.1493796983770; Wed, 03 May 2017 00:36:23 -0700 (PDT) Received: from localhost.localdomain ([207.226.143.149]) by smtp.gmail.com with ESMTPSA id x185sm2866840pfx.102.2017.05.03.00.36.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 May 2017 00:36:22 -0700 (PDT) From: Xie Qirong To: Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Piotr Haber , Xie Qirong Subject: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer Date: Wed, 3 May 2017 15:35:55 +0800 Message-Id: <20170503073555.3922-1-cheerx1994@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Xie Qirong Acked-by: Arend van Spriel --- setup_timer.cocci suggested the following improvement: drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use setup_timer function for function on line 384. Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + CONFIG_BRCMDBG=y Kernel version: next-20170502 (localversion-next is next-20170502) drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c index 14a70d4..3559fb5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c @@ -380,9 +380,7 @@ int brcmf_btcoex_attach(struct brcmf_cfg80211_info *cfg) /* Set up timer for BT */ btci->timer_on = false; btci->timeout = BRCMF_BTCOEX_OPPR_WIN_TIME; - init_timer(&btci->timer); - btci->timer.data = (ulong)btci; - btci->timer.function = brcmf_btcoex_timerfunc; + setup_timer(&btci->timer, brcmf_btcoex_timerfunc, (ulong)btci); btci->cfg = cfg; btci->saved_regs_part1 = false; btci->saved_regs_part2 = false;