From patchwork Wed May 3 11:27:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xie Qirong X-Patchwork-Id: 9709467 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A41BA60351 for ; Wed, 3 May 2017 11:27:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 921532860C for ; Wed, 3 May 2017 11:27:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 849052860E; Wed, 3 May 2017 11:27:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28B842860C for ; Wed, 3 May 2017 11:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbdECL1v (ORCPT ); Wed, 3 May 2017 07:27:51 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35920 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324AbdECL1s (ORCPT ); Wed, 3 May 2017 07:27:48 -0400 Received: by mail-pf0-f195.google.com with SMTP id v14so3906228pfd.3; Wed, 03 May 2017 04:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=gu8P2jzctR+1Ec0fWa2f/CDRLjfTmYz0MbUYD3JZDoI=; b=NdpG9F+3bYpwfqk863qGE14TveYsNnSCPXSdndWPwAHDJjtTKZzXcCGF+VvjjDr6HA PcdGTFkt6VhPl7PIF/ARcR//mrf26i1zQjAObwhTZlmraVQRtfqkCBgo/CSnEf8B3k4u 0Jr8dhZvCJEh208eTy0im2Vv6onRfg4Wm2YQHLBLCs0rrXvi79N+rMJF34Ao3Q3RPnDR WAMaG0YbQPa+wEaAOj7rQkhAmluVWDI76jl+repl6rhdMb8ButmMIU+Pt+Oy5UV6FigC 4WVy5bwxuUklAO+qREl580qTr/xI2ZStZcPjZs40E3lmkmxAeg15vwRkcFQJn5AEbpoi YKEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gu8P2jzctR+1Ec0fWa2f/CDRLjfTmYz0MbUYD3JZDoI=; b=XBWPpY0hbwTs3hHeGDO11CjyJAEAtO7NExNwNzswP20sNm43ppNKN5cWwgcdZy3TpS PhlVaqox7oxsyzZ7ZysN3IJMHs2Jx6LD6A1+MwdjUllA+TEVihMZvGV7ukH5Kw3PplS2 0AA6XQQK8eRuU9gmLaYSAnYm2zGcDOEHlotQAIDEE78+W83U79f5U1giYrWkbIAJ3rrf QGxCkd+3pIzEbE22fisC1UI6AINiSOoLn6pVYSqDuyEkmloudVcVf5gBal48T7Zsb+Nh L4d9Kl7yJpklmpsfUsG19m0SSkIFctEg9wDcjy9xt25Gb+hXx1Eh68niRai1j0QRRrKN 46jA== X-Gm-Message-State: AN3rC/683NsE4wuhN/myEv5UR+WjFXABjmaokUIwh8OsGZjVNIDzbmq7 GP9cQorEUyfO6FTo1cwwzQ== X-Received: by 10.98.13.19 with SMTP id v19mr4293005pfi.89.1493810867718; Wed, 03 May 2017 04:27:47 -0700 (PDT) Received: from localhost.localdomain ([207.226.143.149]) by smtp.gmail.com with ESMTPSA id s10sm4343002pfe.28.2017.05.03.04.27.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 May 2017 04:27:47 -0700 (PDT) From: Xie Qirong To: Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Piotr Haber , Xie Qirong Subject: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer Date: Wed, 3 May 2017 19:27:23 +0800 Message-Id: <20170503112723.14397-1-cheerx1994@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP setup_timer.cocci suggested the following improvement: drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use setup_timer function for function on line 384. Signed-off-by: Xie Qirong --- Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + CONFIG_BRCMDBG=y Kernel version: next-20170502 (localversion-next is next-20170502) Thanks for Arend's advice drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c index 14a70d4..3559fb5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c @@ -380,9 +380,7 @@ int brcmf_btcoex_attach(struct brcmf_cfg80211_info *cfg) /* Set up timer for BT */ btci->timer_on = false; btci->timeout = BRCMF_BTCOEX_OPPR_WIN_TIME; - init_timer(&btci->timer); - btci->timer.data = (ulong)btci; - btci->timer.function = brcmf_btcoex_timerfunc; + setup_timer(&btci->timer, brcmf_btcoex_timerfunc, (ulong)btci); btci->cfg = cfg; btci->saved_regs_part1 = false; btci->saved_regs_part2 = false;