From patchwork Thu May 25 00:11:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 9747249 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B34E160246 for ; Thu, 25 May 2017 00:14:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A58FC205F8 for ; Thu, 25 May 2017 00:14:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9A63326E54; Thu, 25 May 2017 00:14:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60DD4205F8 for ; Thu, 25 May 2017 00:14:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034057AbdEYANo (ORCPT ); Wed, 24 May 2017 20:13:44 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33427 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164719AbdEYALm (ORCPT ); Wed, 24 May 2017 20:11:42 -0400 Received: by mail-pf0-f174.google.com with SMTP id e193so150313047pfh.0 for ; Wed, 24 May 2017 17:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NBPKVcQj0pqEpnJeoGTLb/CutK5zAgKdE4og8RUURiI=; b=a41nTJAznqWhk2YWQ/x+z7svk8cG/ikslwVV/zq4MCa5oNmjQ8pTwNIRRMbA0FWcyw RrBXuIoX/A4o4aEM1I6eeC0SWBHQ+y9r3s/QzcetrmOhFjdCSbFIW4NbfH0BTgeIoqB+ sPfCl6TUj2LNU0VSLBi49LXNPjyxbRw43VSrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NBPKVcQj0pqEpnJeoGTLb/CutK5zAgKdE4og8RUURiI=; b=sWCJ7LSYXI7HZWKyt2wW0q2tKdV5TJaxJlmBeeB4QvcLxcV++v8enY7j+MMr7sMb8E SLsWsYXEqTu0TtIUKAd3DtBnwhpKWSGLm7E7QZqvI+nXz8YyoyKz6qFCVMXt6GqWlyzQ CbPUaTM6MRLC7CPt5G3ymfZY0TA58mhz79GJFK/SSQ35AaLlvkFjQJ3QFIkO/q2SBo71 A+aTOD7V7ad07LgSIe8pwzec+tPZYWzYsBQjP88XyRwbd6+nDhO2BKgQCFNI2BtvpEEO BnJpIY65FSGRSGu7Yv563FJXHije1NdhtI+oKKdudN1dt1gH78cA/ih7mxhdMOzwWhp4 0czA== X-Gm-Message-State: AODbwcC5A6FmEP7QAQxJTiTpOLE/BGPEfiGTSqzQZZWYQ0s6lANR+pL9 x0GtAao+w+RvJNEa X-Received: by 10.98.111.133 with SMTP id k127mr41242759pfc.215.1495671102121; Wed, 24 May 2017 17:11:42 -0700 (PDT) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id s23sm9823692pfg.81.2017.05.24.17.11.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 May 2017 17:11:41 -0700 (PDT) From: Brian Norris To: Ganapathi Bhat , Nishant Sarmukadam Cc: , Dmitry Torokhov , Amitkumar Karwar , Kalle Valo , linux-wireless@vger.kernel.org, Brian Norris Subject: [PATCH 10/14] mwifiex: pcie: stop masking interrupts in FW downloader Date: Wed, 24 May 2017 17:11:15 -0700 Message-Id: <20170525001119.64791-10-briannorris@chromium.org> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog In-Reply-To: <20170525001119.64791-1-briannorris@chromium.org> References: <20170525001119.64791-1-briannorris@chromium.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The upper layers already have disabled our interrupts (haven't called ->enable_int() yet for probe(), and we call ->disable_int() before trying to reset), so this is redundant. Signed-off-by: Brian Norris --- drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 7d5a4f2a9a22..c86119b05f52 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -2113,12 +2113,6 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter, "info: Downloading FW image (%d bytes)\n", firmware_len); - if (__mwifiex_pcie_disable_host_int(adapter)) { - mwifiex_dbg(adapter, ERROR, - "%s: Disabling interrupts failed.\n", __func__); - return -1; - } - skb = dev_alloc_skb(MWIFIEX_UPLD_SIZE); if (!skb) { ret = -ENOMEM;