From patchwork Wed May 31 16:31:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 9757755 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9E96B60390 for ; Wed, 31 May 2017 16:31:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9175D2766D for ; Wed, 31 May 2017 16:31:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8619B2834A; Wed, 31 May 2017 16:31:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 277B92766D for ; Wed, 31 May 2017 16:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751075AbdEaQbQ (ORCPT ); Wed, 31 May 2017 12:31:16 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57318 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbdEaQbP (ORCPT ); Wed, 31 May 2017 12:31:15 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v4VGTttZ134675 for ; Wed, 31 May 2017 12:31:14 -0400 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2at0xpscvt-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 31 May 2017 12:31:14 -0400 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 31 May 2017 12:31:13 -0400 Received: from b01cxnp22033.gho.pok.ibm.com (9.57.198.23) by e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 31 May 2017 12:31:10 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v4VGVAiY26935522; Wed, 31 May 2017 16:31:10 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 27FE3B204D; Wed, 31 May 2017 12:28:46 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.110]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP id D1BDBB2050; Wed, 31 May 2017 12:28:45 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 4DF4416C61F2; Wed, 31 May 2017 09:31:10 -0700 (PDT) Date: Wed, 31 May 2017 09:31:10 -0700 From: "Paul E. McKenney" To: Arnd Bergmann Cc: Arend van Spriel , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Brian Norris , linux-mtd , linux-wireless , Linux Kernel Mailing List , "open list:RALINK MIPS ARCHITECTURE" , Ingo Molnar Subject: Re: [PATCH] bcm47xx: fix build regression Reply-To: paulmck@linux.vnet.ibm.com References: <20170530112027.3983554-1-arnd@arndb.de> <7b6903a2-ce54-44f9-18ed-a14bd32069ce@broadcom.com> <20170531131216.GJ3956@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17053116-2213-0000-0000-000001CAEDC5 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007149; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000212; SDB=6.00868271; UDB=6.00431481; IPR=6.00648150; BA=6.00005388; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015657; XFM=3.00000015; UTC=2017-05-31 16:31:12 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17053116-2214-0000-0000-00005651EB02 Message-Id: <20170531163110.GL3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-05-31_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705310299 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, May 31, 2017 at 03:34:57PM +0200, Arnd Bergmann wrote: > On Wed, May 31, 2017 at 3:12 PM, Paul E. McKenney > wrote: > > On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote: > >> On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel > >> wrote: > >> > On 5/30/2017 1:20 PM, Arnd Bergmann wrote: > >> >> > >> >> An unknown change in the kernel headers caused a build regression > >> >> in an MTD partition driver: > >> >> > >> >> In file included from drivers/mtd/bcm47xxpart.c:12:0: > >> >> include/linux/bcm47xx_nvram.h: In function 'bcm47xx_nvram_init_from_mem': > >> >> include/linux/bcm47xx_nvram.h:27:10: error: 'ENOTSUPP' undeclared (first > >> >> use in this function) > >> >> > >> >> Clearly we want to include linux/errno.h here. > >> > > >> > > >> > unfortunate that you did not find the commit that caused this build > >> > regression. You could produce preprocessor output when it was working to see > >> > where errno.h got implicitly included and start looking there for git > >> > history. > >> > >> I did a 'git bisect run make drivers/mtd/bcm47xxpart.o' now, which pointed to > >> 0bc2d534708b ("rcu: Refactor #includes from include/linux/rcupdate.h"). > >> > >> That commit seems reasonable, it was just bad luck that it caused this > >> regression. The commit is currently in the rcu/rcu/next branch of tip.git, > >> so Paul could merge the patch there. > > > > Apologies for the inconvenience, not sure why 0day test robot didn't > > find this. Probably because it cannot test each and every driver. ;-) > > No worries. > > > This patch, correct? > > > > https://lkml.org/lkml/2017/5/30/348 > > Right, I should have included the link. And my turn to say "no worries". ;-) I reworked the commit log to tell the full story as shown below. Anything I misstated or otherwise missed? Thanx, Paul ------------------------------------------------------------------------ commit ff278071dce9af9da2b5e2b33f682710a855d266 Author: Arnd Bergmann Date: Wed May 31 09:26:07 2017 -0700 bcm47xx: fix build regression Commit 0bc2d534708b ("rcu: Refactor #includes from include/linux/rcupdate.h") caused a build regression in an MTD partition driver: In file included from drivers/mtd/bcm47xxpart.c:12:0: include/linux/bcm47xx_nvram.h: In function 'bcm47xx_nvram_init_from_mem': include/linux/bcm47xx_nvram.h:27:10: error: 'ENOTSUPP' undeclared (first use in this function) The rcupdate.h file has no particular need for linux/errno.h, so this commit includes linux/errno.h into bcm47xx_nvram.h. Signed-off-by: Arnd Bergmann Signed-off-by: Paul E. McKenney diff --git a/include/linux/bcm47xx_nvram.h b/include/linux/bcm47xx_nvram.h index 2793652fbf66..a414a2b53e41 100644 --- a/include/linux/bcm47xx_nvram.h +++ b/include/linux/bcm47xx_nvram.h @@ -8,6 +8,7 @@ #ifndef __BCM47XX_NVRAM_H #define __BCM47XX_NVRAM_H +#include #include #include #include