From patchwork Thu Jun 15 18:25:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Greer X-Patchwork-Id: 9789799 X-Patchwork-Delegate: sameo@linux.intel.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AA6BF60325 for ; Thu, 15 Jun 2017 18:25:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A19FF2861E for ; Thu, 15 Jun 2017 18:25:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9677A2862C; Thu, 15 Jun 2017 18:25:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 491FD2861E for ; Thu, 15 Jun 2017 18:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753158AbdFOSZn (ORCPT ); Thu, 15 Jun 2017 14:25:43 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39235 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139AbdFOSZl (ORCPT ); Thu, 15 Jun 2017 14:25:41 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C6F9120AA5; Thu, 15 Jun 2017 14:25:19 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Thu, 15 Jun 2017 14:25:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=animalcreek.com; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=qmO PaatNVMRRZ9XpI8At2xdGmipH0wrRnbGrl24lBFg=; b=h6x7IROA2nmHMVPRKg3 MsmJV+m55DqtyQFULfu8+wvvRYYpeXgX+8MUGZw2brwVvqRijqssB1UtqAVpubHP 4405SHWPLm1Nlxyp3biFLFttFL7ZQ9Fn7McWoQ0xJ6z2solHKiq4ZGiT4W/YzH7f eZJK2Q82B1O4py66wumDScyw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=qmOPaatNVMRRZ9XpI8At2xdGmipH0wrRnbGrl24lB Fg=; b=rhN3cXHAXxsWpzM7jlmrNxlLAacyaetxP4dUZyZIp04BtsN6y4JiIoicc ikVArL4iKLZ012VptH9nIdyo+pUlmSEMsGYvlB4LlmUJdPx/HFGK1+olyn4kUwzK ZDhpySAvyTfude00hk4x9kA/teHQhUIpaDLb55YmU/s+j2VYR2UXGLJ+eNOLH6jA 1j01+xvV+CWsBeTpa4y+an2O8WP1snM48CTYM4yZDLRTaIrMkiBdZC0VCJivz5M0 lP/ur3qAUehuo6NQOx0plmx7la5KOuxvN0/jp+XVp0t0ueIaP0rjzpseAYpqEn89 cEAXvk2Q6PVcrcCWReLpuL0FbZVvw== X-ME-Sender: X-Sasl-enc: GJkcx1/9YgYQh8I01kMCVXTrjBHToFb0Ue7zboi8IvZT 1497551119 Received: from blue.animalcreek.com (ip68-2-81-12.ph.ph.cox.net [68.2.81.12]) by mail.messagingengine.com (Postfix) with ESMTPA id 8362A249F3; Thu, 15 Jun 2017 14:25:19 -0400 (EDT) Received: from blue.animalcreek.com (localhost [127.0.0.1]) by blue.animalcreek.com (Postfix) with ESMTP id 36751A2005E; Thu, 15 Jun 2017 11:25:18 -0700 (MST) From: Mark Greer To: Samuel Ortiz Cc: linux-wireless@vger.kernel.org, linux-nfc@lists.01.org, Mark Greer Subject: [PATCH 18/23] nfctype5: Remove useless initialization Date: Thu, 15 Jun 2017 11:25:11 -0700 Message-Id: <20170615182516.4508-19-mgreer@animalcreek.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170615182516.4508-1-mgreer@animalcreek.com> References: <20170615182516.4508-1-mgreer@animalcreek.com> Organization: Animal Creek Technologies, Inc. Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no point in assigning 'local_data' to 'cookie' when 'cookie' is going to be reassigned before it is used. Signed-off-by: Mark Greer --- plugins/nfctype5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/nfctype5.c b/plugins/nfctype5.c index f26d8fa..873ac79 100644 --- a/plugins/nfctype5.c +++ b/plugins/nfctype5.c @@ -430,7 +430,7 @@ static int t5_read(struct near_tag *tag, uint8_t offset, uint8_t *buf, size_t len, t5_local_cb local_cb, void *local_data) { struct type5_read_single_block_cmd t5_cmd; - struct t5_cookie *cookie = local_data; + struct t5_cookie *cookie; uint8_t blk_size = near_tag_get_blk_size(tag); int err; @@ -529,7 +529,7 @@ static int t5_write(struct near_tag *tag, uint8_t offset, uint8_t *buf, size_t len, t5_local_cb local_cb, void *local_data) { struct type5_write_single_block_cmd *t5_cmd; - struct t5_cookie *cookie = local_data; + struct t5_cookie *cookie; uint8_t blk_size = near_tag_get_blk_size(tag); int err;