From patchwork Tue Jun 20 00:32:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 9798305 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id ADE5460328 for ; Tue, 20 Jun 2017 00:32:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A35D927031 for ; Tue, 20 Jun 2017 00:32:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9835A274D2; Tue, 20 Jun 2017 00:32:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4EBB727031 for ; Tue, 20 Jun 2017 00:32:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752725AbdFTAco (ORCPT ); Mon, 19 Jun 2017 20:32:44 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35901 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752643AbdFTAcb (ORCPT ); Mon, 19 Jun 2017 20:32:31 -0400 Received: by mail-oi0-f67.google.com with SMTP id g14so10724096oib.3 for ; Mon, 19 Jun 2017 17:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=OqdgSFRAncIWRT5vHHMmcDvv6DCx6UKuuclBvEEZLAs=; b=sNTQ6xFIUGzkVhRgSrkDOc8oy9am0juiPMvP3w1l8mgvKldGmzR+/S/NE9Hg3gT7ll SprgfIQd/Ljmzli0e3Hdwf1qlS/M7utxOa8NhtOEUrMCyHj6Zly9DYjNM6qvQ2C2GpjG tlZlYQ7b/rW3IP3RN/LNkXQNXg0uPovEiQLb/TVzbnnhqIATHiIY51W2NTq5XbGnx9qX vHllxeDBJ9aQuts7NwW6JZvvR7r+W7utE/FfufeD2G2iAKpDDfhJMQyQvKz6cZ92cYaX xtQ65q+QLEsCqUQiwgU2aV95QXfd3z7GtM6pDoegqvZc4h+FkfrXwob8WpF5D6Scse8p 4DZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=OqdgSFRAncIWRT5vHHMmcDvv6DCx6UKuuclBvEEZLAs=; b=FpcMIB/LXxHg/o6Jzg0KusaV58fSNQ6f5OAHQWqrz/XQsBo7U44JyhdQJlK/mSDI2j D0KJrAdhcU2940bt96ZOAYNack41aUeSkurHUeQSW7x40nWgj5R22WyQHGISmh2UcVfx /qaT1kqLb/TDrZCnGMEWeRKNdMYTmOl5zNf8EuGqKV/Ph9ESMbPU/628JR6qSEobZSIu +Y2XHMStdkENiKnMN1eq6OYRjm828YnEt/1bDWKa+loDpXh86/2bmYKKnugqPImBCLQV LLr9NNUt6FoIiBco+h8RTrGt/CcA730bETh1qG/vEya6iW8Bi4ZXqXTucrHh+R/T8h9a Ju3g== X-Gm-Message-State: AKS2vOw3cftGqgjKU+wCMdCMNsqJ10Iiazq3lK9hNpDf73o1nB4mnZkO dq9UTslDfGWmJw== X-Received: by 10.202.221.6 with SMTP id u6mr14496691oig.165.1497918750232; Mon, 19 Jun 2017 17:32:30 -0700 (PDT) Received: from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id 198sm5841023oii.16.2017.06.19.17.32.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Jun 2017 17:32:29 -0700 (PDT) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Ping-Ke Shih , Larry Finger , Yan-Hsuan Chuang , Birming Chiu , Shaofu , Steven Ting Subject: [PATCH 05/10] rtlwifi: Add return value to btc_set. Date: Mon, 19 Jun 2017 19:32:13 -0500 Message-Id: <20170620003218.17010-6-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170620003218.17010-1-Larry.Finger@lwfinger.net> References: <20170620003218.17010-1-Larry.Finger@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Ping-Ke Shih We will use return value to handle error case. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c index d8fb2442f795..ffa7a517b665 100644 --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c @@ -534,6 +534,7 @@ static bool halbtc_set(void *void_btcoexist, u8 set_type, void *in_buf) bool *bool_tmp = (bool *)in_buf; u8 *u8_tmp = (u8 *)in_buf; u32 *u32_tmp = (u32 *)in_buf; + bool ret = true; if (!halbtc_is_bt_coexist_available(btcoexist)) return false; @@ -577,6 +578,7 @@ static bool halbtc_set(void *void_btcoexist, u8 set_type, void *in_buf) /* the following are some action which will be triggered */ case BTC_SET_ACT_GET_BT_RSSI: + ret = false; break; case BTC_SET_ACT_AGGREGATE_CTRL: halbtc_aggregation_check(btcoexist); @@ -622,7 +624,7 @@ static bool halbtc_set(void *void_btcoexist, u8 set_type, void *in_buf) break; } - return true; + return ret; } /************************************************************