From patchwork Sun Jul 16 15:16:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kernel test robot X-Patchwork-Id: 9843533 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 69FD760393 for ; Sun, 16 Jul 2017 15:17:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53B3E28475 for ; Sun, 16 Jul 2017 15:17:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 48C4D284C8; Sun, 16 Jul 2017 15:17:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D3FAA28475 for ; Sun, 16 Jul 2017 15:17:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbdGPPRR (ORCPT ); Sun, 16 Jul 2017 11:17:17 -0400 Received: from mga14.intel.com ([192.55.52.115]:34700 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbdGPPRQ (ORCPT ); Sun, 16 Jul 2017 11:17:16 -0400 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2017 08:17:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,369,1496127600"; d="scan'208";a="127938922" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by fmsmga006.fm.intel.com with ESMTP; 16 Jul 2017 08:17:15 -0700 Received: from kbuild by bee with local (Exim 4.84_2) (envelope-from ) id 1dWlLg-000HRE-Iv; Sun, 16 Jul 2017 23:20:44 +0800 Date: Sun, 16 Jul 2017 23:16:53 +0800 From: kbuild test robot To: Ian Molton Cc: kbuild-all@01.org, linux-wireless@vger.kernel.org, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com Subject: [PATCH] brcmfmac: fix boolreturn.cocci warnings Message-ID: <20170716151653.GA2109@lkp-wsx02> References: <201707162358.x6v6RcNt%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170716112129.10206-18-ian@mnementh.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:283:9-10: WARNING: return of 0/1 in function 'brcmf_chip_axi_iscoreup' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: f9996a7ac81f ("brcmfmac: HUGE cleanup of IO access functions.") CC: Ian Molton Signed-off-by: Fengguang Wu --- chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c @@ -280,7 +280,7 @@ static bool brcmf_chip_axi_iscoreup(stru val = brcmf_readl(ci, core->wrapbase + BCMA_IOCTL); if((val & BCMA_IOCTL_FGC) || !(val & BCMA_IOCTL_CLK)) - return 0; + return false; /* Is core in reset? */ val = brcmf_readl(ci, core->wrapbase + BCMA_RESET_CTL);