From patchwork Fri Aug 25 02:30:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mitsyanko X-Patchwork-Id: 9921205 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C186B600C5 for ; Fri, 25 Aug 2017 02:31:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA447204BA for ; Fri, 25 Aug 2017 02:31:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9F563205AD; Fri, 25 Aug 2017 02:31:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0EDF6204BA for ; Fri, 25 Aug 2017 02:31:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754541AbdHYCbq (ORCPT ); Thu, 24 Aug 2017 22:31:46 -0400 Received: from mail-cys01nam02on0041.outbound.protection.outlook.com ([104.47.37.41]:61440 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754347AbdHYCax (ORCPT ); Thu, 24 Aug 2017 22:30:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MQrmc1tPTn+IZO6d/28s/C/dtDGIY8IRUdsXPD5Q+1c=; b=vHg3C9OYlt0BXelcRRttwi97Vd7xFHhoDw3bh/5geUzyQwil7jEY8vSnKpO3wwDFPPNqwUkdIORBxAUtLICreONSttKDrkBW2EK99ll0R7+6Zz939EBa3bufBkCvhjaC7bdPxjF59MqAe+OfnIuHNQd4nFj+ovZBxb4VgXNcXpI= Received: from dodo-dell.quantenna.com (12.131.200.68) by SN1PR0501MB2047.namprd05.prod.outlook.com (10.163.227.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.4; Fri, 25 Aug 2017 02:30:50 +0000 From: igor.mitsyanko.os@quantenna.com To: linux-wireless@vger.kernel.org Cc: sergey.matyukevich.os@quantenna.com, avinashp@quantenna.com, johannes@sipsolutions.net, Igor Mitsyanko Subject: [PATCH 07/27] qtnfmac: get rid of QTNF_STATE_AP_CONFIG Date: Thu, 24 Aug 2017 19:30:04 -0700 Message-Id: <20170825023024.10565-8-igor.mitsyanko.os@quantenna.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20170825023024.10565-1-igor.mitsyanko.os@quantenna.com> References: <20170825023024.10565-1-igor.mitsyanko.os@quantenna.com> MIME-Version: 1.0 X-Originating-IP: [12.131.200.68] X-ClientProxiedBy: CY4PR15CA0017.namprd15.prod.outlook.com (10.172.74.27) To SN1PR0501MB2047.namprd05.prod.outlook.com (10.163.227.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 346b80ec-4e62-4a94-cbaa-08d4eb614d6d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN1PR0501MB2047; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2047; 3:z5D1XpsaIWDWbhOi2bKjZ2dL022M+c4UX1oXNi1iKINmbXjEf/+evJCYkR9IE4h5p0a/v4Lac8BHhfl/8hr+B3lqIGWL2folkE4aRlZPEnROFwH9496JamaGfnj/eVPfK4g2KDMijLQqNRUz/vKfMoYxHri9sl8gg1ZcCwUKhj2Tacm0v16XW+GJDwOfFf86Vnps6y2IHI610yECK6PMv8lHlHoTrarJRb7vMu8KPwqG9ttEFdKiGnffBnIJ0o7+; 25:BO+71rj05DadlLOO3VmECQSSWO03dAQqxgqalBH8gPD5mx99ShFXmU7IZ4ZJzLpcdWGKCh/Q4f7af1WBBGqlLNczmCq5M1e1DVhSabGPYUYO6+nOswO54cynvvISkKWM7RnrTB8nCGDIbHgoesCTjW+IwnFv6JxWae1zOjpp9HM/jDFjQjfuVzsoqMe3QjsPOcaAdhVmbliiNC7wkPCFg/99dRld0fQwVXmIOQO0Tly5m3OgxrLGvnWnDkwC4eQllRDBEP94WS22joWVTnfIF0XKRHexFzKrnB0S9BfqQdSltIC0x3jjw+OhnWQzeCbgLT37Wjzfv6X/T2vayHBRWg==; 31:6vOGwVITQ/AZd4L3EGcNCgxAAxd3DkhQG2D0+3+RSK0js46sbhKddxlQIyQwkdFF6pyJhN9a1F1Qm5amyjk3INpccnas+0VEMzNQyhTmsX9Q5IIX9G5Mp6ih0ZwpSMzRC7H5fsFbxff5CNIKngWCNzZ6CxhWlAMnyLcMFJp37gSrD/2XYYDS+Pux7U3bOdlhC4+7X7bW/MujD/Pha0dLEYAs7Zl6PvTMqUp6Jrl0XBw= X-MS-TrafficTypeDiagnostic: SN1PR0501MB2047: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2047; 20:27GHR4aKoshK9nCHxmahqWWe0r2TaZnCt+tjwsBV6wj7kzRYHolLV7TYKHzg+8B5g6rc0w3r0UNbTFIppHUBGhNxXlLWRJ6D2PNIi58JIHmfHh4U0QOLyQaiArIqT0aGObM3pmVJGD5uGHkQKl/ARyGwxTuXYJ+aoxFvJD4iZ8uBj5pLejDwpnlbgjjf3WRiNOBo6U2jYkg9nYlhoz9tz63UzFAaTNuh8CMXx4t7XQcF7VnXr8b3yeQyehE0m7cunKM819QjdzcsH9tSAZpPCPh6yKmq564soXOPpM+IGWA5t6O336cflfJ7GHiLjB/qe2qTC7qQzjbdofT3SnNAcuwwDSaPFyD2XHPzJArcEYWGqyNyhSqAOqi+OnqAFPXyain1oJdOudPvitpVuifrVdIPWxh0kf3FwNb8zbr9B5jNsjHz4nd8gp3cXDs8oac7snITx2mcV/5efpt9xnizwNORyNhyT1ryIsFWKIR13q6wT/5iJxtju0CjGzE1yEIjNVXICETQegwKGxTUT7MSBvIXVLkq3tImlW1esLBCaDQpsMfOgsYwPiX/O8vCc+253TTqB+rzhnOi+w0j/wUZyUGAb1IWduTOWL9Ejb3HcF4=; 4:y0QAcyZj078w8JOqVCf33LQbEpnLi/CqsBIITBvUmKQvfoP10efLWPgmHWm/VSgkaoUimePWolJU7VqgXc73Y1ydhewjtWYJ/itz+/997glFY0pc/WSDI24m6bhYEHH2/kHszIh+H2yGViO49rhS7k0T5TVw6Cy2/otfq0qKK2P5h31QGjxBbiYlN1arA4q35BJ+xp2UafQs/uVPaGBT1Y13GS/2tooM42eXN2iOm27LEzdbCFoLxA2RBxts4VtN X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR0501MB2047; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR0501MB2047; X-Forefront-PRVS: 041032FF37 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39830400002)(199003)(189002)(76176999)(53416004)(50986999)(110136004)(7350300001)(6916009)(6666003)(2950100002)(47776003)(2906002)(9686003)(53936002)(66066001)(2361001)(106356001)(105586002)(2351001)(86362001)(305945005)(33646002)(7736002)(42186005)(81166006)(81156014)(107886003)(8676002)(103116003)(478600001)(85782001)(68736007)(50226002)(50466002)(3846002)(6486002)(25786009)(36756003)(97736004)(5660300001)(1076002)(6116002)(69596002)(5003940100001)(101416001)(4326008)(189998001)(48376002)(26583001)(85772001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0501MB2047; H:dodo-dell.quantenna.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=igor.mitsyanko.os@quantenna.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0501MB2047; 23:T8rC6neR1ZFX+yCfXdpDH58vd5oWC6GqcYEL1yH?= =?us-ascii?Q?Cs9OyiYE2bWPYVN1DWyFmGsVjlUif/bvX2x09icvKAFDR8RBuLAID1CU9Aav?= =?us-ascii?Q?3sWcdXNaaDbS5lJp1wZqvdyJTXiQ0Rc2J1492NmQUxg8RqjZRVvpdLGnJpbg?= =?us-ascii?Q?pkU0G5bx379TQMSAhHh1Dx/bjgdgUrceGP77Ic7tmWA6SsFOBH2p/N/Rbuj0?= =?us-ascii?Q?rCp+1AEkZAUxCcZrGxVgmkDZnQ9XnotoojlDVzfgqzekidGvewAEBzhPSA2U?= =?us-ascii?Q?Yk/VKp1tr1JC/go68azUKYDhkE0EEZsWUCOlC0eOwGH04jvkyF3GJSF/t5Db?= =?us-ascii?Q?AkD5fEOh4HcXGYDq3qzaUGsh6MA2grn7dcvF1TP+TsRKtNXKpJoe+g/1ql8j?= =?us-ascii?Q?ih7uzXdvDMZWsN4C0+feqT+c/4+mItVuHIj/UH70vwihy2+q1o2weHse4fo9?= =?us-ascii?Q?Yjtw04jiv0FDZiDO8IiB64cAXZSNap4grZWxJllZAXuPGs63oCDZ/NFB5vrp?= =?us-ascii?Q?AWU3kq/V5OTX02ND/GgmESvinhNDDc+MkahqLs5Dly1lPWcQfYNWbR0JTUnZ?= =?us-ascii?Q?Njzz8ZSGlYJ4FO3xAXPIttiQmMlMiiKCA3MIfo7NaLO3+zvvq02CCx/Kkf1j?= =?us-ascii?Q?OaWIxV1Tlu0iVfH7UiKa1aKgHC6jswaEDvQy0vGY6BDaodTQOXFeni4WyUqP?= =?us-ascii?Q?d1YTkyqtxZy4oCRyN/csIp9i43CHSwCbGNS+jSKRsBVKTbJaQnQz1GRjBdCT?= =?us-ascii?Q?SZajGW/QIy8o97aEkpmuSPYGZYBkG74rBXM1RPWibE5yKTmOuLNbvlGj+ieE?= =?us-ascii?Q?CeFRV/WAgpAmxzDTlWaOoFtDbH+g2DUlqgIuhv9F2aIIKmh6CzEnOD+NdCrv?= =?us-ascii?Q?+SCtozzbhdVfL/zlCN6s4RvRhCIJlyaawatU11IcWUpNSP0CPiDfH3O457EV?= =?us-ascii?Q?XeJChoULr2NCLx0r5WgKxERTCAT9qhnx3Z055iC0lYGiKR2aNy4tp3aPfHoW?= =?us-ascii?Q?wivvgHcEDn6ERa+7AurYwRVTbR/SNMrIUtmtdFeQPTYqj0BIbQxDvAK867Qy?= =?us-ascii?Q?pf9Ahwn4En2evS9aZHUdJeugxQf/3kEoQ70ghA/Z2JIvwW9Hlp++C3qHloQm?= =?us-ascii?Q?5r31qmOZxl6oLfuVYz4+hyF70+gowb+qR/jjVPt74YNGZrJwKGkboB63kfPS?= =?us-ascii?Q?HR6rwK1kduC7/AufzmMrfQr/+KJut+Tky7i47NsRIw597gImU2QSy1IJjCEO?= =?us-ascii?Q?9ZnsO45HWHytQjogGzrJsKe97iieKIlUYlL8yr1aAW6uxdbRkTnckpFaG+r4?= =?us-ascii?Q?y2w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2047; 6:s8wSfKxmrYhpTazZyVlaX3YcG3e2a9Ymzqm5rVVeAx0CP9da1G1d5RX+50d8Nkz+/wgpNPOk+gl5PN3vrme8Nua5LX+19W6+0/vAfb0xb5uB0KPksMVAypuXOyeeHKGH0T6iAr+IxwrSJdCGyb2NgZI3E4+SEhC0S2z+h1OgmIOn5az2EXkIw2efDH4uXIkqDYR6N/+4k1MCoVU49oD878NkrQBcyS1piXp+aWDBuyGFRS80UAA1qTBNx2HRxZMyyABkOOOdMQaTaLxVWNRgy/ruLv6hye2K1WOVYbfLZyaB0MoUYhwbuoPu+BoT85jUD5mBj+QOJbcn+2rJz9iQWQ==; 5:1vEbdL7nYg3MgE2PbxznEWWGezI3mdjmU+i9GSpDVD8yeaVLOlBwvpuk5iiP2QCOk5uzkmnKxfBsPGBGZLma6RzxDRj5NjPh/NDTxZ/hSRmgfCui+GFucKDrOhjNWKOnjqi259fUQgBZSCSGLgKEwQ==; 24:DqxrHjwutLpzuhNhOpMQyoEjVFKDVQ5QBPREEASggzNA0YF3np7DetKi3iX7Rn+3jivgvye5oIAsU8jeY9lR85r1nnmIMY/R0dkSmc+3ZrU=; 7:iFKpSkaNrhrJVteq8h3TGwF4AWLA5JmaffmcMgjJ00WxdfCpFxa1KQvwIJGxcT0ke/+NSePUMWjS+mVGT81HUAndqoZHDqOMT+nAaOCyPGjVGAtB0vFLcFTNTKU691bsIYBRSuw5QCfXWr0itcyjRmDdMivQW3zboIvu5Gb9rCJdoS3oLyFGZCkBU7CicOxyGGa1dI4wGKsThIgbNDWzDu5xa2Hkkw6mVah57wPpe5c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2017 02:30:50.3853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0501MB2047 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Igor Mitsyanko QTNF_STATE_AP_CONFIG is redundant and has no real meaning. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 8 -------- drivers/net/wireless/quantenna/qtnfmac/commands.c | 3 --- drivers/net/wireless/quantenna/qtnfmac/core.h | 1 - 3 files changed, 12 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c index 858c24f..26caaf6 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c @@ -275,13 +275,6 @@ static int qtnf_start_ap(struct wiphy *wiphy, struct net_device *dev, goto out; } - if (!(vif->bss_status & QTNF_STATE_AP_CONFIG)) { - pr_err("VIF%u.%u: AP config failed in FW\n", vif->mac->macid, - vif->vifid); - ret = -EFAULT; - goto out; - } - ret = qtnf_mgmt_set_appie(vif, &settings->beacon); if (ret) { pr_err("VIF%u.%u: failed to add IEs to beacon\n", @@ -316,7 +309,6 @@ static int qtnf_stop_ap(struct wiphy *wiphy, struct net_device *dev) pr_err("VIF%u.%u: failed to stop AP operation in FW\n", vif->mac->macid, vif->vifid); vif->bss_status &= ~QTNF_STATE_AP_START; - vif->bss_status &= ~QTNF_STATE_AP_CONFIG; netif_carrier_off(vif->netdev); } diff --git a/drivers/net/wireless/quantenna/qtnfmac/commands.c b/drivers/net/wireless/quantenna/qtnfmac/commands.c index 7b24d37..6b4ccf7 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/commands.c +++ b/drivers/net/wireless/quantenna/qtnfmac/commands.c @@ -255,8 +255,6 @@ int qtnf_cmd_send_config_ap(struct qtnf_vif *vif, goto out; } - vif->bss_status |= QTNF_STATE_AP_CONFIG; - out: qtnf_bus_unlock(vif->mac->bus); return ret; @@ -289,7 +287,6 @@ int qtnf_cmd_send_stop_ap(struct qtnf_vif *vif) } vif->bss_status &= ~QTNF_STATE_AP_START; - vif->bss_status &= ~QTNF_STATE_AP_CONFIG; netif_carrier_off(vif->netdev); diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.h b/drivers/net/wireless/quantenna/qtnfmac/core.h index 066fcd1..4d3e036 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/core.h +++ b/drivers/net/wireless/quantenna/qtnfmac/core.h @@ -52,7 +52,6 @@ #define QTNF_DEF_WDOG_TIMEOUT 5 #define QTNF_TX_TIMEOUT_TRSHLD 100 -#define QTNF_STATE_AP_CONFIG BIT(2) #define QTNF_STATE_AP_START BIT(1) extern const struct net_device_ops qtnf_netdev_ops;