From patchwork Thu Aug 31 14:47:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 9932345 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6871C6022E for ; Thu, 31 Aug 2017 14:48:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4619D2236A for ; Thu, 31 Aug 2017 14:48:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3AC6927F10; Thu, 31 Aug 2017 14:48:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAAC52236A for ; Thu, 31 Aug 2017 14:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751410AbdHaOrr (ORCPT ); Thu, 31 Aug 2017 10:47:47 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:43820 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbdHaOrp (ORCPT ); Thu, 31 Aug 2017 10:47:45 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 02FF3825CB; Thu, 31 Aug 2017 16:47:43 +0200 (CEST) Date: Thu, 31 Aug 2017 16:47:43 +0200 From: Pavel Machek To: Kalle Valo , Linus Torvalds Cc: David Miller , xiyou.wangcong@gmail.com, torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: [PATCH] wl1251: add a missing spin_lock_init() Message-ID: <20170831144743.GA21261@amd> References: <87pobdt8qc.fsf@kamboji.qca.qualcomm.com> <20170830.101143.2305098064824357647.davem@davemloft.net> <87val5rmh8.fsf@kamboji.qca.qualcomm.com> <20170830.105447.125174575140677062.davem@davemloft.net> <87fuc8s5v9.fsf@kamboji.qca.qualcomm.com> <20170831065204.GA17812@amd> <87y3q0q7ln.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87y3q0q7ln.fsf@kamboji.qca.qualcomm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Cong Wang wl1251: add a missing spin_lock_init() This fixes the following kernel warning: [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745 [ 5668.771850] lock: 0xce63ef20, .magic: 00000000, .owner: /-1, .owner_cpu: 0 [ 5668.772277] CPU: 0 PID: 9745 Comm: kworker/u2:3 Tainted: G W 4.12.0-03002-gec979a4-dirty #40 [ 5668.772796] Hardware name: Nokia RX-51 board [ 5668.773071] Workqueue: phy1 wl1251_irq_work [ 5668.773345] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 5668.773803] [] (show_stack) from [] (do_raw_spin_lock+0x6c/0xa0) [ 5668.774230] [] (do_raw_spin_lock) from [] (_raw_spin_lock_irqsave+0x10/0x18) [ 5668.774658] [] (_raw_spin_lock_irqsave) from [] (wl1251_op_tx+0x38/0x5c) [ 5668.775115] [] (wl1251_op_tx) from [] (ieee80211_tx_frags+0x188/0x1c0) [ 5668.775543] [] (ieee80211_tx_frags) from [] (__ieee80211_tx+0x6c/0x130) [ 5668.775970] [] (__ieee80211_tx) from [] (ieee80211_tx+0xdc/0x104) [ 5668.776367] [] (ieee80211_tx) from [] (__ieee80211_subif_start_xmit+0x454/0x8c8) [ 5668.776824] [] (__ieee80211_subif_start_xmit) from [] (ieee80211_subif_start_xmit+0x30/0x2fc) [ 5668.777343] [] (ieee80211_subif_start_xmit) from [] (dev_hard_start_xmit+0x80/0x118) ... by adding the missing spin_lock_init(). Reported-by: Pavel Machek Cc: Kalle Valo Signed-off-by: Cong Wang Acked-by: Pavel Machek Signed-off-by: Kalle Valo Signed-off-by: Pavel Machek Cc: stable@kernel.org --- > >> Yeah, you are right there. I did actually ponder which I tree should > >> commit it back in July but due to various reasons decided differently. > > > > Can we still get the fix to v4.13-final? :-). > > I'm not planning to submit pull requests to 4.13 anymore. If you think > this is so important that it needs to be applied in the last minute (I > don't) you could always try to convince Dave to take it directly. > > Or better yet, push it to the stable tree. If the merge window opens on > Sunday I suspect that the commit will be in Linus' tree sometime next > week. Then you can submit the request to the stable team to take it. I don't think we should use stable tree as an excuse for not fixing the bugs in mainline. Original patch is from Jul 6, thats 7 weeks ago. Dave, Linus -- can you still take the patch? Thanks, Pavel diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c index 08f0477..9915d83 100644 --- a/drivers/net/wireless/ti/wl1251/main.c +++ b/drivers/net/wireless/ti/wl1251/main.c @@ -1571,6 +1571,7 @@ struct ieee80211_hw *wl1251_alloc_hw(void) wl->state = WL1251_STATE_OFF; mutex_init(&wl->mutex); + spin_lock_init(&wl->wl_lock); wl->tx_mgmt_frm_rate = DEFAULT_HW_GEN_TX_RATE; wl->tx_mgmt_frm_mod = DEFAULT_HW_GEN_MODULATION_TYPE;