From patchwork Thu Sep 21 21:34:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mitsyanko X-Patchwork-Id: 9964837 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 068CF6056A for ; Thu, 21 Sep 2017 21:35:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB3F128DD3 for ; Thu, 21 Sep 2017 21:35:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E028C2967F; Thu, 21 Sep 2017 21:35:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D35A28DD3 for ; Thu, 21 Sep 2017 21:35:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbdIUVfF (ORCPT ); Thu, 21 Sep 2017 17:35:05 -0400 Received: from mail-cys01nam02on0088.outbound.protection.outlook.com ([104.47.37.88]:14256 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751801AbdIUVfD (ORCPT ); Thu, 21 Sep 2017 17:35:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=W/2rLkr18mX+Hr/tTWaWObFXyKrAsEf1wcmQmrx67rE=; b=isFk8WDXKWxxsLWxyf2UncTvZIJbIzQJMoM3r9jlFLTzrXyrL7daqzjZG/mKdrxK4uan7DH64hlyHLUfsOj8N6qJb5LKlaTHaajj6gzsi+Q+iroNu66mbRTZxQWeBYUaEBVGRfmRWOI5C0fRCztfdEnLf+LsstwGrNgwD2DuxqA= Received: from dodo-dell.quantenna.com (12.131.200.68) by BLUPR0501MB2035.namprd05.prod.outlook.com (10.164.23.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Thu, 21 Sep 2017 21:35:01 +0000 From: igor.mitsyanko.os@quantenna.com To: linux-wireless@vger.kernel.org Cc: sergey.matyukevich.os@quantenna.com, avinashp@quantenna.com, johannes@sipsolutions.net Subject: [PATCH V3 5/9] qtnfmac: let wifi card handle channel switch request to the same chan Date: Thu, 21 Sep 2017 14:34:33 -0700 Message-Id: <20170921213437.27457-6-igor.mitsyanko.os@quantenna.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20170921213437.27457-1-igor.mitsyanko.os@quantenna.com> References: <20170921213437.27457-1-igor.mitsyanko.os@quantenna.com> MIME-Version: 1.0 X-Originating-IP: [12.131.200.68] X-ClientProxiedBy: MWHPR13CA0006.namprd13.prod.outlook.com (10.169.208.16) To BLUPR0501MB2035.namprd05.prod.outlook.com (10.164.23.17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb81aa44-25bb-4b97-986e-08d501389dfa X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BLUPR0501MB2035; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0501MB2035; 3:hKd8RAQY0m1WjmONt69g9psdtPOgAIzi+gDoXMxh41sUl2SPpt6u8AX9a0CQ8qKrmNF/NYkh812tQti6zeQ4QbzyxNZpljuPrCU+3tOLRgmyshzUsk5cDKRxI/n1AHHcZBa7YTH3MRtCGOhd7+DDNIEI1CyOWGBHeJooMOKbZEtb+frEqksQbpScsx96ekTQGnaAcIi3lkIbvVTumqNO9ldFgcFLiQpFPQ5FQ6GVU1T8Jh3GK/rgIIRNBPSFIDht; 25:WgxwzTV6nTziTEWGG7Zs37Y3YReV5dhbojJ7q4khea1/24VTMl1OCXdJ03rp9Cxkl/OOrzHg2oa2mp4SHuB/lA3j7q+whJ+8VphZIiiO3tE3wsRAEso4ZEwUxXu4PZFLH+PL0V1usKcRAkIShVKgriCUk3Z3Bfy4E9jWurlPDayObsTLGzhsuM7cA668WxWYieD40cRw/Kj4YgRc/ztvnxIjChl0V9Uypazz8QXv20jIJ6rFkuRThtnUeYpnPQ8RVGvqDRbH7qj2GtG6LE4SKT40yGsIdGz3yoLoPnLT2XS2qA0mW84KRxUdN0rbPGN8JAUVAExPGR09RXXHOxZfFg==; 31:KZRziNmJDdVtMuj0riGR6KStznU26VF3em1AMvmvX4kSTttg6XkQdsE/jCcv1mZCe+rbYk4Rc7TkdLOExI0mf1eNjgZDLscTWMVchJ8bwflHcbak6MW2OIk7KBNPjXD1s6Aubp3hHlvA/rRuWkhG7l1LT6hg0lRoCufkinVTvKyeRSKcpbIzuZ71npzyvKtPxgRM19kb/Ef7BnKtRXDlrn8veH5+h2BAIie/BD+eqIM= X-MS-TrafficTypeDiagnostic: BLUPR0501MB2035: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=igor.mitsyanko.os@quantenna.com; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0501MB2035; 20:6U3UD+CvudyDMRDCCNbv2mwD/30GkwQsKEKyCDDhbpIXqftfeRmIfUsbekm7y04/YJBY0S+E3R0qqgYHnUf2jKEjVq7XtJFY4VFVd83D/i7ciO0eTFAdXEuxjgSbbJ2LteLsi7NGdaX3tWZ1cPh2Ptd6smdP0QJ6tN6on2BsKG2m3tqYF1km1N5/hsWE4/9ue+Xd6WwMgyLVn3hdgRCJHSHmcMJ3gZU00YvDwbAphmhdrMHP0EZcjr7TSC0tVx4L7Idfg/SSZmdw2iBgyxFxuM2d8SIMldi0R3yDFtJjv62gCgFyPiS4v4MaieJqArC3e5Frj9ZLj/7GVajujLCCol6Fhv8K7q+Ifny1p/bYkxpddhsFibiGu2Yk8Bx0cAREjkS/R3+HwrtYJ+eKUZcwpYxpSRdscCcsDKXth9WnBNOBgCB+u0GyuUbiI/DA4q/wySI7D0dBEcIM0ZB2cseD5+v7ssrwZFCotiQDCkyKrh4QNsxqMQSZk1jK4Kibe0r/D64RpQwYIDvud9UWWwv2JHxq26k/zv33PRAXX2TPxJZGG26P5XcSHljGedapmw4QKcrqaO29bqh+fuc6cKd730N6eaIShcYAPCct/rTR3Dw=; 4:HvxOJcJzeJu/mUgclcFPp/eZtN4gNdGF7Rm95v9dp7TRvtDIwtYiac3zs9uFf7R5w3vhiSvPA5kRkwZjazIceulmR0VyOr2J8rHpm8htowWfWRfZE7l9Yx7pBW0TPz2RaOM7hwtO52DXfr9UukjTgojSGI5cfKmHvFrAjBVZ8h0maGrlj+Mjwmsf0wCl/CSBEMElkqPZnPdTIP2OqGsZdxlxhQv37yn4BFMp0B+jPsH4QKTAemBpsVHaj0u+Xg1Q X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BLUPR0501MB2035; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BLUPR0501MB2035; X-Forefront-PRVS: 04371797A5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39830400002)(189002)(199003)(106356001)(2906002)(105586002)(6486002)(6116002)(53416004)(48376002)(9686003)(50226002)(3846002)(1076002)(36756003)(103116003)(2361001)(76176999)(68736007)(189998001)(33646002)(66066001)(2950100002)(6916009)(478600001)(50986999)(50466002)(47776003)(25786009)(2351001)(101416001)(8676002)(86362001)(69596002)(5660300001)(81166006)(81156014)(305945005)(53936002)(16586007)(85782001)(7736002)(16526017)(6666003)(97736004)(8936002)(5003940100001)(316002)(4326008)(85772001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0501MB2035; H:dodo-dell.quantenna.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0501MB2035; 23:zX6RJSrxeA9HlMcS1lwA+KKGx7znJ31Xa64993/?= =?us-ascii?Q?akWn/K41sh2y6dJ61fkOzD7sBfcHrhUlzqeyBQEe2GujnKhJh6hJeMVbJ/P3?= =?us-ascii?Q?kb60vCAXs9yUX2VQp+56pYEzrHJFehf25LB0Tspm91Pmo0dIqiRU3Ca7YYO8?= =?us-ascii?Q?RXpfkhaTT1KaHhZLZEyZxk2qdQp5fgPTDLNzQUpaDsdOYbx7CF5dwfcc/js/?= =?us-ascii?Q?oMEHRmjFLdNJ9LdpR7yI3smD+d0yTHQTMBvohQlyrZgqFfI6udWL3wRxjxbO?= =?us-ascii?Q?GwW+w7u1U2d1GPo/5ziWmMtlS7N4f4gbBQ8KBTRI7w8eMT74inlp3D+Tk0D3?= =?us-ascii?Q?t3p6mFfDskg/2m4Lh+5+fyEiq2zDy/xnt19wYnQCOC8Itv7+7P4sHXcSimkX?= =?us-ascii?Q?YcsYG00BwElwfyiHZcDRyH2oEYPslojNBPSPqR3gCq79nsxJpeHSkZ+TvQqS?= =?us-ascii?Q?HQHOJKEI81KTCUFz2QtJN9WZgWUSVil2+xtGfW/ysTYfn5hajwnl52yYl7ws?= =?us-ascii?Q?EapOn+zlOMeoUIw2+Zwm+FtA46G3iYYxsgfKhVAFHrASoCEtN2f55gwY9XuK?= =?us-ascii?Q?/vHAJyRcQsw2ac4EnYY+YoOqgesKkdSqEeW2t+NCwy9Zx4Ee0m9gPw2zxdQm?= =?us-ascii?Q?z15ZvYnoFrtcoOAKwFndHPUAYvU6TcenscudQRCY2AT2Mlp2+vgEDQX89SvL?= =?us-ascii?Q?G1TokUpq+q2z5ldsXOAQJORuNAWITsdWJEXYM8H5/cOjnwLUa15jIWmbGUCa?= =?us-ascii?Q?t4r6VyP2gYK8Mycl+8jQStJU6Lyzm2uTWzefNzBEPUA8OOnZMj7XqbZ7Gfqm?= =?us-ascii?Q?niXoEptT/0px0YqmZiVdBJk3AEwafmD1qZhDzZZb+PRAour1WTbWvfyx6TEo?= =?us-ascii?Q?+XfIzPFhrZLITRA8zsEDHDZIhMcGbMTEb5EP4OovT4367I4Kull8Pvqiv+zf?= =?us-ascii?Q?Z63dTJWeDi70XtrXCHxl+q5U2BZyPvewnU9MPM1tqqdACQW7g8pfTEUOLhGw?= =?us-ascii?Q?+bDqjr5efRthgO8eSmdv7U6XlwGev5ma9vGCIHIRcWSuhOUSwzqI8AbNTq0W?= =?us-ascii?Q?JFFS224uOowN6J1i/UAtjxDvOJ0yfQhyeCsG2vIAuDVNEklNGmQLlstPiadp?= =?us-ascii?Q?cJO4jTLHVIB11kqP/xIYFCo9o5Fi+V55WBMR7bTVu9pp5bA/x8jGPCdBuGMq?= =?us-ascii?Q?jgYXpiBn/iYpHxC/Smv2O+MQj+Afo/ivjp5YRLs+2i0kFUbzjqmkImUZe6A?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0501MB2035; 6:jnoOolUdGiP4WfG3jt44+4nk61avGwES/ophr9FP4+f2KxzOp62507zYpRo7jPh1DUITQrdQ3g4Y6DUcw5pS77xIw43v9IyKvCcxVMAtX9hhxs5ABQocL31EqP9t675jMxYOwC1e4bieufMt3CzY72MxdbGUHz8SeRTWGI5vTdoTLNdDXnLQV+CTt0fnk9BSdrZ3+43vW3grsGrwkBks3/m/yFT9CJ7PajWYxFgA5C6KimQbW1B26dY/De72jykeCn8amltROMMdTxaxXYtEQTkr/Mex9v+Rv23DmT+DT2lTTfivx5XKQRae8x4NRYCdhx2YiX5Z1cJqSj/x9EvdnA==; 5:pecyoXCdNT1y5fYnWAXnEeuEjtYba1Edj3cWLVc+0SoeseQZsGPssN4jjrUBBW0Y/Qd7ZtL/D5rTSUwC/TqyPUAyOeQ/nPN+ej7TJdivaNTMolK/uIZcpqGxKwfpGYs/vn/DO9J1OLzjEshaNVjZow==; 24:mxEyVkgVvgF0BUxHxyKFlouwEb+rsYijRWHfuzznzZ6B3VykWl2R+RrjQrnHCXiMdba45bR0JQsPP9ANYVYptKBZyAXUTmS+nlhfpCHdffU=; 7:lk60HwjEv+oQxkZdkNlt5V90IemliKeh/6NZJrAmZxA4VkZmszhR9BNRPtCVqAjV9Le6nvV99pK9ovnov0mM09WQ0UrGUKGeIVOcGpul/M4T8O8JW55iD7djcNsOL/cHCZwVfDJbdO4XSX3cQDaP1HxGHWFp7yX3nz1MEyJEXv2+xzmcyGdpYHn+mnC9Dr/jaxRukCzldWeS2svVH8dSU2u9mEgVUbGlVzWBNxZhqVA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2017 21:35:01.6628 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0501MB2035 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Igor Mitsyanko No reason to verify channel switch request in driver, it can simply be forwarded to wireless device. Device can perform required checks and return appropriate error code, and driver may not even have information on current operational channel. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c index 17b323e..4590f30 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c @@ -846,11 +846,6 @@ static int qtnf_channel_switch(struct wiphy *wiphy, struct net_device *dev, return -EINVAL; } - if (cfg80211_chandef_identical(¶ms->chandef, &mac->chandef)) { - pr_err("%s: switch request to the same channel\n", dev->name); - return -EALREADY; - } - ret = qtnf_cmd_send_chan_switch(mac, params); if (ret) pr_warn("%s: failed to switch to channel (%u)\n",