From patchwork Thu Oct 5 01:38:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mitsyanko X-Patchwork-Id: 9986291 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EC61260291 for ; Thu, 5 Oct 2017 01:38:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE00928C06 for ; Thu, 5 Oct 2017 01:38:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D2F8428C33; Thu, 5 Oct 2017 01:38:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D07128C40 for ; Thu, 5 Oct 2017 01:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751344AbdJEBik (ORCPT ); Wed, 4 Oct 2017 21:38:40 -0400 Received: from mail-sn1nam01on0084.outbound.protection.outlook.com ([104.47.32.84]:52980 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751275AbdJEBiW (ORCPT ); Wed, 4 Oct 2017 21:38:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mqtQQB+AOon+OXL7hkOhn3Qdu2poyHmwrWaLfj5SsWM=; b=MHWhNkjZ5CbBQVA8uwoIAUdStzYKtq9ERSox+Zlr5a8dNlmCfHppMynm2kP8NQ2NJvOLgGLzJP/1ABtFXC8zUiy8delC7UmUGtkaEyAe9K1T930dnXQRvOJDUCs30jSLW4Ii0LIg1B32qluudX6fCxNEHgqgcneoywuIK2rUeo0= Received: from dodo-dell.quantenna.com (12.131.200.68) by SN1PR0501MB2047.namprd05.prod.outlook.com (10.163.227.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Thu, 5 Oct 2017 01:38:19 +0000 From: igor.mitsyanko.os@quantenna.com To: linux-wireless@vger.kernel.org Cc: sergey.matyukevich.os@quantenna.com, avinashp@quantenna.com, johannes@sipsolutions.net Subject: [PATCH V2 4/8] qtnfmac: get rid of QTNF_STATE_AP_CONFIG Date: Wed, 4 Oct 2017 18:38:09 -0700 Message-Id: <20171005013813.13332-5-igor.mitsyanko.os@quantenna.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20171005013813.13332-1-igor.mitsyanko.os@quantenna.com> References: <20171005013813.13332-1-igor.mitsyanko.os@quantenna.com> MIME-Version: 1.0 X-Originating-IP: [12.131.200.68] X-ClientProxiedBy: MWHPR20CA0031.namprd20.prod.outlook.com (10.172.102.145) To SN1PR0501MB2047.namprd05.prod.outlook.com (10.163.227.20) X-MS-Office365-Filtering-Correlation-Id: 16e07516-509a-479b-382d-08d50b91c273 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:SN1PR0501MB2047; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2047; 3:k5QPipEM6FIBCRf/yb6ggYT2Oij8vDEvCDZ1E8qVTYpLHEay9TGqN9bk2t/OL7RVsRwZG/LIbTlkAyEohDQL8woaAziyldZpBF7SJ4JXqIUdtFldWp5ZAPJ+CJJALzxrRyaLLxt5XatkXz1IwSVNno08FjzqIDdM+7pLkToZENltCGqKIs8gUMWoFTOP6z4nM8vFY9JZwR4RbIXY+EI15SG38x/eC22HShe+5rz3S9g5CoV79znbJ+Q+OgNn8HOr; 25:tuS8I74Suaz2Aq0QsTLPDeh+iBw5fOxOs9dnUmVjfzV6LeIFpuo/Q9nRE4aa0RjAZjlMbwfeeVxjBMwO7aJc8cZ+MRk8LaoN/1m55a5oyP8PNSb1ui7KaEovAK3AxFXlPUq2Y7KVbLhJMcn7Qypd+GyFPEGSQggBI3Rz4cZzCtbWqLJ4tLSgBaZkksltBvlLKB1m4ClBOnpilGP4gI/IFhUuEqfbG5SNgMXUvwPeXcWwxqm9OaBg9/22lHYT+8xpUuueDQ2wHfNQg3S58FLZx9FMwp53d0zE6xrjuKXkdVRtvuxTHoC1DsJA56EYM/Iijf8tKN5HFJX7HUsoSX5uuw==; 31:M/YbX4UtPwWgfetyl1G/Ms6imQJ8tRKzcXJrnlZx5ZtB29yr/IqI+TiFxFY8Vn2h1TViFRH4FYu3AN3Lh5RI6osp1iIMWf/vr/5fZKhbOdJd11Chn1o7rPHuSl8w436HfFS+MEi2nQ9w46Yh2WqlQmhHbYlYpKlcCwttyT6QCLQuc2ylPqRU3cgXs/QDAJkhxpZG9ClpXnG2q2bqWOKdiZoFlBPU7i7PHinlxdGiN7s= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PR0501MB2047: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=igor.mitsyanko.os@quantenna.com; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2047; 20:QOhRUcSsHNlwQO4leqX4AZJ/YkuG6H3vaJw8LI9kSbHOsMP3vDQdKOc9MEQgBFmu3QsTRslbb4ACzcwfBs8LZnaSXz5vmEsjy+JCtr3FITlrzBPan/duK+38gKry10ha9Wz5524OrkeU1z/mL69DpZ8bGZAMQeIs6X5klThA5piBxir3uKAu5vxdhiw3GqVMVM6Tg17L166Q2NXbieaKiVmH7Gh1HLqrBfFJAutPnKTG5ZGULa/0o1kZVhSvDXcWD0bTye6+Uy5HCd+uI5fMoLpFc3AyRoBQ7Sq4/nt8qpkr4YCojOnrhbwPnHlvN/kdHAJ2QTmS2oWlQOSNBtMm4aGAME47oxju9m6JbfiZ6yKgqYzplob//gqSbOhXmTfE3aciTin4yIZGmOdU5wvNtBo5BjVcMBilDGa4NCdCruEJtFs/Vr3Z7gXJfrKyjaXRf+FcnzEA27w0z3xLZLhFi2MhFuduG2ogTBbWpdWrca/ulv3wX2YR9gt5w+Xj+MCTxs+ZdpptYWp7bl1IJfr6ltvOrAr1srftW43k1VXvPceZdKzGJr36+FlQ5ssFJg7fY9D/x6c42rCPkzHPzeOGUzfE6prIoNOrTTupWLej9C4=; 4:OcsXTuNKPm9fS/M14kafM5blIY1w6nBsJmOL+BM24HD2z8GtlKZCJMi3fFQcwbFg4YbDbnsNBZQGqz031nGdArCXmllVHH8z4RwwlVTP7CknLHUztQFvZsfq5yd7pHFd6cIoqOhRdbj45m7KYd1zCbApnajzu0E6PtHGRmfUcLQNJOPuccePNvZHv5o4JRFI5R6M8GembpTmQlV7Svvy5ihtYtVelsVDxGhdbKPeq1WoKW2c7MPWg83OwXUvKsfQ X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR0501MB2047; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR0501MB2047; X-Forefront-PRVS: 04519BA941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39830400002)(189002)(199003)(25786009)(106356001)(103116003)(105586002)(2351001)(33646002)(69596002)(53416004)(2361001)(3846002)(16526018)(85782001)(53936002)(66066001)(16586007)(2906002)(316002)(1076002)(47776003)(6116002)(478600001)(7736002)(8676002)(68736007)(86362001)(6666003)(97736004)(101416001)(6486002)(81166006)(76176999)(48376002)(189998001)(2950100002)(50986999)(8936002)(5660300001)(4326008)(36756003)(6916009)(50226002)(50466002)(5003940100001)(305945005)(81156014)(9686003)(26583001)(85772001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0501MB2047; H:dodo-dell.quantenna.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0501MB2047; 23:O6wNN03asNJXB68ZUZHfTNjC1gmciunfd330e6j?= =?us-ascii?Q?zAM0RxfbSQffGPgK1K1QBPz/vdnLa1bXTKVF8QmSZFEMsR5j5x6lqSx1OdED?= =?us-ascii?Q?DVsxbpjKSiDBsJCp0wJd7iAoTbK6WN2Ut2128SF3YlVErfA5+jL0sT8+kEXX?= =?us-ascii?Q?NkBRlE11M4GYUpk2RutOODvdMmP2czqD/ZW7BDRGxVNpjM5ZaW/Tt9MDki+5?= =?us-ascii?Q?youhCmQiEJ+TbV+186buSVUkNjVugEzqcL0xTPl6BCWJWwuulRavct/2z7WF?= =?us-ascii?Q?29PdxfiE8hxmUAg0iWVhOX5kh1kUFmMfq1rQocQop4VylkZ6QqXdVwdeLaE2?= =?us-ascii?Q?2Fvdm54njKzDBfizdtpSjkP4NE1MpAI1FSzIxiCljqzp9+iBwdFnpK0EjW0U?= =?us-ascii?Q?rUDXlRNEBgiWvYlOeau5NxR74RhCwZDCoR4q6BGln19dhdh7xJFzONjZuekO?= =?us-ascii?Q?DfZm8yVxXXYb49RNJQGIKpf9xoTy7RIohfabzouNEJiFxLrqYOdukMN5Hq0j?= =?us-ascii?Q?8jMiR3ZwZwV7pi2s60psGHBktQx3Maj7XU9il85guqyFdDOuBPvn7xnRpa4F?= =?us-ascii?Q?8W+OT8OwHQWid7XBzEY6KoLslcQuZsciQOjpfTjpMCpgNLBsgNkqcn3enE0e?= =?us-ascii?Q?+SmA99+WjGF+Zu3rklPBV+7ZCb4WpoxqTYEW4qKXfBgYRvh7iyzg5S4cOKiQ?= =?us-ascii?Q?AkiQshw8b+CD/Gr9SnR/yWAkmJsdjsThsNmMgBb6hj1dySGTqRkfg5+HjAin?= =?us-ascii?Q?Cj2iCf4bsDtMMPcolHWZaxn7/kTnjy9D0t4sgRd6HJ4LNSwhv4Z5RSnu1+U2?= =?us-ascii?Q?FPr1jKT1qHk8f4fQFr/RpJQEQh7PUfRQw7VPT3lzMf5yr+E7vNjzP7MVw89T?= =?us-ascii?Q?QOqPTjFtMsskTCf66vDIPo3NBKvKnFnz/KM0Uvh8J9yX5frU1xTKnvA8ggFw?= =?us-ascii?Q?CBbuz4oGT4GlRKfWBXsLjbB/mlO4FZwp4vfqtJ/zwA0mNTMICbanh86mR0Ga?= =?us-ascii?Q?FXrlSuAzodbNMEpAw9bjo6gIRXBAzAwYRzERZw+0GYnROCziZu2qJWmeWA4T?= =?us-ascii?Q?AgFMA1BZi+Xt4KDWk/15r7zauL7O7UvhV1INSBY6HmM5I4fcfeRmTrl7Mmcr?= =?us-ascii?Q?geQt5b1Lc+z/z3j6zd4g1TiwYVLuIleFliy+fSLk6NRnBMCSsyoYD9c8AmT7?= =?us-ascii?Q?p9gzeBZ/5ahSbkqW0IGdPgyonD/ip/Rp4gBr5sMrKPgMuRRGnqb3oX4QYu1K?= =?us-ascii?Q?vM3XWCdLMX6eshnxEseI=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2047; 6:HTbknjPUTPCm/qlBQ/geFI9B6bUSw1iAcdndFKAINfHl2H2IkgJEvVEXOTG6zA4UdP3kds72O40119ihSIIRR3c2ALz9JcVXOrYl0c9C8/PfUqFq+ROL3nKTLl46JlaD4aYBhJ/4iK1e7JPg+GpFPibBuIkS/4uDayrPKIJOEwiuRjiZtQFquh6vKTi3meguO+PNFTraJEyq6UygOVBKTEFUMvYcpNkWxERiHKI1ByNmakVqqK7nwhSQNM/PkyZKwbctL4CoWOYFd81n/AjjaOJYW0PGLUjvI84qsKkcyJRQyRQU6W05s39RXzMPKMncAA9G+WU3/r4RTSq4gUbRAg==; 5:Uvv6YAuxPVPrW1PGrwHe9iEPAh8cqfmT1/DxG6piz9NxLxMXcoDBvW/AUg7/5lSsUx6mbX3t0sYFc8g4jNyEpnY4tZngnYZw8iCWaCCdvNpBVhZpFKJ8GKUXoVHh99J/x35OCWxK+9Y9Mj/7cqdpzQ==; 24:SZl2T2GQWAjKUD3ZT7esX7aw4gUwR+Ui7XpWoHVdGdNYJXSKboDi/czK66TTjknkUvV//z636yXspodm8gG10zVHY8y9vKxLstMePeBPtgY=; 7:T16NO2rol+pAXOQBVQOJ2l4gA0BcCwpCVv2VZB6qcOKybeRhAstzjjnGLXSfOJSO50gXEomdDlDMr1EL3ThqL4kaRS0wPNt83hOKqNnGbuayNLaptKvp651NO2yxCq2qsQ6wVbmcIrnM8x6w8QTQQAcQZZQ4LAYKFzugLmkoHOVyYI1zr+7e6rmEksq7qe8dlWRSVznWWic5N7np1MZgGf4at2K9w9XcBUHJWaXOC4Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2017 01:38:19.8912 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0501MB2047 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Igor Mitsyanko QTNF_STATE_AP_CONFIG is redundant and its usage can be safely removed. Signed-off-by: Igor Mitsyanko --- drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 8 -------- drivers/net/wireless/quantenna/qtnfmac/commands.c | 3 --- drivers/net/wireless/quantenna/qtnfmac/core.h | 1 - 3 files changed, 12 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c index 056018e..c660846 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c @@ -275,13 +275,6 @@ static int qtnf_start_ap(struct wiphy *wiphy, struct net_device *dev, goto out; } - if (!(vif->bss_status & QTNF_STATE_AP_CONFIG)) { - pr_err("VIF%u.%u: AP config failed in FW\n", vif->mac->macid, - vif->vifid); - ret = -EFAULT; - goto out; - } - ret = qtnf_mgmt_set_appie(vif, &settings->beacon); if (ret) { pr_err("VIF%u.%u: failed to add IEs to beacon\n", @@ -316,7 +309,6 @@ static int qtnf_stop_ap(struct wiphy *wiphy, struct net_device *dev) pr_err("VIF%u.%u: failed to stop AP operation in FW\n", vif->mac->macid, vif->vifid); vif->bss_status &= ~QTNF_STATE_AP_START; - vif->bss_status &= ~QTNF_STATE_AP_CONFIG; netif_carrier_off(vif->netdev); } diff --git a/drivers/net/wireless/quantenna/qtnfmac/commands.c b/drivers/net/wireless/quantenna/qtnfmac/commands.c index f5bc43b..59ca6ca 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/commands.c +++ b/drivers/net/wireless/quantenna/qtnfmac/commands.c @@ -256,8 +256,6 @@ int qtnf_cmd_send_config_ap(struct qtnf_vif *vif, goto out; } - vif->bss_status |= QTNF_STATE_AP_CONFIG; - out: qtnf_bus_unlock(vif->mac->bus); return ret; @@ -290,7 +288,6 @@ int qtnf_cmd_send_stop_ap(struct qtnf_vif *vif) } vif->bss_status &= ~QTNF_STATE_AP_START; - vif->bss_status &= ~QTNF_STATE_AP_CONFIG; netif_carrier_off(vif->netdev); diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.h b/drivers/net/wireless/quantenna/qtnfmac/core.h index 2cd0150..f8165a7 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/core.h +++ b/drivers/net/wireless/quantenna/qtnfmac/core.h @@ -52,7 +52,6 @@ #define QTNF_DEF_WDOG_TIMEOUT 5 #define QTNF_TX_TIMEOUT_TRSHLD 100 -#define QTNF_STATE_AP_CONFIG BIT(2) #define QTNF_STATE_AP_START BIT(1) extern const struct net_device_ops qtnf_netdev_ops;