From patchwork Thu Nov 9 07:19:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 10050303 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D0BA0603FF for ; Thu, 9 Nov 2017 07:23:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C025C2AA95 for ; Thu, 9 Nov 2017 07:23:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B4C622AB63; Thu, 9 Nov 2017 07:23:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B419E2AB5E for ; Thu, 9 Nov 2017 07:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbdKIHWb (ORCPT ); Thu, 9 Nov 2017 02:22:31 -0500 Received: from mail.toke.dk ([52.28.52.200]:47271 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbdKIHUl (ORCPT ); Thu, 9 Nov 2017 02:20:41 -0500 From: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1510212038; bh=GdirzoM787xlTBPJaL4FfAawGNXF02TSRVhUgzvmFuE=; h=From:To:Cc:Subject:Date:From; b=BmLjXuIuRqDNYwgQmprKvAb2lpnFp1w+yug9hubkAD1OM9XifCgjEN7bht3erCmed Ojl8MDKPZa74lpGNLQR7Dt9g7vGJjC1UZhrz+S474OJpUUAbbkQw+cg0am425POn4Z BZqLbBW1aQIlofbw4ptBABnqnHwbRU+doUt2Few1rKs3+0zrYy1nZqea8TrhTEq676 aJi0kgrPxuQs53F/jlLuWJ8/D25U+Qzmhj7hn5bvp0LbxRKHfhlMvVPH4Ti/X3TTMV 6x/Oh4LCrgissnLA6GNsWimRzppTrMyT5EbgSf0xMiRUD/LrRyMHa36Bb2hEYCpRso Y2KlvErcTFr+Q== To: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org Cc: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Subject: [PATCH] ath10k: Re-enable TXQs for all devices Date: Thu, 9 Nov 2017 16:19:45 +0900 Message-Id: <20171109071945.11033-1-toke@toke.dk> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the mac80211 TXQs for some devices because of a theoretical throughput regression. We have not seen this regression for a while now, so it should be safe to re-enable TXQs. Signed-off-by: Toke Høiland-Jørgensen --- This has been in LEDE trunk for a couple of months now with good results. drivers/net/wireless/ath/ath10k/mac.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 0a947eef348d..ca596ecd2d64 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -8329,15 +8329,6 @@ int ath10k_mac_register(struct ath10k *ar) ath10k_warn(ar, "failed to initialise DFS pattern detector\n"); } - /* Current wake_tx_queue implementation imposes a significant - * performance penalty in some setups. The tx scheduling code needs - * more work anyway so disable the wake_tx_queue unless firmware - * supports the pull-push mechanism. - */ - if (!test_bit(ATH10K_FW_FEATURE_PEER_FLOW_CONTROL, - ar->running_fw->fw_file.fw_features)) - ar->ops->wake_tx_queue = NULL; - ret = ath10k_mac_init_rd(ar); if (ret) { ath10k_err(ar, "failed to derive regdom: %d\n", ret);