From patchwork Mon Dec 18 15:21:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 10120081 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A097660390 for ; Mon, 18 Dec 2017 15:21:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 924B628E31 for ; Mon, 18 Dec 2017 15:21:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8465C28E40; Mon, 18 Dec 2017 15:21:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A17FB28E35 for ; Mon, 18 Dec 2017 15:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759308AbdLRPVu (ORCPT ); Mon, 18 Dec 2017 10:21:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59222 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbdLRPVp (ORCPT ); Mon, 18 Dec 2017 10:21:45 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1D3C73B738; Mon, 18 Dec 2017 15:21:45 +0000 (UTC) Received: from localhost (ovpn-204-204.brq.redhat.com [10.40.204.204]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A5AA600C0; Mon, 18 Dec 2017 15:21:44 +0000 (UTC) Date: Mon, 18 Dec 2017 16:21:43 +0100 From: Stanislaw Gruszka To: Enrico Mioso Cc: linux-wireless@vger.kernel.org, Johannes Berg , Daniel Golle , Arnd Bergmann , John Crispin , nbd@nbd.name Subject: Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...? Message-ID: <20171218152142.GA15414@redhat.com> References: <20171213152017.GA3554@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 18 Dec 2017 15:21:45 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi On Sat, Dec 16, 2017 at 07:33:47PM +0100, Enrico Mioso wrote: > I tested the Archer MR200 device removing the patch as you suggested: > package/kernel/mac80211/patches/600-23-rt2x00-rt2800mmio-add-a-workaround-for-spurious-TX_F.patch > ... the error still appears, but the driver is still working as of now. > Here - reporting my dmesg > [ 819.060392] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2 > [ 819.069900] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2 Did you also apply patch attached in my previous email ? Another thing to try to stop those errors is increase queue threshold, see below patch > For the moment I am not sure about the situation still, so I think further testing would be needed. Hoping someone experiencing this problem can come up and give some more hints / tests on different hw. > Thank you to all,kA I'm testing on AP mode but on USB devices, I do not have those problems. Cheers Stanislaw Tested-by: Enrico Mioso diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c index a2c1ca5c76d1..9e65b8f285e9 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c @@ -1224,7 +1224,7 @@ static void rt2x00queue_init(struct rt2x00_dev *rt2x00dev, rt2x00dev->ops->queue_init(queue); - queue->threshold = DIV_ROUND_UP(queue->limit, 10); + queue->threshold = DIV_ROUND_UP(queue->limit, 8); } int rt2x00queue_allocate(struct rt2x00_dev *rt2x00dev)