From patchwork Fri Feb 9 13:24:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10208979 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 96F0A60245 for ; Fri, 9 Feb 2018 13:26:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 85A072985C for ; Fri, 9 Feb 2018 13:26:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A7DB2985F; Fri, 9 Feb 2018 13:26:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CC782985C for ; Fri, 9 Feb 2018 13:26:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbeBINZz (ORCPT ); Fri, 9 Feb 2018 08:25:55 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:39233 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbeBINZw (ORCPT ); Fri, 9 Feb 2018 08:25:52 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0Lhkwb-1f5hvV0wiX-00mvn6; Fri, 09 Feb 2018 14:25:36 +0100 From: Arnd Bergmann To: Ping-Ke Shih Cc: Arnd Bergmann , Kalle Valo , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtlwifi: rtl8192cu: remove pointless memcpy Date: Fri, 9 Feb 2018 14:24:41 +0100 Message-Id: <20180209132531.2755482-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:RWBl3G8cH5p9u51X2ua0AkG1ltzUmI6b0tqV4YZ8t7HUck+ryPp CqPiaYJLbOXErZhien9xzrPJs1rKimHDChtW6Pptj5uaqs6UbenlR2Vw6XZT5WUagGgFd0z S5hJAzYajRe7LqTlSZ958RbtkjBlAR/OkUTVtQx8iJQBb+ruzwSEleELy67VcUma1NvCMBg K5A1w77cJnW4ezvFn3IWw== X-UI-Out-Filterresults: notjunk:1; V01:K0:iOmuxAw0i2A=:whEsezpDFz/1pd+SnDJgG2 /D8pKk59JIdzRqpOwYXvDbQjTG27nH7Wn8FXRrh5RJqGoXBdPLRAQEa98AhSQtlfRQRWv800C tdLIygKFuIy5uyO9SoWe3p3tFG1PtnFUAXG4XGeW8YMAmZhZz5932dOvH1Wk8iZRYOptyOhQW o1dvXic4JVL9pv9kiI1qObfmT9pd96/2svqTVOoCYCTHqE9Dgz7Fpd6w5vKWNnFJ1uSdSorIY xcMhYXRnUmB5m0+xqDHlSpT53ib8sv82kbMpqW9vmqTndNB+D9bj2X6BktaoNd7tnG8WRPUav 3bW/pCcf3XCiydzzfEWEmhVlS/lV5DmKkGRxFljC44YZ51pHKb9dpMMTstiVskrLYX0s/5WXQ /cj2UKSCvSg/ouUWHTPz78YK1G4ZKUUce4zIau76K60wy9b349nfZErZfnkCabjnCcxRt/fLy URN8/bb9iCOe8ptCbHXJDL9eHZUWHHiKKkiSM7JEuO46dbylhIWI5gonQOc+U2auReKUGOdd0 F0tDxv0TfnEXYb2kMRXSzG+HtEHedBsDojfU0hd5klfxODU2vOjqcsiNHEGqwOwTZ4wiSP0rN MujyqujgtOXZOiZefcs4oOLo+ueOz9fOQviy822w4xjYOX7xxBwmcJu875VUuUDauuz7JFVlv Lx8wpLsDT4XYQZgLp9G++rN1aiOD2PkVHbvWrijEnkitmUaifjH6/3kWmXAvWCdGHDVPxUbDp RHEu9AKKZmLoSkO2+QW5Mxx/TCee1CqeHnrlwQ== Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP gcc-8 points out that source and destination of the memcpy() are always the same pointer, so the effect of memcpy() is undefined here (its arguments must not overlap): drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In function '_rtl_rx_process': drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:430:2: error: 'memcpy' source argument is the same as destination [-Werror=restrict] Most likely this is harmless, but it's easy to just remove the line and get rid of the warning. Signed-off-by: Arnd Bergmann Acked-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c index ac4a82de40c7..9ab56827124e 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c @@ -427,7 +427,6 @@ static void _rtl_rx_process(struct ieee80211_hw *hw, struct sk_buff *skb) (u32)hdr->addr1[0], (u32)hdr->addr1[1], (u32)hdr->addr1[2], (u32)hdr->addr1[3], (u32)hdr->addr1[4], (u32)hdr->addr1[5]); - memcpy(IEEE80211_SKB_RXCB(skb), rx_status, sizeof(*rx_status)); ieee80211_rx(hw, skb); }