From patchwork Mon Apr 2 02:04:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 10319407 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5D0F860247 for ; Mon, 2 Apr 2018 02:04:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4DAF428DBE for ; Mon, 2 Apr 2018 02:04:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4118328DC1; Mon, 2 Apr 2018 02:04:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E942128DBE for ; Mon, 2 Apr 2018 02:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754078AbeDBCEV (ORCPT ); Sun, 1 Apr 2018 22:04:21 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:46562 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754036AbeDBCET (ORCPT ); Sun, 1 Apr 2018 22:04:19 -0400 Received: by mail-pf0-f193.google.com with SMTP id h69so8522399pfe.13; Sun, 01 Apr 2018 19:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wxWlprmmS9k87Vtkj6xkFbxHmSGUJG1EgoZ8lry/Ud0=; b=fgLjf8kCbHcZaaykp4loOyJ09+yXFzQffLKxG6K1LusRaq2/SVkzHNTTk2WxodLAqi JBzu1MuemAXgJq1bInzGPlARiPckehIAuiRnofWR+Arf6/PI+UccdlAPFaQFuOK0g63O 2/GZIrK5zL8mB9+NF7HnCAOrDSV/5BfPoyfVgYOymw0C6Hc3ApaCxHfUOyrvGAoEaIEX H3+vjLxntSAbN7p30QjqfazKSRUU0r7nhqkSx/OYCCE88Falwm2YI8/Jy83Bdrn/KXtM YG/wbwPzl4KiPSTaoMykdSiK3/CHHk5fIUef5Lf8Y5UBBKjfpEmenrRCtXreqCNCQijz 4jzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wxWlprmmS9k87Vtkj6xkFbxHmSGUJG1EgoZ8lry/Ud0=; b=nY+S5XJLumsm1KE4tpggngqsad2TPWYpxT7SwCW0TLkmVKCg49NhMuH5ZeTTaUGnLT W9FGiUHVN19/xWZJMPL9CgpZ+0uej3XFmHuzHrGP8m0FSTiepJiR7ALhuAWhfnqP6kxa Qmh86FhJ7oV0qjx+f/bFjCk1sABW25HoE02JRXXmjR1d28eGZ3DYKyJ3eX6YHot+xjY5 75ycAcVSWbmwpPXFzQNiqkRehSizLM4t1kCRQd0bJKcq9CrOo23LTXXCKVV3nUKk1Ro/ Vo7caKREVnkxsYn9bcDLKZimN8kt2VTNwk/aa8DyMWbZiyU1/1v3NWWaHfkLL00KANYy adqg== X-Gm-Message-State: AElRT7HPJxA1svd51B04gqsbN/q+TseOAYTdbsfYVeGZ6a9GJO4FB4or n6TIu4l6SwC0EXjJzZXPUUs= X-Google-Smtp-Source: AIpwx48+0sDY1ByDnYvP6DVwS0EeeD0VpMtyM9+HdzhJcMbErdLxDc59cgy2/BpWtOerkq8R8zzSZw== X-Received: by 10.98.87.193 with SMTP id i62mr53098pfj.219.1522634659220; Sun, 01 Apr 2018 19:04:19 -0700 (PDT) Received: from localhost ([175.223.19.139]) by smtp.gmail.com with ESMTPSA id s4sm22345916pgp.29.2018.04.01.19.04.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Apr 2018 19:04:18 -0700 (PDT) Date: Mon, 2 Apr 2018 11:04:13 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Dmitry Vyukov , syzbot , LKML , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , syzkaller-bugs@googlegroups.com, Samuel Ortiz , David Miller , linux-wireless@vger.kernel.org, netdev Subject: Re: INFO: rcu detected stall in vprintk_func Message-ID: <20180402020413.GD3795@jagdpanzerIV> References: <001a113fe6c0a6ec650568c7384f@google.com> <20180402015422.GA3795@jagdpanzerIV> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180402015422.GA3795@jagdpanzerIV> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On (04/02/18 10:54), Sergey Senozhatsky wrote: > > > If you forward the report, please keep this part and the footer. > > > > > > llcp: nfc_llcp_send_ui_frame: Could not allocate PDU > > > llcp: nfc_llcp_send_ui_frame: Could not allocate PDU > > > llcp: nfc_llcp_send_ui_frame: Could not allocate PDU > > > llcp: nfc_llcp_send_ui_frame: Could not allocate PDU [..] > diff --git a/net/nfc/llcp_core.c b/net/nfc/llcp_core.c > index ef4026a23e80..a309a27581da 100644 > --- a/net/nfc/llcp_core.c > +++ b/net/nfc/llcp_core.c > @@ -1386,7 +1386,7 @@ static void nfc_llcp_recv_agf(struct nfc_llcp_local *local, struct sk_buff *skb) > > new_skb = nfc_alloc_recv_skb(pdu_len, GFP_KERNEL); > if (new_skb == NULL) { > - pr_err("Could not allocate PDU\n"); > + pr_err_ratelimited("Could not allocate PDU\n"); > return; > } And of course I ended up patching the wrong function... What I actually meant was: diff --git a/net/nfc/llcp_commands.c b/net/nfc/llcp_commands.c index 2ceefa183cee..2f3becb709b8 100644 --- a/net/nfc/llcp_commands.c +++ b/net/nfc/llcp_commands.c @@ -755,7 +755,7 @@ int nfc_llcp_send_ui_frame(struct nfc_llcp_sock *sock, u8 ssap, u8 dsap, pdu = nfc_alloc_send_skb(sock->dev, &sock->sk, MSG_DONTWAIT, frag_len + LLCP_HEADER_SIZE, &err); if (pdu == NULL) { - pr_err("Could not allocate PDU\n"); + pr_err_ratelimited("Could not allocate PDU\n"); continue; }