From patchwork Tue Apr 24 13:18:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 10359851 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9174A601BE for ; Tue, 24 Apr 2018 13:28:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 848FA28A5B for ; Tue, 24 Apr 2018 13:28:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 792DC28DA4; Tue, 24 Apr 2018 13:28:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 170F828A5B for ; Tue, 24 Apr 2018 13:28:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934019AbeDXNSS (ORCPT ); Tue, 24 Apr 2018 09:18:18 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:54884 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933839AbeDXNSN (ORCPT ); Tue, 24 Apr 2018 09:18:13 -0400 Received: by mail-wm0-f65.google.com with SMTP id f6so908362wmc.4; Tue, 24 Apr 2018 06:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=dnm1Lhl2Dd7FZQ5+uE/5A3XfJgEDMtBPxwzIZkg5d9Q=; b=DudTNrr/npoaxpQimYfQmhgHAakdiKmkJSV0n9QqjR5G84iCR2hGzJSQpZdc/bJ5eF 0ARuFrxk/twkmzI9zNXFUiykOZzm6TVH/Q14RgJg76sQkWyIYz2dvDXyo+E1DQbpnNb6 GZ57yxxWOutJDoh9/cF2uiVy8yhnroW4PzCywGLsvDH+M4CPwVtbDxmyuRtaV7GEU73J BZ/rVYJIrXdzl5XwM3tL/9svKEJmHUcUtDa4/EpvUyvQTfhlTu9Ryxht+whwICj4V4RU rjStzakRhnIs7vb5NRmhZC3jdVOXuRSYkeozRGZJxwrzzX+lK3rvIFrq3+oQ1v3THxk0 AO8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dnm1Lhl2Dd7FZQ5+uE/5A3XfJgEDMtBPxwzIZkg5d9Q=; b=lWYth71hAltS/LyLEnTS0i5dqpNv3xfdMEjsJ0F7sogBgCnm3wzIjUaCIK4Oyliz7s rFIyVaGZn1leJ+jSIpJjfzmLjSOwJfqQHpxzdPFkOmeHzWVhhXFRMfxlinD24WmLF8Vw HIZ0wIW6ALLIWdGTOpuKdA5hy08jdQDoTj0a6FxzjjP/1LgAwPUU3D77xNEmTMb7Y1ic XQX5YCToEgNn4B/WtmsyUYCQ2I03J6KTij/30oDV+b3XvtuUrMooLs6HxhqKLjj+4d3S x0Y91G/TZgDc416ga3kR4c+T32LxuEvipgspWfZ0v4c5Ql138K61VCtboiiYoEUhG0LJ LmQA== X-Gm-Message-State: ALQs6tC39t1gMCjCOOmFH/PMKkBY8NQkpGtx1l8zOSBOPztQHGAFw5HA uOw3BAS/hV8f36yeHbvQrqlef8syjB4= X-Google-Smtp-Source: AIpwx4+0E9ZCbwl/Qkor/rrDNQWcLBcpBCVzod67x5ZtE3aVbdZXiqtNn9DwckP1ito+l5WRFzMw8w== X-Received: by 10.80.161.165 with SMTP id 34mr27547430edk.273.1524575891470; Tue, 24 Apr 2018 06:18:11 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id t1sm1455526edq.84.2018.04.24.06.18.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:18:11 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , Igor Mitsyanko , Avinash Patil , Sergey Matyukevich , Kalle Valo , Vasily Ulyanov , Kees Cook , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type Date: Tue, 24 Apr 2018 15:18:04 +0200 Message-Id: <20180424131810.4963-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck Reviewed-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c b/drivers/net/wireless/quantenna/qtnfmac/core.c index cf26c15a8..b3bfb4faa 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/core.c +++ b/drivers/net/wireless/quantenna/qtnfmac/core.c @@ -76,7 +76,7 @@ static int qtnf_netdev_close(struct net_device *ndev) /* Netdev handler for data transmission. */ -static int +static netdev_tx_t qtnf_netdev_hard_start_xmit(struct sk_buff *skb, struct net_device *ndev) { struct qtnf_vif *vif;