From patchwork Wed May 9 16:42:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 10390053 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0416660318 for ; Wed, 9 May 2018 16:42:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E617327528 for ; Wed, 9 May 2018 16:42:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D777F28604; Wed, 9 May 2018 16:42:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, URIBL_BLACK autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2BD9827528 for ; Wed, 9 May 2018 16:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965580AbeEIQmx (ORCPT ); Wed, 9 May 2018 12:42:53 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:39969 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935232AbeEIQmw (ORCPT ); Wed, 9 May 2018 12:42:52 -0400 Received: by mail-oi0-f65.google.com with SMTP id c203-v6so32077831oib.7 for ; Wed, 09 May 2018 09:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p1n7r1p9mHgbKyRz315WF43T3kFsGDml7yREJ0rqMIQ=; b=f+2+ivntB+uZSm9QCmH4atC9LEZ8ABesPwiKSAbHSwVS2jlJXNCP/1sa9dxeo6YfV7 GlJMBDPXQ79MyuZUt2mDtHYdnoB1tax3Qj2BRjVdOFJQX9NOxKhX1kPDcvCRLaxB0+pq asorpRRZJBABbeS6rOd4eXhCZwvV8gTZ64mcZ6UgCxk7qj1qLx48E5On0RnTcnSX70+r FxWzTgPesV3VhOs7aymkAG6nPY8ZGQb1Fa3pbvNS739cz9zF1ZoR0CJ43HJjzKiqwhJk zTFVNjGMg47suP9VNW7hVPZPYme8106FU+JF2r5YYmuz4Fw7qN93w9t6FNaA4+cAA/Po ziHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=p1n7r1p9mHgbKyRz315WF43T3kFsGDml7yREJ0rqMIQ=; b=n/BpFPh+mzw4GdHLREUa5HJSm1cWq/99U8j8s6vsSynYTASjq1erasBqLMKq0cWR78 StFqCw9Q8+JHd29ZmPnaAIGOzn4mgBAPaG9+2Kpv809uaDWU9bCMAfzi8ShTVlXrE2wM VNszp574K8X4VOosC8QPHxk4/K1pFdri1y1/FXcEt6pvpKDww51JKLexfDsaevut4r1B qFWtoyjPo9RwvMy6cpN5hHLGyfd56F6EmTIfDB5k8xECvha5YNN9zv11aYnoS4dXKz1/ vWOKdqZAxatfcwnCGN+lB+Mh9JpGhBaOnkP1dLieC62fy+fIIwSOmdKrssMK965h1oQi 49jA== X-Gm-Message-State: ALQs6tD28RhcM1IAlzNL0ONCFoNLuRWkKjpUnyAYuKESvYfZT8fa3ok4 7pqPw5xQ2NKy4L9PzT04hh8= X-Google-Smtp-Source: AB8JxZoqtfOkxOnDYWD1B9zBVL+9EL6hn6F6QJledyiSX+JunVvdNwAJmQahzgW/ZwPMqEBgUjolWQ== X-Received: by 2002:aca:ed15:: with SMTP id l21-v6mr29977360oih.39.1525884171393; Wed, 09 May 2018 09:42:51 -0700 (PDT) Received: from Larrylap.localdomain (cpe-24-31-253-228.kc.res.rr.com. [24.31.253.228]) by smtp.gmail.com with ESMTPSA id 14-v6sm7917834oth.15.2018.05.09.09.42.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 09:42:50 -0700 (PDT) From: Larry Finger To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Larry Finger , =?UTF-8?q?Michael=20B=C3=BCsch?= Subject: [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture Date: Wed, 9 May 2018 11:42:20 -0500 Message-Id: <20180509164220.22653-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.16.3 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some MPIS-based SoCs use chips driven by b43 for wireless capability. When ssb is configured as a module, build errors happen on these platforms as described in the commit 882164a4a928 ("ssb: Prevent build of PCI host features in module"). Unfortunately that change leads to the removal of code needed for correct operation on platforms that use PCI cores on the chip bus. The fix allows ssb to be build as a module for all architectures other than MIPS. This approach is ad-hoc, but it is the same as done in commit a9e6d44ddecc ("ssb: Do not disable PCI host on non-Mips"). This problem was reported and discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1572349. Fixes: commit 882164a4a928 ("ssb: Prevent build of PCI host features in module") Tested-by: Matt Redfearn Tested-by: Bruno Wolff III Cc: Michael Büsch Signed-off-by: Larry Finger --- Kalle, This patch fixes the regression in 4.17 that was discussed on the wireless mailing list. I'm not really happy about the ad-hoc rejection of ssb as a module only on MIPS; however, that seems to be a unique implementation of this hardware. Larry Michael, Although I think your version of the patch is superior, this is the one that Matt tested, thus I'm submitting this version. Larry --- drivers/ssb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index 9371651d8017..3743533c8057 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -117,7 +117,7 @@ config SSB_SERIAL config SSB_DRIVER_PCICORE_POSSIBLE bool - depends on SSB_PCIHOST && SSB = y + depends on SSB_PCIHOST && (SSB = y || !MIPS) default y config SSB_DRIVER_PCICORE