From patchwork Mon May 21 15:31:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Denis Kenzior X-Patchwork-Id: 10415653 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4B2316053B for ; Mon, 21 May 2018 15:31:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3929728950 for ; Mon, 21 May 2018 15:31:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3732628991; Mon, 21 May 2018 15:31:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF17A289F9 for ; Mon, 21 May 2018 15:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbeEUPbf (ORCPT ); Mon, 21 May 2018 11:31:35 -0400 Received: from mail-ot0-f193.google.com ([74.125.82.193]:43602 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbeEUPbe (ORCPT ); Mon, 21 May 2018 11:31:34 -0400 Received: by mail-ot0-f193.google.com with SMTP id y10-v6so17288013otg.10 for ; Mon, 21 May 2018 08:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nzRpc55pNhqzE7OBIaGpkD3j6BbYixDnJqPj8JyMByQ=; b=gsTqeE6DL3cfPveuLyPepy45++IVqPwvYsfCs9omEn/KYCn35Jg0BmsjK6WOeyupWZ bL0V0gpEnfywXph24ct6w7U5qj+eBR7DJ4aClpKSyT/XuWqT6aKoGJ9zWQkyDiF3+ZC4 74gStOPs7ql14M1yio/vILHt36BewP7NvUO31IpPN7LYI/7NIfTihrqaPvP2ZS/Q81tl NmcuJCJuAWlt5toI5ozuC8ooFIR1JPrut3sIpf5eQfaOAZS0w7z/oenHY6X9rIQSlP+D A99HZ0jmPyIVWyhRPy4kiM67wd6bxiWnPv5HnchVt+TJBqdCG6UZvNSmp+wIIaS7BmxC JgEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nzRpc55pNhqzE7OBIaGpkD3j6BbYixDnJqPj8JyMByQ=; b=Zn9j0WMqEd1Ry/SProGxwmKt8QiiiP7jlAGP4KqLkMTuNOp+WGHb/pcHZm0ZOwDNCI hJRAsFPVVtflSkrZywNOd3B3jrj1cawd4sBDDiK8fO2BB6hnRSb02OTNxshIO9mvK06X /K8+np8Zmy7Fvdr7gndBfldvPl050YhiqI6BKV7UV/FP7vHPx52q+l/dPqp3iEsu4h3F m6RLFFLIYpsJJ9lC7jpqrRF9He1H4FaDf1nlSiy5XHZBJ3O7Mjtyz9w3gcfLs0mIWZXg 6AfDxNRqOPP253iQkioprXQOusX8SB8Qpw+WE6nFB+IgLh1myEkciCyCWntViZpFcWma 2ydQ== X-Gm-Message-State: ALKqPwdn6/xMb/q89hFuNUyWyz+NuUViSokJHEQE4/zgM99g7Tmandgh DZH3rxziPK4ZRVtM8jEYhBFFsg== X-Google-Smtp-Source: AB8JxZqsaa5CbfHjQP6TV3NFfdwA7KuLhO2Mqe2SbYxoxXZ5Ih3U8z2RCCz3TCh/Q2dJ8ox0QwOflQ== X-Received: by 2002:a9d:10e:: with SMTP id 14-v6mr12823297otu.238.1526916693792; Mon, 21 May 2018 08:31:33 -0700 (PDT) Received: from localhost.localdomain (cpe-70-114-247-242.austin.res.rr.com. [70.114.247.242]) by smtp.gmail.com with ESMTPSA id 89-v6sm7830343ote.71.2018.05.21.08.31.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 May 2018 08:31:32 -0700 (PDT) From: Denis Kenzior To: linux-wireless@vger.kernel.org Cc: Denis Kenzior Subject: [PATCH] nl80211: Optimize cfg80211_bss_expire invocations Date: Mon, 21 May 2018 10:31:13 -0500 Message-Id: <20180521153113.8442-1-denkenz@gmail.com> X-Mailer: git-send-email 2.13.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Only invoke cfg80211_bss_expire on the first nl80211_dump_scan invocation to avoid (likely) redundant processing. Signed-off-by: Denis Kenzior --- net/wireless/nl80211.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index ff28f8feeb09..7458cbcf00b2 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -7930,7 +7930,15 @@ static int nl80211_dump_scan(struct sk_buff *skb, struct netlink_callback *cb) wdev_lock(wdev); spin_lock_bh(&rdev->bss_lock); - cfg80211_bss_expire(rdev); + + /* + * dump_scan will be called multiple times to break up the scan results + * into multiple messages. It is unlikely that any more bss-es will be + * expired after the first call, so only call only call this on the + * first dump_scan invocation. + */ + if (start == 0) + cfg80211_bss_expire(rdev); cb->seq = rdev->bss_generation;