From patchwork Sun Jun 3 18:20:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Erik Stromdahl X-Patchwork-Id: 10445521 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 560E360234 for ; Sun, 3 Jun 2018 18:22:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45FB628A4D for ; Sun, 3 Jun 2018 18:22:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3AC3328B1C; Sun, 3 Jun 2018 18:22:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C2C7528A4D for ; Sun, 3 Jun 2018 18:22:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbeFCSWT (ORCPT ); Sun, 3 Jun 2018 14:22:19 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:36846 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751169AbeFCSWN (ORCPT ); Sun, 3 Jun 2018 14:22:13 -0400 Received: by mail-lf0-f66.google.com with SMTP id u4-v6so21784975lff.3 for ; Sun, 03 Jun 2018 11:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VwQgRw8uzEa6v6Rcpcz+empmwaUJXo0GauFaxqY565Y=; b=VzEBglk1PbHlXlAW0skBgc9fw1mx5wlWGKOBBPT260oO6qz80fIuJjy7de6q3R6iFI uslOw6dMTAHzFCYuS0AmC9AF2sZmWY2Mc+RwqIOko49Op9S0B+98OkMyphv4rajP7qFi u8jyXBo3gfYa4aCmVmr+5soBuT9LLNKpzm+0rpAozEOYPAxLWiLIE9ILaazlXWu/MpN8 TcTCr+DRe0aXYBDCiA22bMrzRxSAp4Oqk/Prn3v3dknMRdYCrxkb9PzzeoGhwWm+86Hs RR8NDf/oxtDnRENkNUPFNaotJ1ORPDYaTgTDKu8KaKs0GTLTj1PfJH2B8WuAUswY1vIt 9fxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VwQgRw8uzEa6v6Rcpcz+empmwaUJXo0GauFaxqY565Y=; b=syL5qCqbhYkhe/TxY1z7v4xZufwdFV1vbC2YFdYDoSx5jAeTcDJBCXjqnd9CrfS1+r Wh/H214nTCOQzKNu5pFPqVAizk/OriC2QVeihX4uvYfu7WhTLxanp5cw0C4dl26Uqivq C94L2dJ8cQ/3Vi5ptp0n74bqQYZSjZVf7t/eQcztBJB5a1zGZc0VjianS26Xz+ucEak/ 6oFOThXrvB7A2NxYlDPmyfi/VmPauJ7MuwdynwfChrmtnxlxC7U3dlmEPbtVQXcFc6PA ZMpAvGPzeX4I4olWF7HkN+JIKL5XBizHBmJRgFo/11KIQjGI2wkxorESlEmWvdKA2yH9 nLrw== X-Gm-Message-State: ALKqPwfacetzsW5lD/wyy17WBc6oeAhtjAn47GHQ0IsEYcYKlUn4Rn54 T8uK4Rp0cqhwuKU7VKYEqJI= X-Google-Smtp-Source: ADUXVKIp8tMZb6hTdCdnOlQ4w8yGXDVLlNrMnHOc5mgQGyZfMEYlVc+BrtSVpAoYqZkn8qeWwYcSmw== X-Received: by 2002:a2e:9e57:: with SMTP id g23-v6mr9850723ljk.37.1528050132162; Sun, 03 Jun 2018 11:22:12 -0700 (PDT) Received: from localhost.localdomain (90-227-62-61-no75.tbcn.telia.com. [90.227.62.61]) by smtp.gmail.com with ESMTPSA id l200-v6sm4980562lfe.77.2018.06.03.11.22.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jun 2018 11:22:11 -0700 (PDT) From: Erik Stromdahl To: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Cc: Erik Stromdahl Subject: [RFC v5 04/12] ath10k: use hw_params.num_peers for num_tids in TLV init Date: Sun, 3 Jun 2018 20:20:21 +0200 Message-Id: <20180603182029.8914-5-erik.stromdahl@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180603182029.8914-1-erik.stromdahl@gmail.com> References: <20180603182029.8914-1-erik.stromdahl@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As TARGET_TLV_NUM_TIDS is calculated like this: #define TARGET_TLV_NUM_TIDS ((TARGET_TLV_NUM_PEERS) * 2) ... it is better to use the per device hw_params.num_peers value in the TLV init message (if set), rather than using a hard coded value. This makes the value used in the TLV init message match the hw_param value. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index 2e34a1fc5ba6..acd2186526b7 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1552,7 +1552,10 @@ static struct sk_buff *ath10k_wmi_tlv_op_gen_init(struct ath10k *ar) } cfg->num_peer_keys = __cpu_to_le32(2); - cfg->num_tids = __cpu_to_le32(TARGET_TLV_NUM_TIDS); + if (ar->hw_params.num_peers) + cfg->num_tids = __cpu_to_le32(ar->hw_params.num_peers * 2); + else + cfg->num_tids = __cpu_to_le32(TARGET_TLV_NUM_TIDS); cfg->tx_chain_mask = __cpu_to_le32(0x7); cfg->rx_chain_mask = __cpu_to_le32(0x7); cfg->rx_timeout_pri[0] = __cpu_to_le32(0x64);