From patchwork Mon Jun 4 12:04:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 10446479 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 66A8460284 for ; Mon, 4 Jun 2018 12:04:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5400828D2D for ; Mon, 4 Jun 2018 12:04:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4899928D36; Mon, 4 Jun 2018 12:04:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E381928D2D for ; Mon, 4 Jun 2018 12:04:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbeFDMEG (ORCPT ); Mon, 4 Jun 2018 08:04:06 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33924 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbeFDMEF (ORCPT ); Mon, 4 Jun 2018 08:04:05 -0400 Received: by mail-lf0-f68.google.com with SMTP id o9-v6so24779038lfk.1 for ; Mon, 04 Jun 2018 05:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9rf0t6GdwcAdDh62MjI65K4BCbBU81dpxqbCRHzhsbc=; b=CbJq3C6DlMTedoiKwaNuVE5v6C+COINBOPZ2dmkMmwxmnn8u1cv04+nyJ/MRExDE68 Oj0VS/Z1vMK0CA3AAt+UTsww0CxZg+rHAuBLuXSoyvURExlzZhnMVulAtLeFYpdch2gV 9XYRDhpHguizbLLpH5X2lLKPskdkdJUvtHhYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9rf0t6GdwcAdDh62MjI65K4BCbBU81dpxqbCRHzhsbc=; b=Pv/szN6fNcskdvCXrbbZKc4EszJuW30DXD2LA8+m+cNxi4rPvzy5CR62YUfkkbcdrd NkzeBVFjy6NXk4Y6A6tp49oRhVV+v1bS70uFfPI+7mlVQgGCMQv5TQ0kF2WHpt7M/wHf s0CA3uD4cmpFHJBDV5f9FSyrHKinXjlo19AArNVkIWRI6ifDskXcUX+TFP8yl52/8zw7 KFGLWV0n6opqnnFUIlg4mSaqenGfWS9TyN2bryc/m1+7ZWK7MxnQ8CyeIyernxjKYlFZ +EPamHgPuxWgB73Jn4BLiqvU+wn9Cp+2ipvowNBkQX+9YMjXKhaA/BTOqSaQV4KNZL/n BsHw== X-Gm-Message-State: APt69E1xCtUd8XgI9u6QxgX3DtO4o3Z7gxLfxU2zjBgAUh25bSmoYv5u RAdcri17cscxow84gZ/bTcp6Jg== X-Google-Smtp-Source: ADUXVKJWfnT5P9gtOlrHp2w1QmHsnN4U0CCV08cRhuXahAUKqtvH0rbm7EXGbR+IqZTtxdcGqvgC2w== X-Received: by 2002:a2e:5818:: with SMTP id m24-v6mr1077630ljb.84.1528113843805; Mon, 04 Jun 2018 05:04:03 -0700 (PDT) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id d5-v6sm10403346lfg.65.2018.06.04.05.04.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 05:04:03 -0700 (PDT) Date: Mon, 4 Jun 2018 14:04:00 +0200 From: Niklas Cassel To: Kalle Valo Cc: Wei Yongjun , kernel-janitors@vger.kernel.org, Govind Singh , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, bjorn.andersson@linaro.org Subject: Re: [PATCH net-next] ath10k: make some functions static Message-ID: <20180604120400.GA6240@centauri.lan> References: <1527733994-149212-1-git-send-email-weiyongjun1@huawei.com> <87a7sazw0w.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87a7sazw0w.fsf@kamboji.qca.qualcomm.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jun 04, 2018 at 01:27:43PM +0300, Kalle Valo wrote: > Wei Yongjun writes: > > > Fixes the following sparse warnings: > > > > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning: > > symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static? > > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning: > > symbol 'ath10k_snoc_init_napi' was not declared. Should it be static? > > > > Signed-off-by: Wei Yongjun > > BTW this goes to my ath.git tree, not to net-next. > > I had missed these as I can't enable ATH10K_SNOC on x86 and hence I > don't test compile snoc.c at all. Bjorn&Govind, is there a way to solve > that? IIRC we had a similar problem with wcn36xx but I don't remember > anymore how it was fixed. > Perhaps something like: Regards, Niklas > -- > Kalle Valo > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k --- a/drivers/net/wireless/ath/ath10k/Kconfig +++ b/drivers/net/wireless/ath/ath10k/Kconfig @@ -42,7 +42,8 @@ config ATH10K_USB config ATH10K_SNOC tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" - depends on ATH10K && ARCH_QCOM + depends on ATH10K + depends on ARCH_QCOM || COMPILE_TEST ---help--- This module adds support for integrated WCN3990 chip connected to system NOC(SNOC). Currently work in progress and will not