From patchwork Sun Jul 22 14:44:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omer Dagan X-Patchwork-Id: 10539335 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8B89D14BC for ; Sun, 22 Jul 2018 14:45:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7776C28390 for ; Sun, 22 Jul 2018 14:45:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 685E2283A6; Sun, 22 Jul 2018 14:45:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EBC4028390 for ; Sun, 22 Jul 2018 14:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728599AbeGVPmJ (ORCPT ); Sun, 22 Jul 2018 11:42:09 -0400 Received: from mail-eopbgr60135.outbound.protection.outlook.com ([40.107.6.135]:10512 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728351AbeGVPmJ (ORCPT ); Sun, 22 Jul 2018 11:42:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tandemg.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBRpeuHCPmEnS2w8P2T2+68QVZGpeVYvnBWCTX9a32Q=; b=uI32eUk1GZ0yf47IfxsCT2AhkukNm6oU+bBDD3K2CW/4be2TpZQdj715AYIPGt6nW7RrUHEIjOzGVJl7+Ou2AyYHfnn0j4+Yz+O40S0Ic6t7v3zlLxnBGz5bCqphuO+qR1sgGePbkW1Mk4QyO0gHKB1yb8idLzDaXNWB/5FW8Zk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=omer.dagan@tandemg.com; Received: from od-tandem-laptop.tandemg.local (37.142.120.98) by AM6PR02MB3653.eurprd02.prod.outlook.com (2603:10a6:209:2b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Sun, 22 Jul 2018 14:45:08 +0000 From: Omer Dagan To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Omer Dagan Subject: [PATCH] iw: 'idby' might be used uninitialized in main function Date: Sun, 22 Jul 2018 17:44:36 +0300 Message-Id: <20180722144436.10648-1-omer.dagan@tandemg.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [37.142.120.98] X-ClientProxiedBy: HE1PR02CA0116.eurprd02.prod.outlook.com (2603:10a6:7:29::45) To AM6PR02MB3653.eurprd02.prod.outlook.com (2603:10a6:209:2b::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d0c31a3-1d57-4499-970f-08d5efe1b910 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:AM6PR02MB3653; X-Microsoft-Exchange-Diagnostics: 1;AM6PR02MB3653;3:2sz6dM6kx25F06cbYam00zBybI8FcCEXuH6SlAbFpIsXNs0TPospJAR6A9Z+jGOF+guhoMXNBIkSiJleY11zNgKReCGg6Ad4TdQSdv+tFlhVLGK7dS9W+kwFe5ntlbZDWeQFa1Y4w1mmuph7FiKCSd4sV/5PbrPpJa3gomJQ4zDQ2kenoqjkuINiOjU1DskO5Mu4tHPafjKa/McvNMIVhEo4xeeByR5MTUso3nHNHRpTp9TDQOunprwW9nXeEIVC;25:74KJp865b/MA1nCrT5iBxLNeTL3NC2HVHnemXKqx3tfhgHLxDHmePYfHlCW7v3WrEhpIAIFfXLLzKrfAiC4mH2gMOOt2XiBQtFUNcEepmrubVpv4w375q6Ujlef0RPHO09+bUzXWRsBt7pz8ln1FX/MljTKCDv/KmTM8agF6PaZ7NBeQAxnw1Z3ekVvzjc31X6F20wdu1lLCQOCZRqSe18ScCH8/e5tv6soXXPsJEP2gCR5vLQOzXV/gXgEndkt6TVpcHWcQMpaCWLCJGr6HqwPkwsfjiXlMLIYEG1bG+9cO0cdxbjyft0yrQvFv9leWPbq36AQLhsXmceN1PFKPyQ==;31:mDOTgjdDPJl4xQFyufh8SHoMkEd1U3NBfavkMNvLWyk+2GByhChWUBxRPZ+PWxhY74snHoV0x7ard/q2VseyoxbvJGo3h5b957FD4vIcezE4L1PAZTPjcaaCzZ3E0SjDnzlheiSYX7y09BSlVoySDxwWqlSi/tYua0nQ5AQI6eRr+R71u3A+tJJN1WrTy9SokgRTnL31MQbvcsUMYeYA7H+W2C+bXbcfdc6geiFoi8g= X-MS-TrafficTypeDiagnostic: AM6PR02MB3653: X-Microsoft-Exchange-Diagnostics: 1;AM6PR02MB3653;20:Ka5G0V9DWyVYLkPIaWcNglI13XheMouxSwk1b6fa2lTw1zUhuTVrQh0Gi2st/GyNFvQ/To0nbs0boxRrVWUI6kPqO/tOVw8ai9SOSAI0Qb8QceUOfXreAKH1xJ4XKzhbTLzyJxk2zODBUNAMiItdCdbUMfaUfW06LzwsEIzscsxjeFdOhcJp8kqwFB/khDlFdKZ6zdIsI3/mYwIqKAgRWiNvFWOf9tl1CXa4XYRy1hNmfYF96MyD1CR1ChnwA5c9tDh/7i38g5cwDbJjAl/H70OwSQ6vPWNo35WTX1bP79h0cJwh6VvyVblJ4Jz/wlXLslxaE02Bed10IwuUVql9T1a9qIIiymmIga/8KNeoVlesRBt4ozv7UNiNz+U7AY1E8JCPHyYYcOa4JGEXMAuSfWl8rF7HXEvgUR5VabS4q0bTqA3rpjn13K/XRrhM8scFY0QaNI64Jjy8j0X7hrB5Ozx6RlUsny59WHfThFHG9OHdkZrWNcoUlGY6p45sK9Xc;4:L/nt9qi4Mzrzj+Lgt3GTTw+GSdLb5sLO2lHgE9FpyDE6ON3v/jEQS5863lqTAaZ9Hb306SLRH6wq0hXGM7ypFBRnjC76MmVCCdQlfABgXd6TBcbe+mb/FhvS5mEHtn4IirXE2d7FIpOYZH0A1sWAT1tDOUFUDWspF02EGYSUL05s1W9zpye0t3OtxyvFLLu8gMsqPlKdoqqD5MPelezMufTG6cM7clsmYpFB7Hna8QMEIt5atXMcX+u2y5Cb7b9BEKY0SQCOmZ2dKHWFvJ+CHA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016);SRVR:AM6PR02MB3653;BCL:0;PCL:0;RULEID:;SRVR:AM6PR02MB3653; X-Forefront-PRVS: 0741C77572 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(376002)(346002)(396003)(366004)(136003)(39840400004)(189003)(199004)(305945005)(2616005)(105586002)(316002)(1076002)(3846002)(478600001)(2351001)(6116002)(4326008)(6512007)(51416003)(107886003)(16586007)(5660300001)(81156014)(81166006)(7736002)(53936002)(2361001)(52116002)(68736007)(8676002)(44832011)(2906002)(476003)(50226002)(14444005)(106356001)(6666003)(36756003)(6916009)(26005)(956004)(66066001)(97736004)(8936002)(1857600001)(48376002)(50466002)(6506007)(386003)(6486002)(186003)(47776003)(25786009)(86362001)(486006)(16526019);DIR:OUT;SFP:1102;SCL:1;SRVR:AM6PR02MB3653;H:od-tandem-laptop.tandemg.local;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: tandemg.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;AM6PR02MB3653;23:FcdtQBuqXMPIPB2Eh67a0CSLybhErErVvmc5ttbBpr7H+aWynX3YZYFFZJtOm5KDaYduqCzE7dbUd/HgPKpURkP9J0uFX4af5267kmk0YwY4r948nU2ZIQFu/RKfdx/noN/L/PohDoMeQfmAoOutYr7uPCs7/SJ0zx84h0osgKgAw9a8U0bObuxpMZ6vEkOai2x8M1+nz3r8+1AdttHfR7QoIlmxyF/3WerPmQUiDhNj+rZo0UQTbzyCTm5kxDz5dQaI2dyZU2tnZg6lE89hAyWTQNjgIrpGPcy9H2T0Xzpi1sPllNa9ge3GihPnolax+Kj8zIntZ+YqyyIz3uRd5H/Jo9m38A2PXs68ruIixPj2pnW1MblRlcZ+BhYBNe3W+EhbYWy94H36n4gBU1+TQY0egZrmfWounj5WT4s2ntxRg0KJEG8oG6axZ4ILCG+xLlTf67N+MmojgBWtryN1rdk1tTMZYO8s4NYYgjBKBsbTcrjrk3KZTGOYnxcYOGm1Sfmj7oYpCmswTL01Z2l+aOFdqOu6pp+xjd/q/oruBDPct5SJmRh+FsEA5L5HwG0VezOfGUuzoXOvBdgdr98qa+u6nw01uf4HV+14aSWB+ByUxiltLNNM6H6RH63Fbd9FZpjAYZLdBwJTMUugIFSYoqOxY0MyLGxWhgRRxyne5z+KoOfmWH9ZyHTFcNmuSeoozM9cH+OK653wMhesje8X2N+3Vsy1GGMOKVCBJvkO8yOc2W/wza6Oos+4zLg3U9XHZbf7GJY9RZOTBeu00Mh8qhFw3fIb658w/5+vfiFJRJTp4R96MdX4KqjWlfCkgVXHYreoX/3IKOWFLcadr1V6zchydpSo7ei6tSC819/XtGSzOmL0xvzYffN/zL90LL5oCmopC6TsAbrgcf4FdkjXLPah3Ljo3/Re7cWd4gkHlkJNoaDLPGTK5tBuaZspnZBksu8e/QZCKjJaIlZ00FQ0wOogR0QSLDvASHAQGzDQ91MH45MMmSqZKU66Kh7ShNtNteFIbjSTDQ6YPbOU4s/4pfcSLaGm3aw71PUJld87CxalzWOkaz5L6azkUIbLZu05iCfrLlmqhajTtPPExSn5y9pORjr7xF3l7hRKF2BH39ZCpfF5IRz+JYu/BgOAUvdsmnJYLNygO+H8+P8+uqQQ47LXkyHGMoEnoqQO2PzOm1CmGvLESduK3iK+sozmDXcqhVzIhTaolQ35K5kShmXr9obU6r39gHHr0IXtqh9VV3A= X-Microsoft-Antispam-Message-Info: Vlr8OrXdrJlBpngEleNybtQ/knY4GHPvwsrh6U/AXmS13z8sGlMpG55nas3qexV1McQPj7hlb5auGJ0ydivEcvwe2Brf3lzh0l2WHn8x7nUZ+c3gRTDpERU9l1Zf9wTIDFT6apvDFsU3Oa6eNCfKiq3oicgCV6SgCGUmLhlSjaOqjaDpfrfXM7V0xt8/tEL83/ImGNlb+TiXFRKfzguprYyP20HiXCwZPWrfbBTrkUsbyDEd7zyscJu9qRWFcCe9SX68ptBC0FdFTN+54UO7Z7GY5oB+7psoiO7maRCe7kJx9vEqPidNwdyEfyIvDkeMfgohs1+puBOM5bfrdiLg5bm5BIVLj5IY+Vdfr3FUyEE= X-Microsoft-Exchange-Diagnostics: 1;AM6PR02MB3653;6:hkjb3/mak/gRvb67DtgWz7xrVZ0oMGJngW5HgrAOglvF2vXXy3ojzHiidKt6mPAzXl2ugHIXhcCHeyCC57rxz0JAHYvem17wRa/jOJtXJ5ufgrukopY9Il0ZbLYOQenJyipyW3R5LJRk0a2+rRMXvwc1D60Je2cZIX8/aQ9aLI6awQ2Tba/J/zQRlp0jz9Pl529SjTL/JkIbVpqQseBbl45in0oi7LyM6jqG/PHAMiP8dc3xhE3n81/Wp2mDW1VIYNgEB07Hg138QmwIFbLGNUu5TvH0T3uP275CEdotTSlZnXywzpugYCAu40vlYSocvdSgITV8tgyPSvTfGW4oSRDfXFPAuPQyCh2wmUfnw9Kpns68hoqBSdZ111vnnQrbNSYk4TUOurIEUuMW+dISx2BXhG9QM/CD9mScVoUUotoIcL04RldZDmQgAWo4nQ06a/WDZcjeHidxdzpStQZB2A==;5:2VjEeyEHM0llGTUg9YJDEuCujbTvbJwyVXQmzLhfpYWSxi3sNueJ3L7a8RUVgneW7nodfYxR1LkLg6sKVKAv3U5YpuzLeDVr639djD5EbKt4ccLNRVwuK5TXuVNFi6ChQAEJ/GWBP5m5xj4HwwDm++0ZEcFcLOwAhq+6Mj2BR7I=;7:TZNn/W1jJeVvbDicd/XSOf/BDSuqZa2LU3bJUv2hL/Nn1dzArhzPqeOawXJjKRmfXW4susdAuQRXvbT0hZz8mE1jhcOWwxPE9Kkz/Z3ikPoKk6P4vzLchCccqmy4v1HVJ0nq2IT+3I9k1IcEdQXjo+5MjCBcWY2pRVpPdU1iSxqyzfueSd/WXy/gK/vc67jRhyWdrhar3E2rUNG1ovAfAj+dJ3xQVP01liHHVkmcUAhxfpSPny3WxsqnHT7lpw65 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: tandemg.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2018 14:45:08.7783 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d0c31a3-1d57-4499-970f-08d5efe1b910 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d690b55a-f04a-454b-9f62-fb1e25467a25 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR02MB3653 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP During static-analysis of the code, a message appeared stating that 'idby' enum might be used un-initialized. It described a case in which the 'goto detect' statment occurred and that means that the enum initialiaztion will be skipped The change puts the declaration of the 'idx' var and the enum at the start of the main function and resets the enum value at the original location in-order to maintain the current flow Signed-off-by: Omer Dagan --- iw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/iw.c b/iw.c index daa2a77..558cc9c 100644 --- a/iw.c +++ b/iw.c @@ -547,6 +547,8 @@ int main(int argc, char **argv) struct nl80211_state nlstate; int err; const struct cmd *cmd = NULL; + int idx; + enum id_input idby = II_NONE; /* calculate command size including padding */ cmd_size = labs((long)&__section_set - (long)&__section_get); @@ -593,8 +595,7 @@ int main(int argc, char **argv) argv++; err = __handle_cmd(&nlstate, II_WDEV, argc, argv, &cmd); } else { - int idx; - enum id_input idby = II_NONE; + idby = II_NONE; detect: if ((idx = if_nametoindex(argv[0])) != 0) idby = II_NETDEV;