| Message ID | 20180916095935.GA4388@amd (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Luca Coelho |
| Headers | show |
| Series | fix iwlwifi on old cards in v4.19 was Re: 4.19-rc[23] iwlwifi: BUG in swiotlb | expand |
> > > .max_tfd_queue_size was ommited for old cards, leading to oops in swiotlb. > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > I picked it up in our tree with minor commit message fixes. I also added the Fixes tag for stable. Thanks!
> > > > > > > .max_tfd_queue_size was ommited for old cards, leading to oops in > swiotlb. > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > I picked it up in our tree with minor commit message fixes. > I also added the Fixes tag for stable. > Ah, of course... not needed... Sorry...
On Sun 2018-09-16 10:14:22, Grumbach, Emmanuel wrote: > > > > > > > > > > > .max_tfd_queue_size was ommited for old cards, leading to oops in > > swiotlb. > > > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > > > > I picked it up in our tree with minor commit message fixes. > > I also added the Fixes tag for stable. > > Ah, of course... not needed... Sorry... That was quick, thanks! Ouch, and I should mention... I'm not sure 256 is right value to use. I just... guessed so based on the other files :-). Pavel
On 9/16/18 2:59 AM, Pavel Machek wrote: > > .max_tfd_queue_size was ommited for old cards, leading to oops in > swiotlb. > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > Hi, Thanks. Works for me. Tested-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> PS: I started the b-word yesterday but my old laptop is slow... > --- linux/drivers/net/wireless/intel/iwlwifi/cfg/1000.c 2018-09-05 13:12:40.453164067 +0200 > +++ linux-64/drivers/net/wireless/intel/iwlwifi/cfg/1000.c 2018-09-16 11:54:04.010970756 +0200 > @@ -51,6 +51,7 @@ > > static const struct iwl_base_params iwl1000_base_params = { > .num_of_queues = IWLAGN_NUM_QUEUES, > + .max_tfd_queue_size = 256, > .eeprom_size = OTP_LOW_IMAGE_SIZE, > .pll_cfg = true, > .max_ll_items = OTP_MAX_LL_ITEMS_1000, > >
On 9/16/18 3:12 AM, Grumbach, Emmanuel wrote: >> >> >> .max_tfd_queue_size was ommited for old cards, leading to oops in swiotlb. >> >> Signed-off-by: Pavel Machek <pavel@ucw.cz> >> > > I picked it up in our tree with minor commit message fixes. > I also added the Fixes tag for stable. > > Thanks! Hi, Are we going to see this fix in 4.19? hopefully. thanks,
On 10/6/18 5:44 PM, Randy Dunlap wrote: > On 9/16/18 3:12 AM, Grumbach, Emmanuel wrote: >>> >>> >>> .max_tfd_queue_size was ommited for old cards, leading to oops in swiotlb. >>> >>> Signed-off-by: Pavel Machek <pavel@ucw.cz> >>> >> >> I picked it up in our tree with minor commit message fixes. >> I also added the Fixes tag for stable. >> >> Thanks! > > Hi, > Are we going to see this fix in 4.19? hopefully. Sorry, I see it now. thanks,
--- linux/drivers/net/wireless/intel/iwlwifi/cfg/1000.c 2018-09-05 13:12:40.453164067 +0200 +++ linux-64/drivers/net/wireless/intel/iwlwifi/cfg/1000.c 2018-09-16 11:54:04.010970756 +0200 @@ -51,6 +51,7 @@ static const struct iwl_base_params iwl1000_base_params = { .num_of_queues = IWLAGN_NUM_QUEUES, + .max_tfd_queue_size = 256, .eeprom_size = OTP_LOW_IMAGE_SIZE, .pll_cfg = true, .max_ll_items = OTP_MAX_LL_ITEMS_1000,
.max_tfd_queue_size was ommited for old cards, leading to oops in swiotlb. Signed-off-by: Pavel Machek <pavel@ucw.cz>