From patchwork Sat Oct 6 18:42:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 10629291 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DE4D41731 for ; Sat, 6 Oct 2018 18:43:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C540128B73 for ; Sat, 6 Oct 2018 18:43:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A3B9A290DC; Sat, 6 Oct 2018 18:43:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4DEFD28B73 for ; Sat, 6 Oct 2018 18:43:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727993AbeJGBrS (ORCPT ); Sat, 6 Oct 2018 21:47:18 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:60235 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbeJGBrS (ORCPT ); Sat, 6 Oct 2018 21:47:18 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1g8rXL-0004Ve-EZ; Sat, 06 Oct 2018 18:42:47 +0000 From: Colin King To: Ping-Ke Shih , Kalle Valo , "David S . Miller" , Larry Finger , Tsang-Shian Lin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement Date: Sat, 6 Oct 2018 19:42:46 +0100 Message-Id: <20181006184246.29985-1-colin.king@canonical.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King The switch case RATR_INX_WIRELESS_MC has a missing break, this seems to be unintentional as the setting of variable ret gets overwritten when the case falls through to the following RATR_INX_WIRELESS_AC_5N case. Fix this by adding in the missing break. Detected by CoverityScan, CID#1167237 ("Missing break in switch") Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver") Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c index 317c1b3101da..8af49c1c99db 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c @@ -3448,6 +3448,7 @@ static u8 _rtl8821ae_mrate_idx_to_arfr_id( ret = 6; else ret = 7; + break; case RATR_INX_WIRELESS_AC_5N: if (rtlphy->rf_type == RF_1T1R) ret = 10;