From patchwork Fri Nov 30 22:53:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 10707385 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A6DFB14BD for ; Fri, 30 Nov 2018 22:53:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 78E322BFD0 for ; Fri, 30 Nov 2018 22:53:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6709A2DB6D; Fri, 30 Nov 2018 22:53:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF9B02F237 for ; Fri, 30 Nov 2018 22:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbeLAKEW (ORCPT ); Sat, 1 Dec 2018 05:04:22 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:45696 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbeLAKEW (ORCPT ); Sat, 1 Dec 2018 05:04:22 -0500 Received: by mail-pf1-f193.google.com with SMTP id g62so3481878pfd.12 for ; Fri, 30 Nov 2018 14:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vI0KI725ppQ0QeLybOn4zRDFbG68JsgaLaeS7ewMwVs=; b=FC7h9H+DMLKizpZo+y0wAxjKBRzX9yld/uScHN2kAY8wmn3wW3yEbDrCuu6kZiB0hS tDhgTBzWsbzx4Rb6Lh3sKonl3Li5VQN6uzO3sDwamOBOvdy6krnrPLAQslLDgILE6gLD CKrFVMBgiM7LJpFsbMU1qmka3pJ3AURjHWE6s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vI0KI725ppQ0QeLybOn4zRDFbG68JsgaLaeS7ewMwVs=; b=dgyShKigJ/1dBpzpvgXbORaYGlp6DXkgPo+o2L3kAQlCg9vkSjMktn9Rv2WXlWRVbv 6CEXW6B0yyROjmgYkKDR4fjfJd/Kp9yAWmD4TiB+sX5Kqj+pVUgwptX2rVUVjt/yB72L I+JePHgEaEBZxh4O6M04bC4kn97LAS6PR7BqX8W0+X/Ve/x3eJrKAhL5wGsriiwIYQrn 8q7wUj/ND8A4xwVzxFAWFKgB+cSvJp2X63qgDxwDsY6l0RJWIjiFlTsic3KISplAHVcT YFPtrivAxqsbwMOY1DMG57ZQ15XOmPxmiUbQ2tQYV2Jduv3h0s8821j0o8s/8Hjkhsiu DJ2A== X-Gm-Message-State: AA+aEWZYSzhOWYQbQ8b2AWdzIlgZB5NFHX1h7MD8xN0SCzmXEvH3zBmv EXRnwWHjpZD59G+6yfYEg813mA== X-Google-Smtp-Source: AFSGD/U2ai+4OERoKbpzYCn/NSuldX/3K+5nLpm7A2GZ7CSD1EXdlWv3Ij2GzDnSslIOvbfks0q2rg== X-Received: by 2002:a63:580a:: with SMTP id m10mr6234892pgb.332.1543618410248; Fri, 30 Nov 2018 14:53:30 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:1:534:b7c0:a63c:460c]) by smtp.gmail.com with ESMTPSA id 7sm25542478pfm.8.2018.11.30.14.53.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Nov 2018 14:53:29 -0800 (PST) From: Brian Norris To: Kalle Valo Cc: , Amitkumar Karwar , Nishant Sarmukadam , Ganapathi Bhat , Xinming Hu , linux-wireless@vger.kernel.org, Brian Norris Subject: [PATCH 1/3] mwifiex: debugfs: correct histogram spacing, formatting Date: Fri, 30 Nov 2018 14:53:01 -0800 Message-Id: <20181130225303.143409-1-briannorris@chromium.org> X-Mailer: git-send-email 2.20.0.rc1.387.gf8505762e3-goog MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, snippets of this file look like: rx rates (in Mbps): 0=1M 1=2M2=5.5M 3=11M 4=6M 5=9M 6=12M 7=18M 8=24M 9=36M 10=48M 11=54M12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40) 44-53=MCS0-9(VHT:BW20)54-63=MCS0-9(VHT:BW40)64-73=MCS0-9(VHT:BW80) ... noise_flr[--96dBm] = 22 noise_flr[--95dBm] = 149 noise_flr[--94dBm] = 9 noise_flr[--93dBm] = 2 We're missing some spaces, and we're adding a minus sign ('-') on values that are already negative signed integers. Signed-off-by: Brian Norris --- drivers/net/wireless/marvell/mwifiex/debugfs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/debugfs.c b/drivers/net/wireless/marvell/mwifiex/debugfs.c index cce70252fd96..65e48e16cb49 100644 --- a/drivers/net/wireless/marvell/mwifiex/debugfs.c +++ b/drivers/net/wireless/marvell/mwifiex/debugfs.c @@ -273,14 +273,14 @@ mwifiex_histogram_read(struct file *file, char __user *ubuf, "total samples = %d\n", atomic_read(&phist_data->num_samples)); - p += sprintf(p, "rx rates (in Mbps): 0=1M 1=2M"); + p += sprintf(p, "rx rates (in Mbps): 0=1M 1=2M "); p += sprintf(p, "2=5.5M 3=11M 4=6M 5=9M 6=12M\n"); - p += sprintf(p, "7=18M 8=24M 9=36M 10=48M 11=54M"); + p += sprintf(p, "7=18M 8=24M 9=36M 10=48M 11=54M "); p += sprintf(p, "12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40)\n"); if (ISSUPP_11ACENABLED(priv->adapter->fw_cap_info)) { - p += sprintf(p, "44-53=MCS0-9(VHT:BW20)"); - p += sprintf(p, "54-63=MCS0-9(VHT:BW40)"); + p += sprintf(p, "44-53=MCS0-9(VHT:BW20) "); + p += sprintf(p, "54-63=MCS0-9(VHT:BW40) "); p += sprintf(p, "64-73=MCS0-9(VHT:BW80)\n\n"); } else { p += sprintf(p, "\n"); @@ -310,7 +310,7 @@ mwifiex_histogram_read(struct file *file, char __user *ubuf, for (i = 0; i < MWIFIEX_MAX_NOISE_FLR; i++) { value = atomic_read(&phist_data->noise_flr[i]); if (value) - p += sprintf(p, "noise_flr[-%02ddBm] = %d\n", + p += sprintf(p, "noise_flr[%02ddBm] = %d\n", (int)(i-128), value); } for (i = 0; i < MWIFIEX_MAX_SIG_STRENGTH; i++) {